New Table 4.2 entries proposed by Canada about grib2 HOT 12 CLOSED

I think that it would be better to have a new table also for the parameters in Numeric**** units. We should avoid putting information in the notes. Let's remember that notes are not in the xml or csv format of the tables which is used in by the decoders and are only in the pdf version of the manual.

from grib2.

I am not in favor of using and expanding Code Table Discipline 1, Category 1 . My understanding is that parameters containing "probability of ..." are deprecated in favor of using the Template 4.5,setting type of generating process to "probability forecast", setting the probability type using Code Table 4.9, and then your limits for the probability in the following octets.
This is why I don't think the parameters in discipline 1, category 1 should not be accepted/added, they can already be encoded using the mechanism described above. (Note as well that 2 of your parameters have an entry in the reserved area for local code of the table).

What is the difference between your snow level and discipline 0, category 1, number 11?

For the "presence of ..." parameters, I would change the units to "boolean". What these fields provide is in fact a bitmap.

from grib2.

I should also add that in GRIB3, discipline 1, category has been considered deprecated and has been deleted. I am in the process of committing the tables in the GRIB3 repository.

from grib2.

cc @jbathegit

Thanks @sebvi . I have updated the proposal above by removing probability parameters in lieu of implementing with PDT 4.5, and updated the units of the presence parameters as booleans (per 4.222).

Note also I've changed snow level to parameter number from 36->40 given #25. See the following paper as reference/example of the term "Snow level". We could also name this parameter "Snow level (melting level)" to reduce ambiguity if desired.

from grib2.

@tomkralidis @ypell I have created a branch for this issue, with changes implemented in the table mentioned above. Could you please check it? Thanks.

from grib2.

Thanks @chenxiaoxia2019; in comparing https://github.com/wmo-im/GRIB2/compare/issue-17 to the proposal above, is there any update on the below?

from grib2.

@tomkralidis Hi, Tom. Thanks for your check. The above mentioned parameters have been updated in GRIB2_CodeFlag_4_2_CodeTable_en.csv. Please check it.

from grib2.

Thanks @chenxiaoxia2019 . I see tables 4.246 and 2.247 are non-existent. I updated the proposal above. Can you update the branch with 4.246 and 4.247?

from grib2.

@tomkralidis Hi, Tom, I updated the branch with tables 4.246 and 4.247. Could you please check it? Thanks.

from grib2.

Thanks @chenxiaoxia2019 . Looks good to me. +1.

from grib2.

SUMMARY: Add entries to Code Table 4.2, add Code Tables 4.246 and 4.247

from grib2.

Approved by FT-2020-2.

from grib2.