Comments (16)
I can explicit a bit more the request regarding PDT 4.83:
Back in November when I drafted the PDTs 4.76-4.83, I used the original PDTs 4.40-4.47 that do not contain the extra octet that specifies the source/sink. When doing that, PDT 4.83 came out wrong, missing the octet for "Type of generating process (table 4.3)".
Again, we noticed it in December and notified Atsushi, who replied it was still on time to update PDT 4.83. Apparently, it did make it through.
But the underlying reason why PDT 4.83 went wrong is because it was based on PDT 4.47 and this PDT is "very" special: it is only PDT where the sequence "Type of generating process (see Code table 4.3)", "Background generating process identifier (defined by originating centre)", and "Forecast generating process identifier (defined by originating centre)" is broken. In all other PDT 4.XX that contains these octets, they are always following each other in that order. I guess it was a mistake when creating PDT 4.47 and I somehow got confused to find "Type of generating process (see Code table 4.3)" in the "wrong" place and deleted it!
For ecCodes, it is an even bigger issue because we relied on the sequence of these keys and PDT 4.47 is implemented wrongly in ecCodes since "zero-day" for that reason.
What I propose:
Deprecate PDT 4.83 and create a correct PDT, probably 4.84, with the missing octet
Deprecate PDT 4.47 and create a new PDT, probably 4.85, with "Type of generating process (see Code table 4.3)" in the "right" place
from grib2.
This problem was reported to WMO secretariat back in December but the template was not fixed accordingly. If it is too late to change it, then we need to deprecate this template and create a new one.
from grib2.
A new template 4.84 could be created, then add a note to 4.83 stating "It is recommended not to use this template. PDT 4.84 should be used instead, because it contains an additional octet to specify the type of generating process."
The same approach was used previously for PDT 4.44, directing folks to use 4.48 instead.
from grib2.
I agree with @jbathegit
from grib2.
@sebvi Hi, Sebastien, a new branch for this issue has been created. Could you please make the changes? FYI, (1) I checked the latest version https://community.wmo.int/activity-areas/wmo-codes/manual-codes/latest-version GRIB25, there is no octet for "Type of generating process" in 4.83 in the PDF version of the TEMPLATE.BUT, such octet is there on machine readable text and xml files. (2) And, I also checked the previous version, GRIB 24, both the PDF version and txt and xml files have the octet of "Type of generating process" in 4.83. https://community.wmo.int/activity-areas/wmo-codes/manual-codes/previous-versions/2019-11-06 (3) For GRIB 23, neither of them have such the octet. The question is that do we still need to create 4.84?
from grib2.
@sebvi The new branch is: https://github.com/wmo-im/GRIB2/tree/issue-14
from grib2.
Hi @chenxiaoxia2019 : I think this needs to be discussed in more details because we need to also need to discuss "where" in the template sequence "Type of generating process" should be introduced.
I am in favor of deprecating 4.83 and 4.47 and create 2 new templates with "Type of generating process" in its "usual" place in the sequence of octets.
from grib2.
The team decided to create new templates for 4.83 and 4.47. The new templates will be the suggested way of encoding, old templates are not deprecated.
from grib2.
I have pushed a commit to add the new templates.
template 4.84 deprecates template 4.83
template 4.85 deprecates template 4.47
from grib2.
I just realized that code table 4.0 needs to be updated as well to include the 2 new templates :) I will do it
from grib2.
@chenxiaoxia2019 : has this been merged yet?
from grib2.
@sebvi Hi,Sebastien, this issue has already been merged to Master. Thanks.
from grib2.
SUMMARY: Add two templates. Template 4.84 is an improvement of Template 4.83 and Template 4.85 is an improvement of template 4.47. Note, 4.83 and 4.47 are not deprecated.
from grib2.
I hope you meant "Note, 4.83 and 4.47 are NOW deprecated."
from grib2.
@shahramn the team decided not to deprecate the two templates.
from grib2.
Approved by FT-2020-2.
from grib2.
Related Issues (20)
- Code Table 4.2 : new fire parameters HOT 3
- Code Tables 4.1, 4.2 and 4.5: new entries for ERA6 and Destination Earth datasets HOT 7
- New section 3 grid template: The HEALPix grid HOT 35
- Code Table 4.2, discipline 0, category 19: new entries for persistent contrails HOT 4
- Code Table 1.3 : adding Destination Earth entries HOT 5
- Missing code table entry in 4.59, typo in template 4.78, HOT 5
- new section 4 for encoding quantiles of post-processed products HOT 15
- Template 3.130 Irregular Latitude/longitude grid: deprecated or non-existent? HOT 1
- Spelling error in Code Table 4.0
- new entry for "Convectively-induced turbulence" in Code Table 4.2 HOT 7
- Additional entry of length or number of octets in GRIB2_Template_ csv-files HOT 5
- Code Table 4.2 : adding new parameters HOT 5
- Encoding of Drought indexes as defined by WMO HOT 8
- new ocean and ice parameters in Code Table 4.2, Discipline 10 HOT 10
- new probability templates for large ensemble HOT 9
- new templates for probability forecasts based on focal statistics HOT 8
- new section 4 template for further statistics on probabilities based on focal statistics HOT 6
- new hydrology parameters in code Table 4.2 HOT 4
- new fire weather parameter in Code Table 4.2, Discipline 2 HOT 12
- new precipitation type flag in Code Table 4.201 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grib2.