GRIB2 code/flag tables in v25.0.0 about grib2 HOT 14 CLOSED

@shahramn and @sebvi can you clarify the request?

from grib2.

I don't understand what the problem is here re: CT 1.3. I just looked at the MSWord and PDF versions of the GRIB2 Code/Flag Tables at the above URL, and they both have the correct Reserved range of 12-191. Am I missing something here?

I also don't understand the point re: the entries in CT 4.0, as currently those appear to exactly match the exact titles of the corresponding templates in the Templates document, which is what we would expect. Or is the request to formally change the titles of the templates (as well as the corresponding CT 4.0 entries) to add "with source/sink", perhaps to more easily distinguish them from PDTs 4.40-4.47?

from grib2.

I can't speak for @shahramn about what he meant with Code Table 1.3 .Like @jbathegit I don't see a problem with the reserved range.

Regarding PDTs 4.76 to 4.83, yes the idea is the rename them, adding "with source/sink" to distinguish them from the PDTs 4.40 to 4.47. WE notified Atsushi about this back in December but it got somehow "lost in translation" during his retirement I guess.

from grib2.

Sorry I should have said the problem is in the TEXT file not PDF/Word.
We use the text file to extract the information via a script.
Download the file "GRIB2_25_0_0_GRIB2_25_0_0_CodeFlag_en.txt" from the ZIP file next to "Machine readable text and xml files (see Notes 4 and 5)".
Search for "Production status of data"
Now you see the following 3 rows:

59.00,"Code table 1.3 - Production status of data",,"10",,"Copernicus regional reanalysis",,,"Operational"
60.00,"Code table 1.3 - Production status of data",,"11",,"Copernicus regional reanalysis test",,,"Operational"
61.00,"Code table 1.3 - Production status of data",,"10-191",,"Reserved",,,"Operational"

Here it should say 12-191 and not 10-191

from grib2.

@chenxiaoxia2019 & @efucile: should we create a branch for this? If the branch is created I can do the changes (the first column in template 4.76 to 4.83 should include "with source/sink" at the end of the string like it is the case in the pdf version)
EDIT: it does not seem to be in the pdf version either.

In any case, the mention "with source or sink" needs to be added to template 4.76 to 4.83 (and in the separate issue, in the newly created 4.84)

from grib2.

@sebvi Hi, Sebastien, a branch for this issue has been created: https://github.com/wmo-im/GRIB2/tree/issue-13 Please make the changes as proposed and make a comment here. Thanks.

from grib2.

ok great! I will do! thanks @chenxiaoxia2019

from grib2.

I have pushed a commit in this branch to resolve the issue. please check @chenxiaoxia2019

from grib2.

@sebvi Thanks, Sebastien. I checked them. They look very well. FYI, I also updated Code table 1.3, changing from "10-191 Reserved" to "12-191 Reserved".

from grib2.

@chenxiaoxia2019 has this been merged yet?

I am wondering when the next release 26 is going to be created, it looks like some of the contributions for that version have already been merged into master.

from grib2.

It would be nice if we could get a pre-release v26 as a ZIP file so we can generate ecCodes tables/definitions for internal testing

from grib2.

@sebvi Hi, Sebastien, thanks for your remind. This issue has already been merged to Master Branch.

from grib2.

SUMMARY: Add "with source or sink" to the titles of templates 4.76 to 4.83 and in Code Table 4.0. Code Table 1.3 is modified, but this was an error that only existed in the CSV.

from grib2.

Approved by FT-2020-2.

from grib2.