wmannis / simple-rgb Goto Github PK

The function COMPLIMENT-RGB actually implements the "complement" 
procedure.  It should be renamed COMPLEMENT-RGB for correctness.

Attached is a patch affecting package.lisp, rgb.lisp and test-rgb.lisp to 
this effect.

As a precedent, note the use of "complement" in the Adobe docs 
http://livedocs.adobe.com/en_US/Illustrator/13.0/help.html?content=WS714a382cdf7
d304e7e07d0100196cbc5f-6288.html

Original issue reported on code.google.com by [email protected] on 30 Aug 2008 at 5:19

Attachments:

• complement.diff

It points to https://github.com/wmannis/simple-rgb/blob/master/Dufy which does not exist. Likely you've switched [] and () in Markdown when writing the hyperlink.

I would like to depend on simple-rgb in a place that requires hue-shifting RGB colors with high performance, therefore I would like to be able to locally inline the code for the relevant functions.

Please make rgb->hsv, hsv->rgb, rotate-hsv and rotate-rgb locally inlineable as per the CLHS example noted below.

The CLHS says:

To define a function f that is not inline by default but for which (declare (inline f)) will make f be locally inlined, the proper definition sequence is:

(declaim (inline f))
(defun f ...)
(declaim (notinline f))