wix-incubator / protractor-browser-logs Goto Github PK

Use the same requirements as the protractor has, because it's a protractor enhancement tool

If multiple warning or severe level messages appear over the browser console, logs.verify() returns only last/latest message. It would be great if you extend the function to return all warning and severe level messages instead of returning only one message.

(I will do it)

As a user it is not clear which are the differencies with protractor-console-plugin.

In particular it should be great if the documentation could explain:

• which are the difference in the feature-set;
• which browsers does the plugin support;
• if the browser support the library is tested in Continous Intergration (e.g. travis + saucelabs).

please allow us to define our own test-fail method to overwrite the following snippet:

                throw new Error('UNEXPECTED MESSAGE: ' + JSON.stringify({
                  level: actual.level.name,
                  message: actual.message
                }));

Your library is being tested during development of an app that I'm working on. Due to the license missing, it is unclear how people can use the software.

Can you select a license and add it to the project?

I can't use the version 1.0.10 for the foreseable future as we have our whole infrastructure on 0.12. There's no old version available.

I'm submitting a patch, if it could be integrated in a off-numbered version it'd be great, until we move on to node 4/5.

It seems like this thing eats up my console.log/console.warn etc

I would have preferred seeing all those logs as I do using the protractor-console plugin. Currently I have to comment out protractor-browser-logs to be able to debug using console.log

From what I see browser.manage().logs().get('browser') is "eating" up the logs so when protractor-browser-logs fires before protractor-console then there's nothing to log anymore.

We have a need to capture all browser console logs for each test scenario. However, due to the design of console logs in the driver, when they are read, they are no longer available on follow-on reads. So, using protractor-browser-logs and having the need to log all console logs causes an issue. However, it is easy to fix.

I recommend exposing the logs() function to the constructor function. This will allow me to accomplish both tasks and may be helpful to others with similar constraints. If team is happy with this idea, I can put together a PR for the fix.

It seems that this package could be refactored, so it would work with either protractor or a console streams (stdout or stderr).

That way it could work also with Node/enzyme component tests.

It could be a separate open-source project.
I've seen test-console, but is does not offer assertion utils.

Any thoughts before I give it a try?