wisniewskit / google-search-fixer Goto Github PK

"*http should be replaced with "http at

Because include_globs is evaluated after the specific patterns in matches is applied, this doesn't inadvertently result in incorrect matches, but still it would be nice to omit the unnecessary * prefix.

As reported in mozilla-mobile/fenix#23058, it appears after issuing a search in the URL bar, the search results page will automatically act as though the user has tapped on a random (?) search result. I'm currently unable to reproduce this on my phone, so I'm hoping to find out if other addons might also be active, or even an A/B test Google might be running (since I've only received two reports of this over the past week, and I would expect more if it was consistently happening).

When the addon (the mobile version) is enabled, this is what I see in the Shopping tab on google:

As soon as I disable the addon, images are restored:

Running Firefox v105.1.0 on Android 12 on Google Pixel 3

As of today this extension has been disabled on Android devices after the upgrade to Firefox 79.
Cannot test on Apple iOS.

The add-ons store tells me that 'this extension (https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/) isn't available on your platform'. I tried downloading it and running, but it opens up the mobile version of search, not the desktop one.

I am getting gradient images instead of site favicons. This started happening about a week ago or so.

Attached image to show error

A user has reported that this breaks the "Request desktop site" feature. Hopefully this will not be too tricky to fix.

Originally moved from mozilla-mobile/fenix#26387
and moved again from https://bugzilla.mozilla.org/show_bug.cgi?id=1784005

Steps to reproduce

1. From Settings > Add-ons, enable Google Search Fixer.

2. Go to google.com.

3. From the bottom on the page, enable the Dark theme (Dark theme: on).

4. Tap the 3-dot menu and enable the Desktop site mode.

5. Observe the theme on the webpage.

Expected behaviour

When Desktop site mode in enabled, the dark theme remains enabled.

Actual behaviour

When Desktop site mode in enabled, the dark theme is replaced by light theme.

Device name

Lenovo Yoga Tab 11

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

Nightly 105.0a1 from 08/08.

Device logs

No response

Additional information

Also reproducible on Beta and RC. https://user-images.githubusercontent.com/89388888/183678028-7a4e5e60-1b44-46f0-b7d4-ddca8e360273.mp4

┆Issue is synchronized with this Jira Task

I get 502 errors on most searches (seems to work for one request after waiting a while). Disabling the extension fixes the issue.

I will note that my URL begins with this, which may be relevant:
https://www.google.com/search?client=firefox-b-1-m

My browser is Firefox mobile. I have not tested any others.

125.3.0 (Build #2016017559), 9f29904153+
GV: 125.0.3-20240425211020
AS: 125.0.1

When you scroll to the bottom in the image search, more images are not displayed.

Earlier when you search something, there would be a voice interface icon on the right.
When typing, there would be a similar cross/close button on the right end to clear all text.
Both of these seem to be missing in the present Fenix Beta as well as Nightly. It was definitely still available till a few days ago.

Missing voice interface button:

Missing 'X' close button:

For some reason, the cross is present when on the Images category.

Is it an error on my device or has this been changed?

Device: Oneplus 7, Android 10

Edit:
Voice interface button is present when reloaded, but quickly dissappears

A month ago a developer option for Edge Canary on Android was rolled out that allows installing extensions via store ID or crx. Myself and likely many others would like to make use of this extension if you'd be willing to port it.

The extension currently requests the "Access your data for all websites" permission. While the initial implementation required that, the latest version (from #11) does not. We should check if Firefox for Android (Fenix) is able to cope with almost 200 domains in the permission lists (and if reducing the permission does not trigger new warnings, and that we don't need other host permissions). If it works, we can replace

with the list of host permissions at

With this add-ons enabled now I can get the google search image working great, and everything is ok, but the biggest issue is that this also enable the use of google amp for some of the search result , is it possible to add a setting to disable the use of amp???

Thanks

Bug

Source

Firefox UA string example

Mozilla/5.0 (Android 10; Mobile; rv:102.0) Gecko/102.0 Firefox/102.0

Description

The regex /Android\/[0-9.]+/ does not match Firefox UA and Google Search Fixer always use Android 6.0.

Actual case of web-compat issue

STR

1. Install Google Search Fixer
2. Open https://www.google.com/search?hl=en&q=tiger

Expected result

The 3D result for Bengal tiger is available.

Actual result

The 3D result does not displayed.

Cause

This feature is limited to Android 7 and up.
https://support.google.com/websearch/answer/9817187

Experience 3D & augmented reality in Search

When you search on Google, you can view some results in 3D and augmented reality (AR).

What you need

• To view 3D results: An Android phone with Android 7 and up.
• To interact with 3D results in AR: An Android phone that supports ARCore. Learn more about which devices support AR.

I tried to remove the addon since I don't like the changed search page. Removing the addon and restarting FF does not reset the user agent. FireFox 68.0.2 (64-bit)

How can I reset the user agent string to defaults?

I'm using Firefox Nightly 119.0a1 for Android, but when I refresh the Google search results, it switches to dark mode and gets fixed, but even if it switches to dark mode somewhere, it doesn't get fixed and resets to light mode.

Error on Google's part?

With webRequest api being replaced with declarativeNetRequest in Manifest V3. Creation of a MV3 version will be great

Hello, I want to ask why this extension needs to access data for all websites, instead of just access data for google.com?
Thank you.

As soon as page load finishes, the icon at the right of the search box disappears (even the voice search icon). Checked after disabling all other addons.

Icon shows up correctly if search fixer is disabled, i.e., on old google interface.

Currently, this extension is breaking Google on Android. When I'm tapping on "See more" button, then it changes to "Try again" button and does nothing.

As it has been reported many times on the add-on home page recently, whether it's something Google did or Mozilla, using this add-on makes Firefox "freeze" when tapping on images in Google search.

I have set my google settings to 20 results instead of default 10 results.

Problem with the add-on is that after pressing "load more" it shows duplicate results (second 10 results from the first page)

Upon investigation, Google has apparently just enabled a service worker for Chrome for Android 62 and up, and that service worker is not standards-compliant. It triggers the following error, which causes the searches to end up "corrupted":

Failed to load ‘https://www.google.ca/search?[snip].
A ServiceWorker passed a promise to FetchEvent.respondWith() that
rejected with ‘TypeError: HEAD or GET Request cannot have a body.’

Since my addon spoofs Firefox to act like the most recent Chrome version, the bug affects it. For the time-being, I will have to have the addon block the service worker.

Unfortunately, already-affected users will have to visit the URL about:serviceworkers and remove it manually from there (after upgrading, so it gets blocked instead of just reinstalling itself the next time a search is made).

Hi! Thanks for your development. Using this on Firefox Android 119.1.1, on Android 13. I'm running into this issue with the current Google.

Mostly everything is fine, but the search bar has a weird right margin.

Here remain old/bad layout.
https://images.google.com/?hl=it

Hope u can fix 👍