wintercooled / dotnetcoredynamicjson-rpc Goto Github PK

dotnetcoreDynamicJSON_RPC.cs contains methods from an earlier version of the code that used to also start and stop the daemons. This was removed because it was overkill for what is supposed to be a simple piece of code.

e.g.: DaemonIsRunning

Might be worth having some kind of check for things like it the daemon is reachable but that can be covered by the error handling enhancement.

To cover:

DONE 1 Explain string extension methods up front.
2 Do a set up guide for Ubuntu from the terminal (not using Visual Studio but dotnet run etc).
3 Explain how node should be set up
DONE 4 Explain that we don't use data objects but JSON strings - the most we do is List and Linq. e.g. we don't use a block.cs for example.

c-lightning uses unix sock file I think so no RPC access over TCP - there are rpc wrappers out there but not sure how to do in .NET Core.

I have code to use Linq to query the returned data - it complicates otherwise simple example code but may add if I can annotate it well enough to explain what's going on.

Currently you have to pass integer or decimal values into methods such as getblockhash(500) as getblockhash("500) will fail.

This goes against the 'simple to use' design idea. Can either convert within rpc call code or try some of the newtonsoft parse modes.

Could do with handling connection errors etc better - e.g. when node not running etc.

Need to determine what's needed - perhaps look at how python-bitcoinrpc handles it?

Same as GetResult but is GetValue - add use to example code.

Not sure why this was removed - it connects wit h or without it.

Needs testing and looking into why it is needed - I have a feeling it is a hangover from Windows testing when the code was .NET based not .NET Core.