windmill-helm-charts's People
Forkers
sagar2366 ethanmdavidson 24601 bitsy-ai antrix amitai-devops devdocsorg elementtech tigercomputing pcn pcmid benjie91 anton-shutik dedene isc-patrick c0bra spearstone fermuch regaipserdar camilacampos matt-funda inglemr brunobriante eligrey momentmaker tdeckers-cisco freimer thebsosa avo-seppwindmill-helm-charts's Issues
Image Pullsecret for custom private Docker image not available
Hi !
It looks like there is no imagePullSecrets parameter available in this Helm Chart to use a custom Docker Image from a private Docker registry.
Why is is default user Root and runAsNonRoot false?
Hi,
Question is in the title. The default configuration for Windmill's Helm chart sets Windmill as root. Is there a developer reason for this? It impacts our ability to install Windmill in clusters with security features enforced. Does Windmill need to be run as root?
If it's not required for Windmill then I'd like to unset it from the default and maybe consider making some improvements to the Helm chart to meet higher security defaults.
Init Script in not available in the Worker Management UI
Hi,
The Init Script box parameter seem not available in the Worker Management UI when using this Helm chart.
I m using the Helm chart with Windmill CE v1.181.0 docker image.
![Capture d’écran 2023-10-10 à 08 11 09](https://private-user-images.githubusercontent.com/31832102/273796348-8370b848-6cb7-4b24-8928-e7bc7f3b2413.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMDU1NTYsIm5iZiI6MTcwOTIwNTI1NiwicGF0aCI6Ii8zMTgzMjEwMi8yNzM3OTYzNDgtODM3MGI4NDgtNmNiNy00YjI0LTg5MjgtZTdiYzdmM2IyNDEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI5VDExMTQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4YjNkZWRmYTM2OTdjNmRkZDg1ZmRkNGRmOTRmMTM2NDJjN2I4MWNlNTcxNDczZTEzNzJkYzhjMDNmMzExNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MgcI3t4sd1xkN4BG9k8AZeCzaGuRzvYDDdmF0UztWEA)
If I use the same image with the Docker-compose file provided in the doc, the Init Script box is available, and the Worker Management UI looks different.
![Capture d’écran 2023-10-10 à 08 16 27](https://private-user-images.githubusercontent.com/31832102/273795494-b8a448a8-e666-4d05-a7e0-a2f8aa450f88.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMDU1NTYsIm5iZiI6MTcwOTIwNTI1NiwicGF0aCI6Ii8zMTgzMjEwMi8yNzM3OTU0OTQtYjhhNDQ4YTgtZTY2Ni00ZDA1LWE3ZTAtYTJmOGFhNDUwZjg4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjI5VDExMTQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhZWNiNzM4YThiMmRiMmY0ZmIxOTZhZTE2NzVlNjc0ZWVkZjBhM2JjZjliZTdmNmVhZmY1NDM3ZDU5YmQ3MjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.njCBoeildSoQKcbxMP1QLkac5-zuOxVLjfCDLhlBuBw)
Am i missing something ?
Thanks !
Replicas seems to not working
Hi team 👋🏼
I'm using Windmill chart on Qovery IDP for context.
But when I change replicas it doesn't seems to change the number of workers:
Here my rewrite values for testing purposes:
postgresql:
enabled: false
windmill:
databaseUrl: qovery.env.DATABASE_URL
annotations:
qovery.annotations.service
labels:
qovery.labels.service
workerGroups:
- name: "default"
replicas: 2
resources:
requests:
memory: "512Mi"
cpu: "500m"
limits:
memory: "1024Mi"
cpu: "1000m"
annotations:
qovery.annotations.service
labels:
qovery.labels.service
- name: "native"
replicas: 0
resources:
requests:
memory: "256Mi"
cpu: "100m"
limits:
memory: "256Mi"
cpu: "100m"
annotations:
qovery.annotations.service
labels:
qovery.labels.service
- name: "gpu"
annotations:
qovery.annotations.service
labels:
qovery.labels.service
app:
annotations:
qovery.annotations.service
labels:
qovery.labels.service
lsp:
annotations:
qovery.annotations.service
labels:
qovery.labels.service
multiplayer:
annotations:
qovery.annotations.service
labels:
qovery.labels.service
ingress:
enabled: false
serviceAccount:
annotations:
qovery.annotations.service
available for testing if needed 👌🏼
Cheers
windmill multiplayer is enabled in the Ingress even if enterprise mode is disabled
On the Ingress definition ws_mp is always defined, even if enterprise is disabled.
Error: UPGRADE FAILED: failed to create resource: Deployment.apps "windmill-workers-dedicated-mydedicatedWorker" is invalid:
Sorry to bother you again, but the next error appeared. The error message is Error: UPGRADE FAILED: failed to create resource: Deployment.apps "windmill-workers-dedicated-mydedicatedWorker" is invalid: metadata.name: Invalid value: "windmill-workers-dedicated-mydedicatedWorker": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
In short, here your default value is written in camelCase https://github.com/windmill-labs/windmill-helm-charts/blob/main/charts/windmill/values.yaml#L107 which is a bad idea, when that ends up to be part of name of an k8s resource respectively deployment.
No need to hurry, I can work around that by setting a value by myself but I think it is better to fix it for the future.
Add minio as optional dependency
We will also add plenty of doc with @hcourdent about how to leverage s3 for blob storage
Wrong indentation for resources block
windmill-helm-charts/charts/windmill/templates/app.yaml
Lines 102 to 103 in 529925a
There is an extra indent at the beginning here, when setting resources
for app
, the following error will be reported.
Error: YAML parse error on windmill/templates/app.yaml: error converting YAML to JSON: yaml: line 84: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 84: did not find expected key
YAML parse error on windmill/templates/app.yaml
Typo in template file cause error in deploy
Here at:
Which missing $
at "{{ .Values.enterprise.s3CacheBucket }}"
serviceAccount annotations missing
I need an ability to provide some annotations to my serviceAccount. Looks like there is no way to do it.
Upgrade using 1.181 images not work
HI guys,
I m trying to use the latest Windmill docker image with this Helm chart but it crash
Error: Migrating database: while executing migrations: error returned from database: syntax error at or near "TRIGGER"
Can you help please ?
Add topologySpreadConstraints to Deployments
These are really useful for distributing pods between nodes and/or availability zones in a more expressive and flexible manner than using affinity. Please see Pod Topology Spread Constraints.
Global labels & annotations
Hi team 👋🏼
It would be nice to have a global rewriting of labels and annotations on top. Cause on my IDP (Qovery) there are some missing and I can't:
- display services logs
- stop the chart
- display services statuses
For example:
windmill:
annotations:
qovery.annotations.service
labels:
qovery.labels.service
I'm available for testing if needed 👌🏼
cheers 🍻
Enabling exposeHostDocker: true adds duplicate volumes key
When setting exposeHostDocker: true
, the volumes
key is present twice in the worker manifests:
windmill-helm-charts/charts/windmill/templates/workers.yaml
Lines 33 to 37 in bdf0257
windmill-helm-charts/charts/windmill/templates/workers.yaml
Lines 133 to 136 in bdf0257
which fails to deploy updates when using Gitops where this is validated before applying the manifests (i.e. FluxCD)
Unable to pass http_proxy environment variables to windmill scripts
Hi all
I'm not sure if this is a problem that only occurs with the windmill helm-chart, but I am unable to configure windmill to use a HTTP-Proxy.
I already tried to pass the variables http_proxy and https_proxy as extraArgs to all the windmill deployments in the helm values and I was able to "kubectl exec" into the containers and access the internet using the configured http-Proxy.
However, when i try to run a python script in Windmill, the proxy does not seem to work. I cannot import any python modules from the internet.
When I run "print(os.environ)", my envs (http_proxy & https_proxy) do not show up.
Is this behaviour expected and is it somehow possible to pass global envs to windmill scripts?
Thanks and kind regards
Robin
Better secrets control
Currently the helm is reading secrets trough environment variables. This limits the way we can inject secrets into the deployment.
Add support for reading secrets from files.
Add Env variables that point to files instead of directly to the secret value
DATABASE_URL_FILE="/some/container/path/file"
This will also adapt to different secret management methods. Like when using Hashicorp vault and dynamic database credentials
"enableOauth" is missing from default values and documentation
Allow configuring relevant Kubernetes overrides
I've noticed some slowness in general while using the helm chart. The UI gets stuck often. I would be glad if I could:
- Configure resources so I can give the pods more juice and hopefully overcome slowness
- Configure autoscaling for frontend/workers
- Configure annotations/tolerations/affinity
- etc
BYPASSRLS not allowed on Azure flexible Postgres db
Hi, regarding the use of a managed Postgres database in Azure, superuser access is not given to the owner. Therefore, there's no way to give BYPASSRLS permissions. The init-db SQL file may need to be adjusted to match scenarios where superuser is not given in cloud-hosted managed databases.
Issue for windmill main repo, please close
Allow adding extra labels to Deployments made by the chart
Some kubernetes addons we would like to use with windmill require us to add labels in the Deployment template field.
There is currently no option to do this.
Error: UPGRADE FAILED: parse error at (windmill/templates/dedicated-workers.yaml:132): unexpected EOF
Bonjour. When performing a helm upgrade mywindmill windmill/windmill -n windmill
after I executed helm repo update windmill
I got the following error message. "Error: UPGRADE FAILED: parse error at (windmill/templates/dedicated-workers.yaml:132): unexpected EOF"
Setup gh-action to host chart in gh-pages
Turn this repo into a chart repository using gh-pages and actions provided by helm.
Official doc: https://helm.sh/docs/topics/chart_repository/#github-pages-example
Reference repo: https://github.com/technosophos/tscharts
Chart release action: https://helm.sh/docs/howto/chart_releaser_action/
Configure postgres credentials to be secret
For demo purposes, postgres creds are currently plaintext. Very bad, will change to use secrets.
Helm Chart rendering RunAsUser at the wrong indent
External database missing role setup
When bringing my own database, by setting databaseUrl
, I encounter a couple of issues.
- I need to manually create
windmill_user
andwindmill_admin
roles, otherwise some of the pods error. - After logging in as the default user I get
Not found: App not found at name g/all/setup_app
, which means I don't substitute the default user for my own etc.
Wrong appVersion in Chart.yaml
Hi, the latest commit bumps the appVersion to "1.222.0", that image tag does not exist, the latest tag is "1.220.0".
Typo?
Thanks :)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.