williamespindola / abstract-http-client Goto Github PK

Possible implementation

        foreach ($parameters as $key => $param) {
            if (preg_match("/{$key}/i", $this->endPoint)) {
                if (is_null($this->uri)) {
                    $this->uri = $this->endPoint;
                }

                $this->uri = str_replace($key, $param, $this->uri);
            }
        }

Detailed description

README file must be refactored with correct code, this actual examples is using old namespaces examples like :project_name

Context

Developers must see and understand how this works

Possible implementation

Put correct namespaces and give more and complete examples about project functionality. May be a better integration test as example can be a good job.

Detailed description

Scrutinizer is showing 6 issues with code quality

Context

Because code quality really matters!

Possible implementation

See Scrutinizer report and follow your warnings.