williambarreiro / clean-code-dart Goto Github PK

You use final often in cases where the value is known at compile time like final millisecondsPerDay = 86400000;. Dart has const for declaring variables that are known at compile time.

Switching on runtimeType is bad. If a new DartDeveloper class would be added that subclasses Developer your code would stop working. You violate the Liskov Substitution Principle.

Till we have pattern matching you need to do:
if (employee is Manager){
...
}
else if ( employee is Developer{
...
}