Comments (3)
Hey Matt,
Funny you found this as I just fixed that in the 0.9.9 release (converting the map iterator to a list). I forgot to push my local changes to the git repo but it is in the PyPI release, but the changes are there now so you might need to merge them into your branch.
Anyway, the variable length code is something I've long suspected but didn't have an FCS sample to properly test (thanks for the example!). Not sure how that map bug originated...FlowIO, FlowUtils, and FlowStats were all created from the original fcm package I inherited years ago. Nice to see FlowIO getting a fresh pair of eyes.
I'll review your latest PR and get back to you later today.
from flowio.
Hi Matt,
Your PR has been merged. The additions in PR were incompatible with Python 2, but I decided it was time to drop Python 2 support since it is EOL. FlowIO 0.9.10 has been released with the new bug fix.
Thanks again, your recent contributions are much appreciated!
from flowio.
Glad to hear it and happy to help!
from flowio.
Related Issues (14)
- Removing a channel HOT 2
- Missing set zeroes if data offsets are greater than header max data size HOT 3
- Error when exporting some FCS files: REPORT BUG: error calculating text offset
- Open files containing multiple datasets HOT 5
- Getting event data as an Int but expecting a float? HOT 2
- Missing license HOT 5
- Clarify parsing of examples/fcs_files/100715.fcs HOT 4
- Better handling of data section byte offset discrepancy
- Incorrect estimation of data_stop HOT 7
- Support for FCS3.2 HOT 2
- Issue loading fcs files HOT 5
- FlowData.write_fcs attempts to write strings to file opened in binary mode HOT 5
- write_fcs mixes up PNN and PNS labels HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowio.