Comments (3)
whitews
commented on June 14, 2024
Hi Andreas,
Thanks for reporting this & for the PR. Looks like we can just check for the end data offset since it would be >= the begin data offset and these values are calculated inside the function based on the event data given. Can you make this minor change to the PR?
Other than that, this looks good and the FlowData class should read these exported files fine as it defaults to checking the metadata first anyway.
from flowio.
whitews
commented on June 14, 2024
Andreas, don't worry with the modification, I've accepted this PR. I'm making some other semi-related changes & adding a test case to cover this.
Thanks again for the contribution, it's always appreciated!
from flowio.
andreas-wilm
commented on June 14, 2024
Apologies. I got distracted. Thanks for incorporating. Happy to contribute
where possible
Andreas
…On Fri, 4 Mar 2022 at 00:38, Scott White ***@***.***> wrote:
Andreas, don't worry with the modification, I've accepted this PR. I'm
making some other semi-related changes & adding a test case to cover this.
Thanks again for the contribution, it's always appreciated!
—
Reply to this email directly, view it on GitHub
<#12 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAILSCM6LL42TQSEH7WXRI3U6DTHJANCNFSM5PWLS5DA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Andreas Wilm
***@***.*** | 0x7C68FBCC
from flowio.
Related Issues (15)
- Removing a channel HOT 2
- Error when exporting some FCS files: REPORT BUG: error calculating text offset
- Open files containing multiple datasets HOT 5
- Getting event data as an Int but expecting a float? HOT 2
- Missing license HOT 5
- Clarify parsing of examples/fcs_files/100715.fcs HOT 4
- Better handling of data section byte offset discrepancy
- Incorrect estimation of data_stop HOT 7
- Support for FCS3.2 HOT 2
- Question about flow cytometry data HOT 1
- Issue loading fcs files HOT 5
- FlowData.write_fcs attempts to write strings to file opened in binary mode HOT 5
- write_fcs mixes up PNN and PNS labels HOT 1
- Parsing an FCS file with variable int sizes fails raises an exception (and it could parse much faster) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowio.