Giter Club home page Giter Club logo

Comments (9)

grantneufeld avatar grantneufeld commented on May 18, 2024 2

It would be nice if the rubycritic config was basically just an extended version of the Reek config β€” so we could copy our current Reek configuration into it, and add other configuration options for the other tools (flog, flay, etc.) and for rubycritic itself.

Or maybe provide a rubycritic config directory that can contain config files specific to each tool (e.g., .rubycritic/.reek).

In particular, I want to be able to configure skipping some of the checks from Flog and Flay (e.g., HighComplexity, DuplicateCode) for specific directories (e.g., spec), without having to ignore those directories for everything else.

Right now, my rubycritic my report gets filled up with lots of complexity and duplicate code smells from my spec directory, unless I don’t include the spec directory (and miss out on reporting the code smells I do want to see for specs).

Thanks!

from rubycritic.

natesholland avatar natesholland commented on May 18, 2024

I agree, I think a rubycritic.yml file would be a good candidate for how we handle settings.

from rubycritic.

bglusman avatar bglusman commented on May 18, 2024

In debt_ceiling I use the Confirguations gem, and read in a ruby file with rails like configuration block... I think I prefer that to yml, but agree having settings/config is a good idea.

from rubycritic.

johnkelly avatar johnkelly commented on May 18, 2024

+1. It would be great to specify in a config file which folders ruby critic should critique.

from rubycritic.

troessner avatar troessner commented on May 18, 2024

Agree, would be useful. Would somebody like to take a stab at this? ;)

from rubycritic.

troessner avatar troessner commented on May 18, 2024

The same comment I wrote for #11 applies here:

Due to RC's nature this is not really trivial since we aggregate multiple tools and those tools have a different understanding of how you can exclude and include paths. And some might not even offer an "exclude" functionality.
Nevertheless I can see that this feature would be highly valuable.

;)

from rubycritic.

nav16 avatar nav16 commented on May 18, 2024

I am working on this, using yml (rubycritic.yml) file.

from rubycritic.

westlakem avatar westlakem commented on May 18, 2024

@nav16 Any updates on this? I have a project right now where we patch a gem and it is very picky about how we patch it. This file is the only thing that's not an 'A' and is keeping me from doing a -s 100 on our ci build

from rubycritic.

piacsek avatar piacsek commented on May 18, 2024

I guess this can be closed, since we can use .reek.yml as a configuration file.

from rubycritic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.