Comments (4)
I think there are three questions here:
-
For how long should the project maintain support for an EOL'd Ruby version: drop support immediately after EOL, or wait for some fixed period post-EOL before dropping support (such as six months after an EOL date)?
-
Once the time comes, is it a hard-and-fast cutoff (immediately bump the minimum Ruby version) or a softer cutoff (possibly bumping the version requirement in a subsequent change, or only when some dependency updates or feature work necessitates it)?
-
If taking the soft EOL path, and RubyCritic will support a post-EOL Ruby until some dependency wants to pull the minimum version forward, which of RubyCritic's dependencies are worth following to a new minimum Ruby version?
For a concrete example of this sort of decision, consider the discussion in #458 in light of where things stood eight months ago and where they stand now.
Considering those questions, I suggest a soft cutoff at the same time as Ruby EOL's a version. If it's to be later, then (based on when RubyCritics dependencies updated after the Ruby 2.7 EOL) it should be no more than six months after the EOL.
After the soft cutoff date date, RubyCritic's minimum version requirement should then move (to the oldest non-EOL'd Ruby version) when a runtime dependency no longer supports the EOL'd Ruby version.
When doing so, it might also be worth cutting a "final" EOL-supporting release that more tightly locks the dependency versions (such as @nunosilva800 suggested in #477 (comment)). For example, RubyCritic 4.9.1 could include #480 plus hold Reek to < 6.2
, and RubyCritic 4.10.0 (or 5.0) drops Ruby 2.7 support.
from rubycritic.
There's a side but related issue around numbering: would bumping RubyCritic's major release numbering when Ruby bumps help with conveying the support situation? For example:
RubyCritic | New Ruby | (At some point) Dropping Support For Ruby |
---|---|---|
5.0 | 3.3 | 2.7 |
6.0 | 3.4 | 3.0 |
from rubycritic.
Related Issues (20)
- Assets (images, fonts, etc) from CDN HOT 1
- Coverage index page of "Build" shows 0 coverage if compare view
- Smell cost explanation?
- Fix CI is failing in the main branch
- Add support for Ruby 3.2 HOT 2
- Drop support for Ruby 2.6.x
- Update mdl dependency HOT 2
- Update test dependencies HOT 2
- Update runtime dependencies HOT 2
- Update rubocop dependency HOT 2
- Clean up CHANGELOG.md's contributor references HOT 3
- rake test modifies simple_cov_index.html source HOT 1
- Running in subdirectory returns `churn` of `0` HOT 1
- Rubycritic support for Ruby 3.2.2 HOT 4
- Clean test warnings HOT 3
- Links pointing to pages that do not exist when using the Compare branch option. HOT 1
- Rubycritic Not Displaying Coverage Information in Rails Project HOT 5
- Rubycritic Gem installation Failed HOT 2
- Error during analysis - Unknown revision or path not in the working tree HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubycritic.