Giter Club home page Giter Club logo

Comments (4)

faisal avatar faisal commented on June 9, 2024

I think there are three questions here:

  • For how long should the project maintain support for an EOL'd Ruby version: drop support immediately after EOL, or wait for some fixed period post-EOL before dropping support (such as six months after an EOL date)?

  • Once the time comes, is it a hard-and-fast cutoff (immediately bump the minimum Ruby version) or a softer cutoff (possibly bumping the version requirement in a subsequent change, or only when some dependency updates or feature work necessitates it)?

  • If taking the soft EOL path, and RubyCritic will support a post-EOL Ruby until some dependency wants to pull the minimum version forward, which of RubyCritic's dependencies are worth following to a new minimum Ruby version?

For a concrete example of this sort of decision, consider the discussion in #458 in light of where things stood eight months ago and where they stand now.

Considering those questions, I suggest a soft cutoff at the same time as Ruby EOL's a version. If it's to be later, then (based on when RubyCritics dependencies updated after the Ruby 2.7 EOL) it should be no more than six months after the EOL.

After the soft cutoff date date, RubyCritic's minimum version requirement should then move (to the oldest non-EOL'd Ruby version) when a runtime dependency no longer supports the EOL'd Ruby version.

When doing so, it might also be worth cutting a "final" EOL-supporting release that more tightly locks the dependency versions (such as @nunosilva800 suggested in #477 (comment)). For example, RubyCritic 4.9.1 could include #480 plus hold Reek to < 6.2, and RubyCritic 4.10.0 (or 5.0) drops Ruby 2.7 support.

from rubycritic.

faisal avatar faisal commented on June 9, 2024

There's a side but related issue around numbering: would bumping RubyCritic's major release numbering when Ruby bumps help with conveying the support situation? For example:

RubyCritic New Ruby (At some point) Dropping Support For Ruby
5.0 3.3 2.7
6.0 3.4 3.0

from rubycritic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.