Giter Club home page Giter Club logo

Comments (4)

toonvandenbos avatar toonvandenbos commented on July 30, 2024 2

Thank you everybody. @Wirone's PR has been released under version 1.1.0.

from lingua.

toonvandenbos avatar toonvandenbos commented on July 30, 2024

Hi @AndrewHaine,

We certainly plan to make this package compatible with PHP8. However, due to our current workload I cannot say when this will happen. A PR addressing this issue would help.

Have a great day.

from lingua.

Wirone avatar Wirone commented on July 30, 2024

In most cases adding |^8.0 is good enough if codebase should work on both (so PHP8 features are not used for BC). Of course I don't know this library and I don't know if any of BC-breaks apply here, but I did quick PoC and used fork in my PHP8-based project:

{
    "type": "project",
    "license": "proprietary",
    "repositories": [
        {
            "type": "vcs",
            "url": "[email protected]:Wirone/lingua.git",
            "info": "In order to get PHP8 support"
        }
    ],
    "require": {
        "php": ">=8.0",
        "whitecube/lingua": "dev-php8@dev"
    }
}

Tests passed and it seems to be working :) I've used Lingua::create($locale ?? 'en')->toW3C() since I have en_GB locales and I needed en-GB for Paypal API.

Consider adding support for PHP8, I can make a PR if provided changes are acceptable.

from lingua.

AndrewHaine avatar AndrewHaine commented on July 30, 2024

Thank you all! :)

from lingua.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.