"iw" hebrew about lingua HOT 7 CLOSED

We could make that work. I'll get on it in a couple hours.

from lingua.

You can update your dependency to 1.0.2 to get the changes. 🙌

from lingua.

It's the same for indonesian (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes search for "Changed in 1989 from original ISO 639:1988")

from lingua.

Hi, if my understanding is correct, the ISO 639-1 code for Hebrew was "iw" before 1988, and was then changed to "he", is this correct?

If so, then should we really prioritize the old outdated code over the new one?

from lingua.

Yes that's it for the first question,

As for the second, we should just be able to detect that "iw" is hebrew, we could consider many ways like an 'outdated' language code key in languages.php or something else. Because when the language is detected and we ask back for the iso6391 code it should returns indeed "he" and not "iw"

from lingua.

Thank you ! If you need any help I am at your disposal 👍

from lingua.

It should work now. I have added the "iw" deprecated code for Hebrew, but if you can think of other instances where we could add deprecated codes, we would gladly accept PR's!

To do this, in the languages.php file, you can add a deprecated key, like so:

[
    'name' => 'hebrew',
    'native' => 'עברית',
    'iso-639-1' => 'he',
    'iso-639-2t' => 'heb',
    'iso-639-2b' => 'heb',
    'iso-639-3' => 'heb',
    'countries' => ['IL' => 'Israel'],
    'deprecated' => [
        'iso-639-1' => 'iw'
    ],
    'scripts' => []
],

from lingua.