whipper-team / whipper-plugin-eaclogger Goto Github PK

Is this logger meant to generate EAC-compatible or just EAC-style logs? I implemented the EAC log signing algorithm in Python a few months ago. The code is ugly, but it's short and can easily be integrated to create logs that are indistinguishable from EAC's.

I would like to add the eaclogger plugin to the official openSUSE repositories but that's not possible without a licencing statement from upstream.
Please add a LICENSE file to this repository. Thanks!

For details, see whipper-team/whipper#181.

Please update to work with whipper 0.4

The logger stores filenames including username if you rip in your home folder. (defaults)

Limit it to just the new directories.

This is what happens.

Track  1

     Filename /home/bober/album/Blind Melon - Blind Melon (Columbia House club edition)/01. Blind Melon - Soak the Sin.flac

     Pre-gap length  0:00:02.32

     Peak level 100.0 %
     Extraction speed 3.0 X
     Track quality 100.0 %
     Test CRC 89B34677
     Copy CRC 89B34677
     Accurately ripped (confidence 18)  [6C6D8E10]  (AR v1)
     Copy OK

This is what I expect.

Track  1

     Filename .../album/Blind Melon - Blind Melon (Columbia House club edition)/01. Blind Melon - Soak the Sin.flac

     Pre-gap length  0:00:02.32

     Peak level 100.0 %
     Extraction speed 3.0 X
     Track quality 100.0 %
     Test CRC 89B34677
     Copy CRC 89B34677
     Accurately ripped (confidence 18)  [6C6D8E10]  (AR v1)
     Copy OK

Hi, I've seen on the whipper github page you've stated "Unfortunately both logger plugins are currently outdated and won't work with latest whipper versions." Perhaps I'm way off, but I made a quick change to the eac.py code and can produce a logfile with whipper 0.7.0-1 (Arch Linux). Not sure if I should have done a pull request either! Anyway, the change I made is

# AccurateRip track status
        #for v in ('v1', 'v2'):
            if trackResult.AR['v2']['DBCRC']:      
          
                self._inARDatabase += 1
                if trackResult.AR['v2']['CRC'] == trackResult.AR['v2']['DBCRC']:
                    lines.append(
                    "     Accurately ripped (confidence %d)  [%s]  (AR v2)" %
                    (trackResult.AR['v2']['DBConfidence'], trackResult.AR['v2']['CRC'].upper()))
                    self._accuratelyRipped += 1
                else:
                    lines.append(
                    "     Cannot be verified as accurate  "
                    "(confidence %d),  [%s], AccurateRip "
                    "returned [%s]  (AR v2)" %
                    (trackResult.AR['v2']['DBConfidence'],
                     trackResult.AR['v2']['CRC'].upper(), trackResult.AR['v2']['DBCRC'].upper()))
            else:
                lines.append("     Track not present in AccurateRip database")

        # EAC emits 0 warnings even when a CRC mismatch occurs
        if trackResult.testcrc == trackResult.copycrc:
            lines.append("     Copy OK")
        return lines

Am I anywhere near getting something useful?

Ever since the log format was restructured (I suspect this commit was the culprit but I'm not certain), the trackLog is missing and the AccurateRip status always states "none of the tracks are present", even when this is patently not true.

Here's the same CD with the standard logger:
https://ptpb.pw/ud4r

And with the EAC logger:
https://ptpb.pw/glbJ

At least I hope I'm not the only one this happens to.

Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/whipper/extern/task/task.py", line 518, in c
callable_task(*args, **kwargs)
File "/usr/lib/python3/dist-packages/whipper/program/cdrdao.py", line 111, in _read
self._done()
File "/usr/lib/python3/dist-packages/whipper/program/cdrdao.py", line 149, in _done
self.toc.parse()
File "/usr/lib/python3/dist-packages/whipper/image/toc.py", line 191, in parse
with open(self._path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpirqgnyeg.cdrdao.read-toc.whipper.task'
CRITICAL:whipper.command.main:exception FileNotFoundError at /usr/lib/python3/dist-packages/whipper/image/toc.py:191: parse(): [Errno 2] No such file or directory: '/tmp/tmpirqgnyeg.cdrdao.read-toc.whipper.task'
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/whipper/extern/task/task.py", line 518, in c
callable_task(*args, **kwargs)
File "/usr/lib/python3/dist-packages/whipper/program/cdrdao.py", line 111, in _read
self._done()
File "/usr/lib/python3/dist-packages/whipper/program/cdrdao.py", line 149, in _done
self.toc.parse()
File "/usr/lib/python3/dist-packages/whipper/image/toc.py", line 191, in parse
with open(self._path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpirqgnyeg.cdrdao.read-toc.whipper.task'