Giter Club home page Giter Club logo

Comments (10)

wh201906 avatar wh201906 commented on May 26, 2024 1

It might be a little bit hard to implement it on Qt5. I'll try it when I'm free.

from serialtest.

wh201906 avatar wh201906 commented on May 26, 2024

It does have dark theme.

  1. Go to "settings"
    图片
  2. Select "Dark" in Appearance->Theme
    图片
  3. Click "Set" behind the Theme selector
    图片
  4. Restart the app
    图片

from serialtest.

xmha97 avatar xmha97 commented on May 26, 2024

Thanks, now I need another feature:

  • Please follow the system theme.

Like other apps:
Screenshot_2023-05-19-02-24-27-106_de.mm20.launcher2.release.jpg
Please add the "System" item.
Screenshot_2023-05-19-02-26-09-964_priv.wh201906.serialtest.jpg

from serialtest.

xmha97 avatar xmha97 commented on May 26, 2024

Thanks 🙏

from serialtest.

xmha97 avatar xmha97 commented on May 26, 2024

Please change "(None)" to "Follow system"
It works on Ubuntu fine.

Screenshot from 2023-06-11 15-37-12

Screenshot from 2023-06-11 15-38-20

from serialtest.

wh201906 avatar wh201906 commented on May 26, 2024

@xmha97 It's a cross-platform app and the behavior is not the same on different platforms. So I think it's not good to change the (None) to Follow System.

from serialtest.

wh201906 avatar wh201906 commented on May 26, 2024

Plus, I think I might add more themes in the future, for both dark style and light style. However, users cannot choose which dark style to use with a single Follow System option, when the system is in dark mode.
Users can change the theme without restarting the app now (see 4d15a2f and 7b3dccb). So I guess the feature is not so necessary?

from serialtest.

xmha97 avatar xmha97 commented on May 26, 2024

Thanks for the new version.

from serialtest.

xmha97 avatar xmha97 commented on May 26, 2024

Android app does not follow OS theme, please reopen this issue.

from serialtest.

wh201906 avatar wh201906 commented on May 26, 2024

Sorry but I don't want to add this feature for these reasons:

  1. As I mentioned in #29 (comment), "Follow OS theme" is ambiguous when there are more than one dark theme.
  2. I guess you want this feature because its inconvenient for users to change the theme before V0.3.2. That's true, as they have to restart the app to do so. However, it's less necessary now because I have removed the limitation. Following OS theme is good for the user experience, but it might cost a lot of time for me to implement this because it's a Qt app.
  3. As you said in #29 (comment), the default theme does follow the OS theme on Ubuntu.

from serialtest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.