wezm / pkb Goto Github PK

Files in public don't seem to have appropriate cache headers so the font it being re-fetched each time.

Currently (in the Rust version) the Last-Modified header is set to the mtime of the document. A failure mode here is if a new version of the application is deployed that alters the way pages are rendered requests with If-Modified-Since will still be considered fresh. Seems like Last-Modified should be set to max(page_mtime, build_date) where build date is a timestamp set when the binary was compiled.

• Only the first pre tag is fixed up by https://github.com/wezm/pkb/blob/5066df42f8a10e060a868eb2b3f8ff3d9a4c035f/src/templates/decorators.rs#L65m
  • E.g. code blocks after the first one in https://linkedlist.org/alpine-linux-kvm-graphical-guest and https://linkedlist.org/x11 have blank lines
• Missed this debug code

  pkb/src/templates/decorators.rs

  Line 145 in 5cb0bfd

  info!("{}", html);

Rails 5 (which pkb currently uses) does not support Ruby 3 and newer releases of Alpine Linux, which host the site have moved to 3.x. Constantly chasing upgrades for a site that should largely just sit there and do its thing is a waste of my time. At some point I want to rebuild the site in Rust since Rust applications largely continue to build with newer versions of the compiler due to a commitment to stability.

I cloned the repo, copied Rocket.sample.toml to Rocket.toml, created a folder called pages with a file called home.md and ran cargo run.

After compilation I got:

Error: Failed to extract valid configuration.
   >> missing field `pages_path`
thread 'main' panicked at src/web.rs:81:47:
no settings in state

Did I do something incorrectly?

$ rustc -vV
rustc 1.75.0 (82e1608df 2023-12-21)
binary: rustc
commit-hash: 82e1608dfa6e0b5569232559e3d385fea5a93112
commit-date: 2023-12-21
host: x86_64-unknown-linux-gnu
release: 1.75.0
LLVM version: 17.0.6