wevote / endorsementextension Goto Github PK

When constructing the link used with the "Admin App" button, please remove the "google_civic_election_id" URL variable, and include the "show_all_elections" variable (with a value of "1")

https://api.wevoteusa.org/c/?show_all_elections=1&candidate_search=Betty+Yee

Please update this text:

Authenticate this "We Vote Endorsement Tool" Chrome extension,
by logging into the We Vote WebApp (https://wevote.us) in another tab.
Once you have logged into the We Vote Web App, navigate back to this tab and press the SIGN IN button again to authenticate the "We Vote Endorsement Tool" Chrome Extension.

To this:

To sign in:

1. Sign in at WeVote.US (make this a link that opens "https://WeVote.US/ballot" in a new tab)
2. Return to this window and click the "Sign In" button again

Currently the Email and Comment input fields are not active. They should accept values and have a "Save" button.

1. Open up the area for the organization name, so that "People For the American Way’s Next Up Victory Fund" is not so tall.
2. If the signed in voter does not have a photo, show a generic avatar instead of a broken link,
3. Order the right pane to match the order the candidates are found in the left pane.
4. For http://www.conservativehq.com/node/31165 we are showing two entries for "Nick Freitas": one capitalized and one all-caps, dedupe the list with a case insensitive comparison.

Clicking "Sign in" would open a new tab to WeVote.US as explained in this Issue in the WebApp Issues list:
wevote/WebApp#2819

I tested the latest extension 0.0.0.4 on my wife's computer. I don't believe she had been to WeVote.US to generate a voter_device_id. There wasn't any right column content, and I think it might have been due to this NOVOTERID error in the console.

• All that voter oriented stuff is slowing down the expert stuff
• Sometimes: Crazy slow opening of pop-up, and crazy slow response to "Open edit panel for this tab"
• Close of the dialog with iframe to the webapp, fails to update the rightPositionPanes. I think it is related to the passed values of voterGuidePossibilityId, positionWeVoteId, & possibilityPositionId

Less:

• Does not eliminate duplicate names on https://atlinq.com/atlanta-inquirer-endorsements-for-georgia-elections/
• Server side: use the auto scanning code in the server (https://api.wevoteusa.org/vg/possibility_list/ View Details button) to "Scan Voter Guide" for a first pass at getting all of the endorsements on the page into the db. (and on the editor pane in the chrome extension).
• wevote/WeVoteServer/issues/1254 Integrate the new PDF scanner code into Admin Voter Guide Possibility Scanner
• Painfully slow load of WebApp,
• Disable load of stripe and zendesk

Spun off from /issues/50

Note from Dale from Google Doc 2020-02-10:
When voter sees a highlighted candidate name on a page, we would like either of these two scenarios when voter left-clicks highlighted candidate name, dependent on technical feasibility (and not overwhelming the browser CPU/memory footprint across all tabs):

1. mini-popover that offers two options: a) “View candidate details on We Vote” (open in new tab), b) show original link and navigate to it in a new tab
2. Open Popovers that look like this. This could be set to only work in the “Edit Panel” mode if it is easier and less memory intensive. When it is time to tackle this, feel free to tackle whichever tab is easiest first. See Google Doc 2020-02-10

1) "For all candidate name highlights, open a popover when you click on the highlighted name."
Response: It might be possible to add a span around our selection with a onClick() handler that wold select the entire highlighted name when you click in the span.

If we simplified this context menu:

and removed the second level menu (with the two choices), you'd only have to right click on a name, select the WeVote choice, and the dialogue would appear. That would be an improvement.

What we would lose by going to a single choice is the ability to have to have the "Reveal in candidate list" option available in the context menu, without going into the overlay first. We would have to move that to a button within the dialog.

Spun off from //issues/50

2) "If the website already had the candidate name linked to another page, override that link and always open our popover. Place that link in the bottom of our popover per the design below"

   <a href="https://www.philting.com/" target="_blank">
      <em class="Highlight" style="padding: 1px; box-shadow: rgb(229, 229, 229) 1px 1px; border-radius: 3px; -webkit-print-color-adjust: exact; background-color: rgb(39, 175, 114); color: rgb(255, 255, 255); font-style: inherit;">
           Phil Ting
      </em>
   </a>

Response: Here is the actual markup name and the hidden URL that could be passed to the pop-up. of the highlighted name from the sierra club site. At processing time if the name was wrapped in a 'a' element, I could disable it and maybe hide the link in the mark up with the name, and build a onClick for what I put into the DOM that would select the name and the hidden URL that could be passed to the pop-up.

Currently the "Jump to My Ballot" button isn't going over to https://WeVote.US/ballot yet:

Should open in a new tab.

If you turn on the extension when viewing a tab, then turn it off, change to another tab, and try to turn it on, nothing happens. Broken.

I noticed that this website had three problems when our Endorsement Tool is turned on:
https://runforsomething.net/candidates/

1. The right panel is very wide, and the left panel is very narrow. The right panel can be a fixed with.

2. Reveal button doesn't work

3. Candidate details are expanded all the time

Add a menu that pops down when you click on the We Vote Chrome Extension icon:

• "Jump To My Ballot" button should open a new tab and go to: https://WeVote.US/ballot
• "All Endorsements: Sierra Club" should open a new tab and go to: https://WeVote.US/sierraclub/positions
• The "View Candidates" on/off switch would cause candidates we recognize to be highlighted on any page (for all Chrome tabs) that isn't in the "ignore these websites" list
• The "Open Edit Panel" would be the same as the current "Turn on the Extension" behavior that happens when you click the We Vote Chrome Extension icon. We would like to only turn on the Edit panel in the tab that is currently open, and not turn on the Edit panel in any other tabs.

Note: the existing We Vote Chrome Extension icon itself does not need to be changed -- it is fine as is:

Note the We Vote logo for the top of this popdown menu can be found here:
https://wevote.us/img/we-vote-logo-horizontal-color-dark-141x46.svg

• Suggest a new candidate/measure by right clicking
• "Create We Vote Endorsement" (right-click) to create a new endorsement entry.
• Detect new page, and start off with scanning off
• Write data back to the server, based on saves from the right menu.
• The 15 states of candidate highlighting.
• Handle measures and propositions.
• Switching URLs while the menus are showing.
• Rework popup.js to turn on or off scanning for the current page.
• Click on the tool bar icon, to activate for a page. (Strip out all the default group stuff, not needed.)
• Wire voterGuidePossibilityRetrieve number to voterGuidePossibilityPositionsRetrieve
• Sign in logic, for bad device_ids, and a dialog if no device_id (or a bad one) to explain sign in.

When I visit this URL: https://www.cleanvirginia.org/our-endorsements/
...and turn the We Vote Endorsement Tool on, I see this in the upper right corner:

When I right click and go to "Open Image in New Tab", I am taken to this URL:
https://www.cleanvirginia.org/our-endorsements/null

• Add ability to logout
• Does Send us a comment about this page: work?
• Display a default organization icon if we don't receive one. (https://www.sierraclub.org/california/2020-endorsements)
• [ ]

Please add these icon squares with thumbs up, thumbs down, and comment to the top right of each candidate's "rolled up" block in the right column:

Thumb Up: https://material.io/resources/icons/?icon=thumb_up&style=baseline
Thumb Down: https://material.io/resources/icons/?icon=thumb_down&style=baseline
Comment Icon: https://material.io/resources/icons/?icon=comment&style=baseline

1. Endorsed with comment (not stored/imported):

2. Endorsed, no comment (not stored/imported):

3. Endorsed with comment (stored/imported):

4. Comment only (not stored/imported)

5. Comment only (Was stored/imported)

Candidate highlighted (Yellow/Gray), not signed in: Open Modal

See #57

Candidate highlighted (Green/Red), signed in: Open Modal

See #58

Candidate highlighted (Green/Red), signed in: Sierra Club Endorsement

See #59

For all candidate name highlights, open a popover when you click on the highlighted name.

Spun off to /issues/54

If the website already had the candidate name linked to another page, override that link and always open our popover. Place that link in the bottom of our popover per the design below.

Spun off to /issues/55

This design has two tabs at the top. For now we are only going to implement the "Sierra Club Endorsement" tab.

Note: The current "Create a We Vote endorsement" popover (that appears when you select a name and right click) can open this new popover design.

I use dark mode for my computer. This is how our Chrome extension icon looks in dark mode next to the other logos -- it should have the white background:

Please change the text on the "Web App" button to say "WeVote.US".

Edit down this text to fit on one line:
"If a more detailed endorsement exists, enter its URL here:"
Suggested:
"If dedicated candidate page exists, enter URL here:"

Reduce font size of URL in the "If a more detailed endorsement exists, enter its URL here:" input box so we can see more of it in the space available.

• If a PDF exists for the year, load it instead of making a new one
• Extension crashes out with no warning after editing and updating a candidate position in the right pane.
• The WebApp page and my page are referring to different data.

• Delete from editor does not work anymore, need it to test yellows in the pane
• Close dialog initiated from WebApp in the frame, does not work.
• Fix "too big button" in html from PDFs
• Make PDFs expire in a year, instead of a week

I'm enjoying working with the new endorsement chrome extension!

In order to make vertical scrolling more intuitive, please eliminate the overall window vertical and horizontal scrollbars. This will limit the vertical scrolling to either the left-most main panel, or the right "candidate-browser" panel. Example page: https://workingfamilies.org/2019/08/2019-endorsements/

Also, the right candidate-browser panel has a left-right scroll that it would be good to remove. The width of the right candidate-browser panel can be fixed. The main large panel can always be "forced down" in width by the right candidate-browser panel.

If required by the page in the main large panel, a horizontal left-right scroll is fine, if it has a fixed width.

Please test at a variety of desktop browser window sizes.

We would very much like to have a way to see which found items in the right column are actually not visible in the left main panel. (As quality control against false-positives.)

It could be as simple as a red dot to the right of the candidate's name if the name can't be found in the main panel.

For example

https://www.iuoe399.org/media/filer_public/45/77/457700c9-dd70-4cfc-be49-a81cb3fba0a6/2020_lu399_primary_endorsement.pdf

This issue requires the installation of pdfminer.six on the python host
https://github.com/pdfminer/pdfminer.six
stars/forks 1.7k/1.4k
Updated 6 days ago
Now handles Py 3
65 issues

When scanning this endorsement page:
https://runforsomething.net/candidates/

...I used the "Reveal" button for "Tamara Sawyer". It did not find her. I did find her on the page with her alternate name highlighted "Tami Sawyer". https://api.wevoteusa.org/c/57445/edit/?google_civic_election_id=1000085&state_code=&page=0

The request is to:

1. use the alternate name for highlighting support/oppose colors
2. have the "Reveal" button use the alternate name if the full name isn't found
   

Please convert the We Vote icon in the top bar of Chrome to show a menu upon clicking (as opposed to using the click as an on/off toggle)

Please add the following items as menu items:

• Activate Endorsement Tool (vs. Deactivate Endorsement Tool)
• Sign In / Sign Out (if it makes sense technically to add here)
• About We Vote (takes you to https://wevote.us/more/about)
• Manage Extensions (takes you to standard Chrome page for our extension)

Add icons to all of these states. Change yellow "candidate found"/"name recognized but no endorsement" color to dark gray.

This would also be the default tab to show if in the Edit Panel mode:

Turn off highlighting on these domains:
*.wevote.us
api.wevoteusa.org
localhost

In the future, it would be good to provide the domains to exclude via API, so we can turn highlighting off for client custom domains. (like ballot.motivote.us)