Giter Club home page Giter Club logo

wetransfer_style's Introduction

wetransfer_style

At WeTransfer we code in style. This is our style.

Using our style

If you want to code in our style, here's what you have to do:

Ruby

Add wetransfer_style to your Gemfile:

gem 'wetransfer_style'

or to your *.gemspec:

spec.add_development_dependency 'wetransfer_style'

Add a .rubocop.yml in the root of you repository, having:

inherit_gem:
  wetransfer_style: ruby/default.yml

Contributing

Thanks for taking the time to bring our style to the next level. If you aren't a contributor, please follow step 1 through 5. If you are a contributor to the repository, please follow all steps.

  1. (Fork and) Clone this repository
  2. Make your changes
  3. Make a concise entry in ./CHANGELOG.md
  4. Bump the version number
  5. Create a Pull Request
  6. Merge the PR on enough approvals
  7. Pull latest changes on your system
  8. Build the gem with gem build wetransfer_style.gemspec
  9. Push your changes with gem push wetransfer_style-x.y.z.gem

wetransfer_style's People

Contributors

arnofleming avatar bermannoah avatar davidenko87 avatar fabioperrella avatar grdw avatar linkyndy avatar lorenzograndi4 avatar tors avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

arnofleming

wetransfer_style's Issues

Discussion about adding a rule for line-lengths

This issue is meant as a discussion but fairly often I see code in WeTransfer projects (specifically spaceship, because I mainly work in spaceship) with fairly long line lengths (Examples: [1], [2] and there are a lot of examples to be honest) and personally I am not a really big fan.

It makes code fairly hard to read and line-wrapping in and editor makes it even harder to read.

There are a couple of solutions:

  1. Add a rubocop rule enforcing a line length
  2. People convince me that I should not complain and maybe get a wider screen
  3. Another solution?

I've added some people to take part in this discussion. If anybody knows other people within WeTransfer that feel strongly about the subject, please tag them in this issue.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.