werkn / critter-quest Goto Github PK

When the player drops into the third level and moves to the platform they automatically pick up gems stuck in the tiles. This causes a gem collected noise to occur and is confusing.

This has to do with #61 but for the time being lets just move the gems in the tilemap down 1 tile to fix this for now.

Problematic gem placement:

Player and enemy colliders do not fit well the actual bounds of their sprites. Modifying these to be tighter to the actual sprite being rendered should make for more accurate collision detection.

When killing an enemy inside a collider widget if we get them during the idle state it seems they do not play the proper death animation and in very rare circumstances are killed but not despawned from scene.

Attempted to add controller support to the current version of the game... we are currently using Phaser3.16.2 and support for controllers was not added until 3.17+. Attempt to roll library up to 3.17 and its breaks the current version of the game.

For now this feature is not going to be added.

In-game music currently does not loop as expected.

Any Phaser.Physics.Arcade.Body, as in Enemy colliders, platforms, etc... causes the callback for collide_dmg to be called.

This can be fixed by changing the callback for collide_dmg to verify sprite.name == 'player' or modify it to kill the appropriate GameObject.

If the player holds the jump button it fires continuously as long as the player is on the ground.

Description

When Player crouches to move through a small gap, if they uncrouch they can move through the collider above them.

Player Crouches and Moves Through Gap

Player Uncrouches and is now inside Tile Collider

FrogEnemy and FrogSpringboard collider extends below sprite causing the game objects to appear like they are hovering 2 - 5 pixels off the ground.

Example:

Page title is incorrect and for an older version of the app. Change from Phaser 3 Template to Critter Quest.

Audio for collection events is 2x louder then background audio and very loud. Perhaps reduce playback volume on initial load.

The way we are checking state on our Player and Enemy class is by using the sprite instance of our classes (as this is passed nicely between almost any and all physics methods). So using our older method of class_instance.dead is redundant. Lets remove all the existing usages of class_instance.dead.

Firefox/Edge don't support es6 static fields, so FrogBossEnemy breaks these browsers. Chrome supports es6 static fields which we've been using for most of our development.

Possible Sol'n

Yank out the static reference in FrogBossEnemy and replace with a reference to scene.sys.game.remaningFrogEnemies.

Menu system breaks and scenes overlay/are not properly destroyed if the player selects the in-game menu from any level, returns to level select screen and selects level one.

Reproduction Steps

1. Complete level one.
2. Once spawned into level two, hit and select Exit to Level Select.
3. Choose level one.

You should be spawned back into level two with the level select screen overlaying parts of the current scene.

When creating sprites without specifying a valid texture, the associated Phaser.Physics.Arcade. Collider is the wrong size.

For example:

Possible solution would be to figure out how to properly load from a TextureAtlas.

Gem collisions take place even after player has died (Player.sprite.body.checkCollision is off). This likely has to do with our custom collision check in PlatformerScene.update() for Gems not checking if collision on the Player sprite body is off.

When the player is killed and the death animation plays they move behind collision layer tiles. This is cosmetic but looks erroneous.

On Edge, Chrome and Firefox we attempt to access localStorage without verifying we have access to it. This causes the current version of Edge to crash. Likely to cause other browsers to crash in the future.

When the Player ducks their is no reduction in the size of the ArcadePhysics.Body that is attached to the Player sprite. Moving forward, to access hidden areas we will need to modify this body to allow the Player to pass into spaces one tile in width/height.

When running the live demo autoplay is disabled by default in Chrome and Firefox.

Firefox error reported when attempting to autoplay in-game music in Title Screen.

Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted.

When returning back to level select from an active plaftormer-scene the scene is not destroyed. Instead the next level selected is spawned behind the previous level.

When FrogEnemy is initially spawned into any level it does not have the placeholder sprite that should be used prior to playing it's idle animation in FrogEnemy.update(). This may be an issue with how our Atlas is loaded in PlatformerScene. Animations play fine but standalone frames do not.

Specifically this line from frog-enemy.js in the FrogEnemy constructor seems suspect:

Gems spawn one tile above where they are actually placed. This likely has to do with our object loading in PlatformerScene.

Trying to collect multiple gems does not play concurrent audio (ie: multiple gem collected sounds).