wemake-services / kira-review Goto Github PK
View Code? Open in Web Editor NEW:chipmunk: Kira's micro-bot to review merge requests before real humans
Home Page: https://hub.docker.com/r/wemakeservices/kira-review
License: MIT License
kira-review's People
Contributors
![dependabot-preview[bot] avatar](https://avatars.githubusercontent.com/in/2141?v=4 "dependabot-preview[bot]")
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
Stargazers
Watchers
kira-review's Issues
Add python platform
Suspicious source/tests changed results
I am pretty sure that I have seen multiple warnings like The source code was changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes. that were raised by mistake.
Needs further investigation.
Add vue platform
Think about `when: merge_requests` for this job
Exclude lock files from diff size
Sometimes lock files just change. There's nothing we can do about it.
Add django platform
Todo plugin fails
Might be better to use try for this plugin:
$ danger --fail-on-errors=true --fail-if-no-pr=true --dangerfile=/danger/Dangerfile
/danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:51:in `line_number': (Danger::DSLError)
[!] Invalid `Dangerfile` file:
[!] Invalid `Dangerfile` file: Danger::TextNotFoundInPatchError. Updating the Danger gem might fix the issue. Your Danger version: 6.0.1, latest Danger version: 6.0.6
# from /danger/danger-stages/optional/Dangerfile:39
# -------------------------------------------
# todoist.message = "Consider creating task chains out of new todos in the code"
> todoist.warn_for_todos
# todoist.print_todos_table
# -------------------------------------------
. Updating the Danger gem might fix the issue. Your Danger version: 6.0.1, latest Danger version: 6.0.6
# from /danger/Dangerfile:36
# -------------------------------------------
# # Can only warn:
> danger.import_dangerfile(path: "/danger/danger-stages/optional/")
#
# -------------------------------------------
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:55:in `build_todo'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:41:in `block in all_todos'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:41:in `map'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:41:in `all_todos'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/helpers/array_subclass.rb:49:in `map'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/helpers/array_subclass.rb:49:in `respond_to_method'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/helpers/array_subclass.rb:19:in `method_missing'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/diff_todo_finder.rb:12:in `call'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/plugin.rb:113:in `block in find_todos'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/plugin.rb:113:in `map'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/plugin.rb:113:in `find_todos'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/plugin.rb:103:in `call_method_for_todos'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-todoist-2.0.0/lib/todoist/plugin.rb:55:in `warn_for_todos'
from /danger/danger-stages/optional/Dangerfile:39:in `eval_file'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:297:in `eval'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:297:in `eval_file'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:200:in `block in parse'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:197:in `instance_eval'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:197:in `parse'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb:127:in `import_dangerfile_from_path'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb:82:in `import_dangerfile'
from /danger/Dangerfile:36:in `eval_file'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:297:in `eval'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:297:in `eval_file'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:200:in `block in parse'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:197:in `instance_eval'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:197:in `parse'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/dangerfile.rb:273:in `run'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/danger_core/executor.rb:29:in `run'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/lib/danger/commands/runner.rb:72:in `run'
from /danger/vendor/bundle/ruby/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
from /danger/vendor/bundle/ruby/2.3.0/gems/danger-6.0.1/bin/danger:5:in `<top (required)>'
from /danger/vendor/bundle/ruby/2.3.0/bin/danger:23:in `load'
from /danger/vendor/bundle/ruby/2.3.0/bin/danger:23:in `<main>'
[!] The exception involves the following plugins:
- danger-todoist
Add general message about the review process
Add javascript platform
Check `validation:` labels and ask to remove them
Add link to all suggestions
It is clearly not possible for a newcomer to address all the issues without help and guidance.
What to do? Where to look? We should provide links to the solution in each review comment.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.