wei2912 / ped Goto Github PK

The add command allows users to input phone numbers which are overly short, e.g. 3-digits long, and would not be valid Singaporean phone numbers. This may cause data integrity issues.

Steps to Reproduce:

1. Run add -c Tom -pn 123

Expected:

1. Command returns an error message explaining that the phone number is too short and should be a 8-digit number (assuming Singaporean phone number).

Actual:

1. Command accepts the invalid input and creates the client as requested.

The add command accepts emails with improper domain names, e.g. localhost, which cannot be used in practice to email people. This can cause data integrity issues.

Steps to Reproduce:

1. Run add -c Tom -pn 12345678 -e tom@localhost

Expected:

1. Program outputs an error message explaining that localhost is not a valid domain name.

Actual:

1. Program accepts invalid email input.

The add command is documented to accept unit prices that "contain numbers" and optionally "'.' for cents". However, this does not make it clear that inputs such as -$ 0.2 and `-$ 0.002$ are invalid.

The add command outputs "Unknown command" when a negative number is passed to -c, which is misleading to users as it suggests that the add command does not exist.

Steps to Reproduce:

1. Run add -n Alex -pn 1 (note that -n is in place of -c)

Expected:

1. Program prints "Invalid command format" with the relevant help message for the add command.

Actual:

1. Program prints "Unknown command".

The number associated with each product, as shown in the product list, does not match the actual Product ID. This is because the numbers associated are 1-indexed while the actual Product IDs are 0-indexed. This mismatch between the Product ID and number can lead to confusion and increase the chance of erroneous inputs from users.

Steps to Reproduce:

1. Select the "Products" tab.
2. Add a new product, e.g. add -p Clip -$ 1 -q 20.

Expected:

1. A new product should be created, with its number in the product list matching its ID.

Actual:

1. The number associated with the product in the product list is 1 more than its ID.

Screenshots:

(Note that the number shown in the list is 6, while the product ID is 5.)

Remark: This issue also applies to Client IDs.

Commands requiring at least one parameter, such as the add and list commands, produce an output message "Unknown command" when called without parameters. This is confusing to users as it may mislead them to think that these commands do not exist.

This issue also applies when the parameter syntax is invalid, e.g. add asd instead of add -c ....

Steps to reproduce:

1. Call one of add, list, add asd.

Expected:

1. Program indicates invalid command format and prints out the relevant help syntax for the message.

Actual:

1. Program prints "Unknown command".

Screenshots: