wedgecoop / is4c Goto Github PK

The get-lane installation could be fixed up a bit to better handle mysql permissions. Right now, if you agree to install the sample data, but then provide incorrect credentials to mysql, the script just continues. It should probably reprompt for a user name and password that works, or use the root credentials provided earlier in the script.

In ssd.c the scannerInput array is defined as follows:

 char scannerInput[12];

But later in the code when the scanner input is read:

  for (i = 0; i < 17; i++) {
       scannerInput[i] = serialBuffer[i+4];
   }

Is this buffer overrun intentional? I have seen this code in multiple is4c forks on github and it has not been corrected. I changed the size of scannerInput to 17 in my own code to correct the issue, and the daemon still appears to run fine. Is there something I am missing?

See http://is4c.coop/bb/viewtopic.php?t=72 for more information.

Running the command python pos/installation/install_server.py results in the following error:

Traceback (most recent call last):
  File "pos/installation/install_server.py", line 40, in <module>
    install_server_db(*user_input)
  File "pos/installation/install_server.py", line 28, in install_server_db
    exec_scripts(connection, 'is4c_op/data/*.insert')
  File "/Volumes/Webserver/Checkout/projects/is4c/pos/installation/installers.py", line 46, in exec_scripts
    exec_script(connection, script_path, absolute=True)
  File "/Volumes/Webserver/Checkout/projects/is4c/pos/installation/installers.py", line 30, in exec_script
    cursor.execute(sql)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/site-packages/MySQLdb/cursors.py", line 166, in execute
    self.errorhandler(self, exc, value)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/site-packages/MySQLdb/connections.py", line 35, in defaulterrorhandler
    raise errorclass, errorvalue
_mysql_exceptions.OperationalError: (1136, "Column count doesn't match value count at row 1")

This is on OSX using Python 2.6.

When the is4c lane scale reader is on it somehow stops the php execute function from synchronising the lane database with fannie. This causes php to hang. The server must be restarted to get things going again.

This happens with firefox and chrome on winxp mysql5 and two different machines one running php5 and the other php4
This effect does not happen with IE because the ajax code in is4c doesnt work with IE.
the ajax scale reader is in chscale.php

I cant imagine how this happens but it is quite weird.
If you put an invalid file name into the argument for the listen function in the ajax code, it all runs ok except of course there is no scale readout!!!

I have also removed the ?rand=randno.99999 from the request to the scale file and there is no difference in operation. The scale writes to this file so I cannot see what use this query is.

In the file /pos/installation/ubuntu/ssd_server.sh

Lines 12 and 16 should read 'if [ -f ' instead of 'if [ '

Not a big deal since all it does it output an error when the files don't exist.

This used to work, because the script /pos/installation/install_server.py was written specifically with this purpose in mind. However now when this script runs, it fails with the error:

Traceback (most recent call last):
  File "pos/installation/install_server.py", line 40, in <module>
install_server_db(*user_input)
  File "pos/installation/install_server.py", line 28, in install_server_db
exec_scripts(connection, 'is4c_op/data/*.insert')
  File "/home/lance/src/is4c-wedgecoop/pos/installation/installers.py", line 46, in exec_scripts
exec_script(connection, script_path, absolute=True)
  File "/home/lance/src/is4c-wedgecoop/pos/installation/installers.py", line 30, in exec_script
cursor.execute(sql)
  File "/usr/lib/pymodules/python2.6/MySQLdb/cursors.py", line 166, in execute
self.errorhandler(self, exc, value)
  File "/usr/lib/pymodules/python2.6/MySQLdb/connections.py", line 35, in defaulterrorhandler
raise errorclass, errorvalue
_mysql_exceptions.OperationalError: (1136, "Column count doesn't match value count at row 1")

I've verified that the particular SQL script causing this is /pos/installation/mysql/is4c_op/data/products.insert. Apparently the number of columns in the products table (as defined by /pos/installation/mysql/is4c_op/tables/products.table) is different than the number assumed within products.insert.

The default server configuration allows the MySQL default bind-address of 127.0.0.1 to persist. With the bind-address set to 127.0.0.1 no external connections are allowed. Probably not what we want?