wedevelopnl / silverstripe-elemental-grid Goto Github PK

It is possible to set a title on a grid row and configure whether it is displayed or not, however the default template will never render the title. The default row template should render the row title if set.

When you use the new "Add to bottom" button to add an element to the bottom on an empty page you'll receive a graphql error

The element gets added because after a page refresh it is added to the grid, so it seem to break on the callback.

This weekend I've encountered some issue when I was trying to add a new element.

I've created a new Grid page, and tried to add a new element.
Then just nothing happens.

After some little investigation I've found a error in the console;
GraphQL error: Invalid CSRF token

Seems like we need to catch this error and show something on the front-end like;
"Session expired! Please refresh the page".

Right now I'm not 100% sure if this issue only occurs in our Elemental Grid, or also on the DNADesign/silverstripe-elemental package without our Elemental Grid.
After some investigation, I found out that the console error is thrown inside the following vendor file;
_resources/vendor/silverstripe/admin/client/dist/js/vendor.js

Reproduction steps

For security reasons, CSRF token will get invalidate when you open dev tools (F12) and view the admin in responsive.
So this makes it relative easy to reproduce the issue;

• Go t admin => select a grid page
• F12 (dev tools) => Toggle device toolbar (responsive view)
• Add a new row/grid block and see that it won't get added. Now, the error shows up in the console

There are some situations where you design a grid-block, that needs to be at least X cols width.

Right now, it is possible to create a grid-blocks with 1 col, but sometimes the grid block is not made to be smaller then 3 cols for example.

I think it would be a nice enchantment to have a OPTIONAL value on a GridBlock with min-col-size that represends a intenger between 1 and 12.

I've opened this issue to discuss this enhancement. If think that this is a nice feature to add 😀

Hi,

Are you planning to update to elemental 4 any time soon?