As discussed in #7, I like to have all of my changes merged piece by piece:
Removed bundle GeSHi, use setGeshiScriptPath() to point to a managed installation.
Tedious to maintain manually, externalize.
Fixed GeSHi 1.0.9.0 compat
Introduces scoping through public/protected
Removed bundled PEAR installation with Archive_Tar and Text_Diff, use PEAR directly
include_path
modification has not been removed in master
Removed manual parsing of authz file and use svnauthz(1)
The manual parsing in PHP is broken. Therefore it has been replaced with svnauthz(1)
. This has been available for years. Time to switch.
Moved server location to /repos/websvn by default
Internal reasons especially because in cannot be changed in config.php
and require file modification. FreeBSD ports nags with checksums errors for file which haven't been marked as config files.
Moved svnConfigDir to /tmp/websvn by default
This change can be dropped, but not recommended. Not fond of having config files in pure /tmp
.
Renamed useAuthenticationFile to useAccessFile because it does authz only
The authz
is for access/authorization only. Rename for clarification. Though, incomplete class Authentication
has to be renamed.
Improved output of datetimeFormatDuration
Fixed directory listing not obeying showAgeInsteadOfDate
Replaced hyphen-minus with a stylistically proper en dash
Must be propagated througout all templates
Removed any WebSVN-side authentication handling
This should really be done by the server. WebSVN never did any authentication, it simply prompted with Basic
.
Renamed wsvn.php to browse.php for a nicer URL
Friendly URLs to avoid duplicates like /websvn/wsvn
.
Removed old-fashied templates BlueGray and Element, they aren't maintained anymore
Can be reintroduced.
Fixed CVE-2016-2511
Fixed CVE-2013-6892
Must be merged IMHO.
Introduced config->setLocale()
so UTF-8 handling in svn
handling
Requires some polish as mentioned by @tschoening with putenv()
(setup.php) as long as it does not cause any side effects.
Removed checks for old PHP and Subversion versions
Removed use of quoteCommand()
I cannot remember the reason, but there was one. Need to investigate.
Please tell which changes don't need any further discussion. I'd create PRs for them first.