Comments (10)
ie8.js
is inevitably changing global prototype in order to make the environment more standard. Loading it as a module is, accordingly, a non-sense. You should also use conditional comments because this file should never run in non-IE8 browsers.
from ie8.
more on including it: https://github.com/WebReflection/ie8#how-to-include-the-project
from ie8.
yeah... im just putting it together with other ie8 fixes into one file using browserify. and "including" it as described in your example.
i just don't get why it's "non-sense"?
from ie8.
IIUC browserify is for modules. If you expect a module here that's not what IE8 is. If you just need to concatenate the file just do so. Use browserify for everything else then cat ie8.js >> output.js
after ... am I missing something? I don't understand why you need browserify here.
from ie8.
yeah, thank you, that's what im doing right now. Just thought browserify-ing just like the other of my ie8 fixes would be cleaner. also my first attempt was to use it directly from npm.
$ npm install --save ie8
and used it like a normal npm-module:
import 'ie8';
import 'my-ie8-fixes';
this worked at first (it installed & compiled without errors) but then crashed in the browser. So we should
- fix this
- or prevent people from installing and using it like a normal module
from ie8.
ie8 is not a module but since I've done the mistake to push it to npm makes sense to fix it. Will try to do so when I have a minute. Will keep this open until then. Thanks
from ie8.
can you please verify if the current build version causes problems?
from ie8.
seams to work in the IE Edge IE8 emulator. I tried it also in IE8, but it crashed with "Stack overflow at line: 0" (i think it's the fault of my app).
from ie8.
can you please confirm this module is OK ? Thanks
from ie8.
Worked for me...
from ie8.
Related Issues (20)
- IE9 doesn't like the Comment and Text nodeValue shims
- 'defineProperty' is null or not an object HOT 4
- CDN-Link retursn 404 HOT 2
- addEventListener polyfill is firing the actual event on the actual element the first time that event is listened to HOT 8
- what's the problem? HOT 3
- Do you know how to use this polyfill with babel browser polyfill? HOT 2
- getElementsByClassName HOT 10
- HTMLSelectElement defineProperties throw error in IE8 HOT 3
- Cannot attach mousemove to document HOT 9
- Publish ie8.max.js HOT 4
- Conflicts with React 0.14 HOT 12
- some new ie8 Compatibility HOT 3
- IE8 don't support pageX/Y on Event properties
- IE8 supports different button value on Event HOT 2
- Add changelog? HOT 1
- real ie8 StackOverflow exception HOT 1
- Some fixes of event and window attributes HOT 1
- document.createEvent('HTMLEvents') fails HOT 1
- Add Event#defaultPrevented support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ie8.