Giter Club home page Giter Club logo

Comments (10)

WebReflection avatar WebReflection commented on June 9, 2024

ie8.js is inevitably changing global prototype in order to make the environment more standard. Loading it as a module is, accordingly, a non-sense. You should also use conditional comments because this file should never run in non-IE8 browsers.

from ie8.

WebReflection avatar WebReflection commented on June 9, 2024

more on including it: https://github.com/WebReflection/ie8#how-to-include-the-project

from ie8.

chpio avatar chpio commented on June 9, 2024

yeah... im just putting it together with other ie8 fixes into one file using browserify. and "including" it as described in your example.

i just don't get why it's "non-sense"?

from ie8.

WebReflection avatar WebReflection commented on June 9, 2024

IIUC browserify is for modules. If you expect a module here that's not what IE8 is. If you just need to concatenate the file just do so. Use browserify for everything else then cat ie8.js >> output.js after ... am I missing something? I don't understand why you need browserify here.

from ie8.

chpio avatar chpio commented on June 9, 2024

yeah, thank you, that's what im doing right now. Just thought browserify-ing just like the other of my ie8 fixes would be cleaner. also my first attempt was to use it directly from npm.

$ npm install --save ie8

and used it like a normal npm-module:

import 'ie8';
import 'my-ie8-fixes';

this worked at first (it installed & compiled without errors) but then crashed in the browser. So we should

  1. fix this
  2. or prevent people from installing and using it like a normal module

from ie8.

WebReflection avatar WebReflection commented on June 9, 2024

ie8 is not a module but since I've done the mistake to push it to npm makes sense to fix it. Will try to do so when I have a minute. Will keep this open until then. Thanks

from ie8.

WebReflection avatar WebReflection commented on June 9, 2024

can you please verify if the current build version causes problems?

from ie8.

chpio avatar chpio commented on June 9, 2024

seams to work in the IE Edge IE8 emulator. I tried it also in IE8, but it crashed with "Stack overflow at line: 0" (i think it's the fault of my app).

from ie8.

WebReflection avatar WebReflection commented on June 9, 2024

can you please confirm this module is OK ? Thanks

from ie8.

neersighted avatar neersighted commented on June 9, 2024

Worked for me...

from ie8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.