webmozarts / glob Goto Github PK

I have a backuptool that uses a directory structure to store files, e.g.:

/my/path/to/backupfiles/year/month/day/filename.ext

I'd like to unittest my code, so I'm looking into e.g. vfsStream to emulate the expected (and unexpected) structure.

I generate a glob pattern somewhere that is used to find files relating to certain servers, backup types (sql/files/etc) etc.
php's glob() works fine in production but doesn't work well with vfsStream; webmozart\glob looks promising but doesn't work well with streamwrappers such as vfsStream.

I found Path::isAbsolute() to be the culprit; if I simply return true, the code works fine otherwise.

is it possible to use Regex in Resource Pattern matching?

Like:

$files = Glob::glob('/**/*\.[css|js|jpeg]');

The method Glob::combine($glob1, $glob2) should be added that combines two globs/paths into another, stricter glob/path. The method should behave like this:

• If both globs are static (paths), return the path if they are equal and null otherwise.
• If one glob is dynamic (wildcards) and the other static (path), return the path if it matches the glob and null otherwise.
• If both globs are dynamic, return the combined glob if they match each other and null otherwise.

Example for a combined glob:

Glob::combine('/foo/bar/**/*.yml', '/**/messages.yml') => '/foo/bar/**/messages.yml'

This is needed for implementing GlobBinding::findResources() in puli/issues#114.

I open this not for an issue, but to discuss the possibility of adding Glob to Symfony FileSystem or Symfony Finder. Will this be possible?

Just porting the issue from maglnet/ComposerRequireChecker#315 and quoting @Ocramius:

FWIW, if there's a non-symfony solution to that, it could be a better approach: mostly worried about dwindling package quality and continuously increasing dependency ranges in symfony/*.

I dont know another non-symfony package that is doing the stuff needed. Only used path-util / glob or filesystem / finder, so suggestions welcome i guess 👯

It looks like that GLOB_BRACE is not supported in Alpine Linux (see https://bugs.php.net/bug.php?id=72095).

This leads to the following warning

Warning: glob() expects parameter 2 to be integer, string given in /app/vendor/webmozart/glob/src/Iterator/GlobIterator.php on line 55

In the link above there is also a proposed workaround to avoid such a problem

I mean, it impacts a lot while the fix is fast.

For example, see https://github.com/laminas/laminas-mail/blob/2.13.x/CHANGELOG.md#changelog

See https://github.com/phly/keep-a-changelog

See https://github.com/webmozarts/glob/runs/1703814348?check_suite_focus=true

Glob::match(
  "file:///C:/Users/felix/git/OpenSource/php-language-server/fixtures/format.php",
  "C:/Users/felix/git/OpenSource/php-language-server/fixtures/**/*.php"
);

Expected: true (the glob should only be applied on the "path" component of the URI, not the scheme)
Actual: false (since no scheme is defined in the glob pattern)

I thought this library has a fallback wrapper like laminas/laminas-stdlib glob.

Hi @webmozart - thank you for providing the glob library.

Are you still maintaining the project? We would like have new version available on packist.org which runs with current PHP versions.

The current implementation could be extended to support the following expressions.
For reference see http://man7.org/linux/man-pages/man7/glob.7.html

• "?" Wildcard: matches any single character, e.g. "fo?" matches "foo", but not "fo" or "fools"
• Character classes: denoted by brackets "[...]", e.g. "[ABCDEFabcdef0123456789]"
• Ranges: denoted by brackets, e.g. "[A-Fa-f0-9]" (equivalent to the above character class)
• Negation for character classes and ranges: denoted by "!", e.g. "[!aeiouAEIOU]" matches any character, except vowels

https://github.com/webmozarts/glob/runs/1739931409?check_suite_focus=true#step:6:12

I think would be great to remove symfony/filesystem dependence because it used only in tests and conflicts with symfony 3.4/4.4. Many developers who used symfony 3.4/4.4 can't require this great lib. This is no have any reasons to use symfony/filesystem in dev requirements. It should be replaced by native php or add a range symfony/filesystem: ^4.4|^5.0. Thanks