wdelfuego / nova-datetime Goto Github PK

I just updated my nova installation to the latest version as described in the title and the datetime fields unfortunately no longer display anything.

As mentioned here they messed up the displayUsing function.

You probably don't have to do anything because it's their problem but I'll keep you posted if it's fixed or not in the next version.

Hi! I configured timezone in config/app.php, for example:

    'timezone' => 'Europe/Moscow',

Then I added this DateTime field and Nova default DateTime field:

            \Wdelfuego\Nova\DateTime\Fields\DateTime::make(__('Date 1'), 'date'),
            \Laravel\Nova\Fields\DateTime::make(__('Date 2'), 'date'),

and I saw:

Nova default DateTime field show time with applying timezone.
This DateTime field show time without applying timezone.

Nova 4 defers formatting of Date/DateTime values in pickers to the browser by using its default picker implementation.

Many users have requested ways to customize the picker in different ways.

A custom DateTime field that implements its own customizable DateTime picker would be a super valuable addition to this package.

I have a datetime field and works fine displaying and selecting the time in datepicker but when I try to save it tries to save the date with the tz, is there a way to remove that and save like '2023-01-05 00:00:00'?

Related to issue #1

Unfortunately the implemented solution doesn't follow the nova behavior with timezones.

the solution you implemented

public static function withDateFormatFunction() : callable { return function (string $format) { return $this->displayUsing(fn ($d) => ($d instanceof Carbon) ? (config('app.timezone') ? $d->setTimezone(new DateTimeZone(config('app.timezone')))->translatedFormat($format) : $d->translatedFormat($format)) : (($d instanceof DateTimeInterface) ? (config('app.timezone') ? $d->setTimezone(new DateTimeZone(config('app.timezone')))->format($format) : $d->format($format)) : '') ); }; }

is using config('app.timezone') which is the default timezone of the application. But laravel nova is providing a way to personalise the timezone per user : see => https://nova.laravel.com/docs/4.0/resources/date-fields.html#timezones

use Laravel\Nova\Nova;
use Illuminate\Http\Request;

/**

Bootstrap any application services.

@return void
*/
public function boot()
{
parent::boot();

Nova::userTimezone(function (Request $request) {
return $request->user()?->timezone;
});
}

to be compatible with nova and the default customisation of timezone foreach user, the code should somehow look like this instead :

$d->setTimezone(new DateTimeZone($request->user()->timezone ?? config('app.timezone')))->translatedFormat($format)

if you see what i mean ?
Actually i'm facing the problem where the app default TZ is UTC, but users are coming from multiple tz and will only see the fields in the app default tz if i use this bundle.

Trying to set the format using globalFormat (and have tried inline as well). Ripping my hair out!

Getting an error as below..

Seems like globalFormat & have tried inline withDateFormat are being ignored.

Any ideas?

Nova 4.17.1

Everything up to date.