Giter Club home page Giter Club logo

foto's People

Contributors

dependabot[bot] avatar exadeci avatar waynezhang avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

foto's Issues

Duplicate slug names cause sections to fail grid layout

Here's a weird one, obviously a user error here but I ran into a problem where one of my sections would refuse to appear in a grid layout. All the images would appear full-width in a one-wide list, if that makes sense. I tracked it down to the problem being a duplicated slug identifier for two sections in my TOML, renaming one of them caused the issue to go away.

Naturally slugs ought to be unique and this is technically a user error, maybe some error reporting during building would be enough to address this already, but I figured it's worth reporting here nonetheless.

So the reproduction steps as far as I can tell are:

  • Make two sections
  • Set their slug names to identical text
  • Add layout.minColumn or more images to each section
  • The first section defined in the TOML file should appear correctly, the second one will not have a grid layout at all and simply show up as a list of images.

Let me know if you'd need any further information!

EXIF rotation isn't supported

Hey- I really like this minimal set-up and am trying to get a super simple 'upload from iphone' workflow for a trip log going. I ran into a problem though; the rotation information that gets encoded in the jpegs doesn't seem to be respected? I'm seeing photos taken in landscape show up as portrait on the site eventually.

It's addressed easily enough with some shell scripting but it would definitely be more convenient to not have to do manually.

runtime error: invalid memory address or nil pointer dereference on M1 and ARM64

๐Ÿฆ„ โฏ ~/foto preview
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x405668]

goroutine 1 [running]:
github.com/waynezhang/foto/internal/indexer.buildImageSets.func1({0x40000a82b8, 0x12}, {0x0?, 0x0?}, {0x40000ed818?, 0x405408?})
/home/runner/work/foto/foto/internal/indexer/indexer.go:71 +0x28
path/filepath.WalkDir({0x40000a82b8, 0x12}, 0x40000ed878)
/opt/hostedtoolcache/go/1.21.5/x64/src/path/filepath/path.go:530 +0x50
github.com/waynezhang/foto/internal/indexer.buildImageSets({0x40000a82b8, 0x12}, 0x0, {0x40000ed9b8?, 0x40000ed928?})
/home/runner/work/foto/foto/internal/indexer/indexer.go:70 +0xb4
github.com/waynezhang/foto/internal/indexer.Build({0x40000a42d0, 0x2, 0x0?}, {0x0?, 0x0?})
/home/runner/work/foto/foto/internal/indexer/indexer.go:54 +0x20c
github.com/waynezhang/foto/internal/cmd.preview(0x4000180200?, {0x57d042?, 0x4?, 0x57d046?})
/home/runner/work/foto/foto/internal/cmd/preview.go:35 +0x9c
github.com/spf13/cobra.(*Command).execute(0x40001b4600, {0x9f47e0, 0x0, 0x0})
/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:987 +0x828
github.com/spf13/cobra.(*Command).ExecuteC(0x40001b4900)
/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x344
github.com/spf13/cobra.(*Command).Execute(...)
/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039
github.com/waynezhang/foto/internal/cmd.Execute()
/home/runner/work/foto/foto/internal/cmd/root.go:38 +0x1b8
main.main()
/home/runner/work/foto/foto/main.go:8 +0x1c

๐Ÿฆ„ โฏ foto version
foto v1.2.1+a96a5e3

๐Ÿฆ„ โฏ uname -por
5.15.93-rockchip64 aarch64 GNU/Linux

Any thoughts?
I can supply a trace if needed

lazy loading / lozad

First I want to say - awesome project! Very simple and I appreciate the ability to customize.

Is lozad working properly for you? I have only tested on my localhost but all images are loaded almost immediately, and in a glitchy manner. It appears like images are fighting for placement as they load. I see the same/similar behavior on firefox, chrome and webkit based browsers, all running in linux.

I should state I have about zero web development experience. If you have any tips on debugging - or anyway I can get you some useful logs please let me know.

Thanks for your time!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.