warior456 / sculk-depths Goto Github PK

View Code? Open in Web Editor NEW

7.0 1.0 7.0 14.28 MB

adds a new dimension accessed via the ancient cities in the deep dark biome

Home Page: https://warior456.github.io/Sculk-Depths/

License: Other

Java 97.93% GLSL 2.07%

minecraft minecraft-fabric minecraft-fabric-mod minecraft-mod

sculk-depths's People

Contributors

Stargazers

Watchers

Forkers

nitjsefnie unroman kirbosoftware-mods dkxly charaaa123

sculk-depths's Issues

Lighting portal with Soul Heart in offhand doesn't take Soul Heart item from player

Warden crash (entity null)

Not entirely sure what's happened here but the warden is causing a crash

crash-2024-02-26_15.20.08-server.txt

[1.20]Kryslum fluid cannot be replaced by blocks and can be pushed by pistons

Refactor

Refactor to
-1.19.4
-modid: sculk_depths
-modName: Sculk Depths
-dimension: Sculk Depths
-mod creative item tab: Sculk Depths

Valtrox Recipe Missing Data

Valtrox leaves loot table currently does NOT* allow dropping leaves by silk touch and saplings do not drop through natural decay.

Recipe snip versus acacia that shows where information may be missing if this is not intentional.

Version information is the same as from the recent closed issue posted by JRCLARK25. ;)

Quazarith crafting recipe problems

The Quazarith sword and shovel still have regular crafting recipes, and it would be nice to have a Quazarith block made from the ingots for consistency.

[bug] foiliage color blue despite being set to green in the biome configs

in my latest world I made a Nether portal and it took me to the end instead of the Nether. I put the portal above an ancient city and the nether portal turns a grayish color and jade says its from customportal.api or something

Quazarith ingot and block are unobtainable

I can't seem to create quazarith ingots in the flumrock cauldron.

Missing Translations

I found some missing translations.
block.sculk_depths.kryslum (fluid in REI)
biome.sculk_depths.sculk_caves
biome.sculk_depths.cephlera_caves
biome.sculk_depths.petrified_valtrox_forest
biome.sculk_depths.dried_valtrox_forest

[Need Help] When the warden kills an entity with a specific (new) tag, let energy essence drop

new tag
let energy essence drop

Kryslum does not use it's custom texture

crafting quazarith ingots with a flumrock cauldron filled with kryslum

ingredients:
max filled kryslum
4 quazarith pieces
4 diamonds
= 1 ingot, can be extracted with a netherrite ingot and used in smithing table or can be directly right clicked with armor to upgrade it

Why do you use "fstats" and not telling about it, there's no info on the main page of the mod

 -----[ fStats ]-----
[01:42:03] [Server thread/INFO]: On server exist mod that collect metric data about mods usage for few author
[01:42:03] [Server thread/INFO]: That mod work like bStats, no need to panic. You can disable it config if you want

Minor Bug with Crafting Recipes

All crafting grids, vanilla and with 'Toms Simple Storage' an empty crafting grid gives free sticks.
Tested with our current mods (listed below) and removing Sculk Depths fixed the issue.

Also when crafting oak planks (with Oak Logs) it shows you will receive Valtrox Planks but you still receive Oak Planks. This isn't very common. It only has happened a few times in past week.

Server Side:
c2me-fabric-mc1.20-0.2.0+alpha.10.85.jar geckolib-fabric-1.20-4.2.jar sculk_depths-1.20.1-0.0.6_b.jar
carpet-extra-1.20-1.4.112.jar jamlib-0.6.0+1.20.jar starlight-1.1.2+fabric.dbc156f.jar
Chunky-1.3.88.jar lithium-fabric-mc1.20-0.11.2.jar toms_storage_fabric-1.20-1.5.6.jar
fabric-api-0.83.0+1.20.jar MCDiscordChat-1.20-2.1.4.jar vmp-fabric-mc1.20-0.2.0+beta.7.93-all.jar
fabric-carpet-1.20-1.4.112+v230608.jar NoChatReports-FABRIC-1.20-v2.2.0.jar
ferritecore-6.0.0-fabric.jar right-click-harvest-3.2.2+1.19.x-1.20-fabric.jar

Client Side:
BetterF3-7.0.0-Fabric-1.20-pre6
carpet-extra-1.20-1.4.112
fabric-api-0.83.0+1.20
fabric-carpet-1.20-1.4.112+v230608
ferritecore-6.0.0-fabric
geckolib-fabric-1.20-4.2
iris-mc1.20-1.6.4
lithium-fabric-mc1.20-0.11.2
NoChatReports-FABRIC-1.20-v2.2.0
reeses_sodium_options-1.5.1+mc1.20-build.74
sculk_depths-1.20-0.0.6
sodium-extra-0.4.20+mc1.20-build.103
sodium-fabric-mc1.20-0.4.10+build.27
starlight-1.1.2+fabric.dbc156f
toms_storage_fabric-1.20-1.5.6
Xaeros_Minimap_23.4.4_Fabric_1.20
XaerosWorldMap_1.30.3_Fabric_1.20

Parsing error loading recipe sculk_depths:soul_heart_depreciation

Hi, I'm seeing that there's an error in the console caused by sculk depths. It doesn't break anything, but since it's an error I decided to report it here. I'm playing on Minecraft 1.20.1, Fabric Loader 0.14.23, mod version 1.20.1-0.0.9_b

[Render thread/ERROR]: Parsing error loading recipe sculk_depths:soul_heart_depreciation
com.google.gson.JsonSyntaxException: Unknown item 'sculk_depths:soul_heart'
	at net.minecraft.class_1869.method_17878(class_1869.java:272) ~[client-intermediary.jar:?]
	at java.util.Optional.orElseThrow(Unknown Source) ~[?:?]
	at net.minecraft.class_1869.method_8155(class_1869.java:272) ~[client-intermediary.jar:?]
	at net.minecraft.class_1856.method_8107(class_1856.java:160) ~[client-intermediary.jar:?]
	at net.minecraft.class_1856.method_8102(class_1856.java:143) ~[client-intermediary.jar:?]
	at net.minecraft.class_1867$class_1868.method_8144(class_1867.java:107) ~[client-intermediary.jar:?]
	at net.minecraft.class_1867$class_1868.method_8142(class_1867.java:92) ~[client-intermediary.jar:?]
	at net.minecraft.class_1867$class_1868.method_8121(class_1867.java:87) ~[client-intermediary.jar:?]
	at net.minecraft.class_1863.method_17720(class_1863.java:135) ~[client-intermediary.jar:?]
	at net.minecraft.class_1863.method_20705(class_1863.java:56) ~[client-intermediary.jar:?]
	at net.minecraft.class_1863.method_18788(class_1863.java:35) ~[client-intermediary.jar:?]
	at net.minecraft.class_4080.method_18790(class_4080.java:13) ~[client-intermediary.jar:?]
	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?]
	at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?]
	at net.minecraft.class_4014.method_18365(class_4014.java:69) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_18859(class_1255.java:156) ~[client-intermediary.jar:?]
	at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_16075(class_1255.java:130) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.method_18857(class_1255.java:139) ~[client-intermediary.jar:?]
	at net.minecraft.class_7196.method_45694(class_7196.java:188) ~[client-intermediary.jar:?]
	at net.minecraft.class_7196.method_41891(class_7196.java:123) ~[client-intermediary.jar:?]
	at net.minecraft.class_7196.method_41899(class_7196.java:202) ~[client-intermediary.jar:?]
	at net.minecraft.class_7196.handler$bfe000$bclib$wt_callFixerOnLoad(class_7196.java:1046) ~[client-intermediary.jar:?]
	at net.minecraft.class_7196.method_41894(class_7196.java) ~[client-intermediary.jar:?]
	at net.minecraft.class_528$class_4272.method_20174(class_528.java:590) ~[client-intermediary.jar:?]
	at net.minecraft.class_528$class_4272.method_20164(class_528.java:480) ~[client-intermediary.jar:?]
	at net.minecraft.class_528$class_4272.method_25402(class_528.java:402) ~[client-intermediary.jar:?]
	at net.minecraft.class_350.method_25402(class_350.java:327) ~[client-intermediary.jar:?]
	at net.minecraft.class_4069.method_25402(class_4069.java:38) ~[client-intermediary.jar:?]
	at net.minecraft.class_312.method_1611(class_312.java:98) ~[client-intermediary.jar:?]
	at net.minecraft.class_437.method_25412(class_437.java:409) ~[client-intermediary.jar:?]
	at net.minecraft.class_312.method_1601(class_312.java:98) ~[client-intermediary.jar:?]
	at net.minecraft.class_312.method_22686(class_312.java:169) ~[client-intermediary.jar:?]
	at net.minecraft.class_1255.execute(class_1255.java:102) ~[client-intermediary.jar:?]
	at net.minecraft.class_312.method_22684(class_312.java:169) ~[client-intermediary.jar:?]
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar:?]
	at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.1.jar:?]
	at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474) ~[lwjgl-glfw-3.3.1.jar:?]
	at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1244) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:250) ~[1.20.1-0.14.23.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.23.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.23.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.23.jar:?]

Kryslum generation is replaced with lava generation when c2me is installed

this is an issue to remind ourselves and figure out a solution

1.20-Nether Portals Lead to End

1,20 Fabric
If Sculk Depths mod is enable a standard nether portal leads to the End instead of the nether

Makes Nether portal a blueish gray instead of normal purple

Same behavior on server and in single player