Giter Club home page Giter Club logo

signshop's Introduction

SignShop LOGO

SignShop allows you to set up physical shops by punching a chest with your items you want to sell, then punching a sign (while holding redstone dust). It's easy to set up, and even easier to customize!

Project Links

Basic Features

  • Don't need to memorize any annoying commands
  • Can create global shops (with infinite items and infinite money using [iBuy] and [iSell])
  • Can create player owned shops
  • Can buy and sell raw XP and XP levels
  • Signs have colors: [Blue] means the shop is stocked and working, [Red] means the shop is out or overstocked, [Black] means the sign is not active
  • Can sell multiple items per sign (e.g. Alchemy Starter Kit, containing 3 glass bottles 1 brewing stand, netherwarts, ghast tears, etc.)
  • Chests do not need to be directly under signs, they can be anywhere (Distance can be customized in the config)
  • Can use multiple signs per chest (just remove any extra items, link the chest to the new sign, and stock the chest with multiple item types!)
  • Ability to set up shops to control redstone levers (to charge admittance to a door, power some sort of contraption, blow up a bunch of TNT, whatever you want!)
  • Can limit number of shops per player or permission group
  • Can edit active signs by clicking a sign with the desired text using Black - Dye and then clicking the active SignShop
  • Can disable trading with villagers
  • Profit sharing using [Share] signs linked to SignShops
  • Restrict shop use to only groups listed on [Restricted] signs
  • Localization support (if you would like your native language to be - supported, help us translate our config! More information on this page.)
  • Supports custom potions, books, fireworks, and lores

Advanced Features

  • Can set up signs to run commands in console
  • Can run commands as if the buyer typed the command themselves (use "runCommand{asUser}" block in the config. NOTE: "*" permission nodes must be supported by your permission plugin for this feature)
  • Can run commands after a certain amount of time, allowing you to sell things like temporary permissions
  • Can sell partial amounts to signs (disabled by default)
  • Customizable messages
  • Customizable signs
  • Can define multipliers for groups to allow certain groups to get discounts or make more money for selling items

List of signs

Player signs

Sign Description
[Buy] Buy an item from the shop chest for the price specified on the 4th line
[Sell] Sell an item to the shop chest for the price specified on the 4th line
[Trade] Trades one set of items for another, 2 chests required
[Share] Link to another SignShop to split profits, lines 2 and 3 are for the other players, line 4 is for % amounts (e.g. "25/50" for 75% to others)
[Bank] Link to another SignShop to make the shop take/give money to a bank account, The bank account is specified on line 2 of the sign (Note: you must own the bank account for this to work)
[Donate] Gives an item to the shop chest
[DonateHand] Donates the item in your hand to the shop chest
[Dispose] Takes the item in your hand and safely decomposes the material
[Slot] Gives a random item from the selected chest items (not the entire inventory) to the player
[DeviceOn] Turns a lever on
[DeviceOff] Turns a lever off
[Toggle] Toggles a lever
[Device] Temporarily turns on a lever
[DeviceItem] Temporarily turns on a lever using items as payment
[Jukebox] Allows players to create jukeboxes by placing music discs in a chest
[Restricted] Makes it so only certain permission groups can use the linked SignShop (listed on lines 2, 3, and 4)

Admin signs

Important: "Admin" signs require OP or SignShop.Admin.* to create

Sign Description
[gBuy] Buy an item from the shop chest, but the owner receives no money
[gSell] Sell an item to the shop chest, and the player receives money, but not from the owner
[iBuy] Buy an item from the "shop", money goes to no one, infinite items
[iSell] Sell an item to the "shop", infinite money, item disappears
[iTrade] Trades one set of items for another, infinite stock
[Class] Takes the user's inventory and replaces it with items from a chest, infinite stock
[Kit] Gives the buyer a set of items once (infinite stock), must be reset using ResetKit sign before they can use it again
[ResetKit] Allows a player to use a Kit sign again
[iBuyXP] Buy the number of XP levels on the third line of the sign
[iSellXP] Sell the number of XP levels on the third line of the sign
[iXPBuy] Buy an item using raw XP points on the third line of the sign
[iXPSell] Sell an item using raw XP points on the third line of the sign
[iSlot] Gives a random item from the selected chest items with infinite stock
[Day] Turns the time to day
[Night] Turns the time to night
[Rain] Turns on rain + thunder
[ClearSkies] Turns off rain + thunder
[Repair] Repairs the current item
[Heal] Fully heals the player
[Enchant] Sells the enchantments from the item in the chest
[Disenchant] Removes enchantments from an item
[TpToOwner] An example of a custom sign for running commands
[Command] Allows players to run commands on the 2nd and 3rd lines of the sign
[UserCommand] Allows players to run commands on the 2nd and 3rd lines of the sign as if they typed it themselves
[Promote] Promotes players to the permission group listed on the 2nd line of the sign

Info: If the sign you are looking for isn't here, you can create custom signs in the config. Just add it to the signs: section and give it the appropriate blocks. If you need help, make sure to check out the SignShop Quick Reference found in your plugins/SignShop folder.

Permissions

Permission Description
Signshop.DenyUse.* Denies usage of signs. Example: You may wish to deny a group's ability to sell to an infinite shop (i.e., an [iSell] sign), in which case you would give them: Signshop.DenyUse.iSell
Signshop.DenyLink.* Denies the linking of shops to certain in-game blocks (Chest, Sign, Lever, Dispenser, Furnace, Brewingstand, Enchantmenttable, Slab). Example: You may wish to deny a group's ability to link their shops to a furnace to prevent automatic smelting, in which case you would give them: Signshop.DenyLink.Furnace
Signshop.Signs.* Allows players to create signs. Example: You might want to disallow a group from creating signs to modify redstone levers, you can remove that ability by negating them with the following permission nodes (assuming your permission plugin allows negating permissions): -Signshop.Signs.Device -Signshop.Signs.DeviceOn -Signshop.Signs.DeviceOff -Signshop.Signs.Toggle
Signshop.CopyPaste Allows players to click on signs with black dye to copy information onto an already active SignShop. Example: If you want to update the price of an item, create a new sign and put the new price on the bottom line, leave the other 3 lines blank, and click with black dye. You can modify the description, the price, and the type of sign this way. Blank lines are ignored. You cannot, however, change a Device sign to a Buy sign, as the operations are incompatible with one another. You can also allow moderators and admins to edit other player's signs with Signshop.CopyPaste.Others
Signshop.Permit If the "AllowPermits" setting in the global options is set to true, players must have this node in order for their shops to work. Example: You can use SignShop and a permission plugin to sell permits allowing users to be merchants. Without a permit, the shop will be disabled and they will need to buy another in order for their shops to continue functioning. You can also do Signshop.Permit.Stone to only allow shops containing the material “Stone”. (Make sure to replace any spaces with an underscore, i.e. “BAKED POTATO” becomes “BAKED_POTATO”)
Signshop.ChangeOwner Allows a player to click on another player with redstone to change the owner of a SignShop. Example: If you would like to set up a player account as a bank, or transfer a store to another player, you would punch them with redstone, then punch the sign you would like to modify. If you do not own the sign that is being modified, you will also need the permission Signshop.ChangeOwner.Others to do so.
Signshop.Destroy.Others Allows a player to destroy shops that they do not own. Example: Give this permission to moderators or helpers that you want to be able to clean up abandoned shops but you don't want them to be able to do other SignShop admin duties.
Signshop.IgnoreMax Bypasses any defined maximum shop settings in the config. Example: You can make it so normal players can only create something like 10 signs, while donators can create infinite, by giving them Signshop.IgnoreMax
Signshop.IgnoreRepair Bypasses AllowEnchantedRepair setting in the config. Example: You can make it so "Blacksmiths" can repair enchanted items with Signshop.IgnoreRepair
Signshop.Inspect.Own Allows you to inspect your own shops by hitting the sign with the inspection material. (Book and Quill by default)
Signshop.Inspect.Others Allows you to inspect other player's shops by hitting the sign with the inspection material. (Book and Quill by default)
Signshop.Dye.Own Allows you to use dyes and glow on your shop signs.
Signshop.Dye.Others Allows you to use dyes and glow on shops that you do not own.
Signshop.BypassShopPlots.* Bypasses EnableShopPlotSupport setting in the config. Example: You can make it so VIPs are allowed to create shops in regions with the “allow-shop” flag set to “deny” in Worldguard using Signshop.BypassShopPlots.Worldguard
Signshop.Admin.* Allows players to create administrative signs (such as shops with infinite items for global shops). Example: You can use this permission to grant the ability to make signs with the playerIsOp tag (defined in the config). Signshop.Admin.Heal allows a player to create a healing station.
Signshop.SuperAdmin Makes players seen by SignShop as OPs. Example: You can use this permission to grant the ability to bypass the blacklist, break other users' shops, use /signshop reload, etc.

FAQ

How do I get money?

Firstly, you must have Vault on your server. Secondly, you must be using one of the many economy plugins Vault supports. GoldisMoney and Gringotts are both good for item based economies. If you would rather have a currency, Craftconomy is a popular choice. Then you must use a command from your economy plugin to give yourself money. Check their documentation, but it's usually something like /money grant, /eco give, things like that.

Why isn't money coming out of my account?

Firstly, make sure you have an economy plugin and Vault installed. If you have done that correctly, then chances are, you are buying from a shop that you made yourself. The money is going to the owner of that sign, and that happens to be you. To avoid that, use an infinite sign like [iBuy] and the money will not go into the owner's account, or have someone else make a sign that you can use.

How do I make shops with infinite items / no chest?

Usually when people ask this, they want an [iBuy] or [iSell] sign, but there are many other shops with infinite items. You will need the chest to setup the shop originally, but you can destroy it afterwards.

Why is my shop only giving me X amount of items? I want it to give me Y amount!

When you link the sign and the chest, the amount that is in the chest will be the amount of items per transaction. So if you want to only sell 8 of an item with each transaction, you put 8 in the chest, then link it to the sign. Afterwards, you can fill up the chest, and it will still continue to sell 8 at a time.

Why can't my players use shops? They can only get the confirm purchase message.

This is usually caused by a plugin interfering with SignShop or the built-in vanilla spawn protection. Try changing spawn-protection=16 to spawn-protection=0 in server.properties. If you have Essentials installed try disabling all of the Essentials signs including -color by commenting them out. Otherwise, you can use your permission plugin's verbose logging to see what permissions are being checked when they try to use a sign. i.e. /LuckPerms verbose on or /pex toggle debug.

What does THIS feature/option do, and how do I use it?

Most of these sorts of questions are answered in our Tutorial Video and Quick Reference PDF. You can also find this in your plugins/signshop folder for your server. If it is not answered there, feel free to drop a comment on our main page.

My [Slot] sign keeps randomly running out of items, what gives?

Think of each slot in the chest like it has an even chance of being the slot selected to give to the player. If you wanted a 10% chance for diamond, and 90% chance of coal, you would put a diamond in a slot, and coal in 9 separate slots. With this setup, if you were to get the diamond on your first try, it would be removed from the chest, and it would report the chest is out of stock because there are no diamonds, so it's impossible for a player to win a diamond. Once an item is no longer in the chest, it cannot be randomly selected to be given out. To avoid this, after linking the chest with 1 diamond and 9 coal, you can fill the whole chest up with diamonds and coal, just like a normal shop. Also, if you wanted the winner to have a 10% chance of getting 2 diamonds, and 90% chance for coal, you could do the same as before, but put 2 diamonds in one slot of the chest, so you will still have 10 filled slots total when linking.

How come [Device] type signs aren't activating my redstone?

[Device] type signs will only work on levers that are on the ground, not on walls. Unfortunately, this is a bug in CraftBukkit and there is nothing we can do about it.

How do I destroy a shop?

If you are in creative mode you must use a gold axe (if ProtectShopsInCreative is set to true in the config). Otherwise, you can use anything except redstone dust or an ink sack. Note that these are all the default objects set in the config, you can change these items.

Can you make it so people HAVE to write what they are selling on the sign?

I know many people think that writing one thing on a sign, and selling another is a good way to scam people. HOWEVER, if you are a buyer, all you have to do is left click a sign, and it will tell you exactly what it is selling. We do it this way for 2 reasons. The first is because you cannot sell multiple items with the limited amount of space on a sign. In SignShop you can sell an Alchemy starter kit, 1 Brewing Stand, 3 Glass bottles, Netherwarts, etc. all on one sign. That would be impossible to list. The second reason is because then your users have to memorize item numbers, or item names. Think about how many things you can call a wood slab (wood slab, wooden slab, wood step, wooden step, etc.). It's just too annoying to memorize.

Can you update the plugin to the latest version of Minecraft?

There's not usually something that needs to be changed in SignShop just because Minecraft has changed versions. Our latest release should work. Occasionally, however, something DOES change that requires our attention. If this is the case, first grab the latest development build and make sure that doesn't solve your issue. If it does not, please create a ticket and fill out the requested information. Development builds of this project can be acquired at the provided continuous integration server. These builds have not been approved by the BukkitDev staff. Use them at your own risk. You can get them here.

How do I get help or make a ticket?

First run the "/signshop help" command to get the version information. Then check which Bukkit version you have by running "/version". Then make sure you get all the lines from any relevant error messages from your server.log. And lastly, put all the info in a new ticket.

signshop's People

Contributors

beer-avalanche avatar bonne avatar chelminski avatar devinish avatar dionrhys avatar mcmerdith avatar mrjesen avatar patboud avatar roycurtis avatar runelynx avatar umbyumbreon avatar wargamer avatar weaves7 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

signshop's Issues

Plans for SpongeAPI port?

Hello,

Was curious if you folks are planning or have any interest in doing a port of this plugin to the SpongeAPI.

Thanks,

[Slot] are not onfinite

I have some isue with the commabde [slot]
For my server whe want to make some "lucky block' in the spawn but every time i buy for get a random item they remove it from the chest... Ther is a possibilite to make it not removed (only admin)

Shops

i noticed that when trying to sell spawn egg it give a egg naes spawn and isnt what i bought and i think it might mess up with potions as well but not tested it

Error in SignManager

[Server thread/CRITICAL]: "Could not pass event 'pocketmine\event\level\LevelLoadEvent' to 'SignShop v1.1.3': Illegal offset type on SignShop\EventListener\LevelEvent"
[15:50:01] [Server thread/WARNING]: RuntimeException: "Illegal offset type" (E_WARNING) in "/var/mcpe/shared/Plugins/SignShop_v1.1.3.phar/src/SignShop/Manager/SignManager" at line 176

[device] wont work with redstone

It doesn't send signal if lever is connected to redstone but it does when its placed directly on the block, for exemple on a command block..

Towny + SignShop: Stealing items from chests in an enemy town.

If you click a chest in an towny protected area (like an enemy town) with a redstone dust to create a shop, you can create a shop from that chest and then buy everything that is inside that chest. On our server we don't have a chest protector plugin because that is part of our gameplay so the only way to protect a chest is by placing a block on top of it in a protected area (like a town where other people can't break blocks). So when you create an shop from an chest thats not yours you can steal everything from it even if it's protected with a block on top of it.We also don't want to have a max distance of the sign <--> chest. Ideal should be that SignShop can hook into Towny and let the "item_use" permision part of storing a chests container.

Maven Pls.

Can you please create a proper pom.xml file for you project. Makes compiling your dev builds much easier as the dependencies will follow the repo when cloning it.

Many Thanks for what you do!

iTrade stops working with fireworks since 1.12.1 upgrade.

Hello !

We recently upgraded our server from 1.9 to 1.12.1. Everything is fine except that when I create an [itrade] shop that will take specific fireworks from the player's inventory and give him back a paper (Objective to get for the player ranking up), it doesn't work anymore. I put two chests: fireworks trail 1 sec, effect with diamond and one specific color, the paper in the second chest. I punch the first one with the redstone, the second one the same way then the signshop. It works as the [iTrade] becomes blue. But when I want to exchance those fireworks for the piece of paper, it tells me that I don't have the items needed and shops me in the chat windows that I need fireworks, but it's written twice instead of once for the itrade signs placed before the update, if I haven't these in my inventory.

Did I miss something ? I didn't see anything related to this issue.

Any help is welcome !

v2.11.2 SEVERE ERROR

I just want to let you know that there is a Server Error with 2.11.2.
[SEVERE] Could not pass event SSLinkEvent to SignShop v2.11.2

Not sure what it means everything works fine players are able to buy and sell from shops but if they interact with a sign it puts out a long error message I would post the whole thing here but its a lot.

I have been good at keeping records of versions of plugins and spigot when I update the server or add new plugins so I have that if you need it.

Also, the spigot version is 1.12.1 build 60.

If you need any further information let me know I will check back here in a couple days and see if there is a reply, if not then you can contact me via the email below as I rarely get on this website so I don't know if I get an update on this issue or not.
[email protected]

Users can use dye on signs

I leave the issue here so you watch it when you can.

If I make a "[buy]" sign in which the item inside the chest is a dye, users can use this object to change the color of the letters of the sign and disable it.
Bypassing the WorldGuard restrictions, this doesn't happen if the item to buy is not a dye.

Signshop 3.4.4
PaperSpigot 1.15.2

error: https://gyazo.com/89b2a585d9fbe5ebb0f868ab0a174ff4
ITEM: https://i.gyazo.com/ae25ad0d3a4858769e84f206412e709d.png
plugins: https://i.gyazo.com/4341808271111efdb6ecb04d0d35b6b7.png

Items 1.13

Today I updated the essentials plugins on my server (dev to 1.13), since for its plugin it had the requirement to work with the worth.yml of this same plugin.

Unfortunately I see that the plugin still does not recognize many items of the new version, that's why I create this incidence to try to make this work again and continue with this plugin, because it is essential and vital for my server.

Buying from shops w/ more than one item for sale

If you buy from a shop that has multiple items for sale & you either don't have enough money(items) or don't have enough inventory space, it will take your money but give you nothing.

Also, it would be nice if you did have this, if it could FIRST remove the items you are using to pay with from your inventory THEN add the item, because right now it does it the opposite way and if it was reversed they would have enough space.

Read-Me Before Posting An Issue or Suggestion!

If you have a simple issue or suggestion please consider joining our Discord https://discord.gg/4wnyysf

For more complex issues please post a new issue here and make sure you include the following:

  • A detailed description of the problem you are having
  • Server type and version i.e. Spigot 1.15.2
  • SignShop version
  • Vault version
  • Economy plugin name and version i.e. EssentialsX 2.17.2
  • A link to a pastebin with your entire startup log including any errors you have after startup.

For suggestions please provide a very detailed description of what you want.

Buy signs for written books break on plugin reload

Summary

If a SignShop is created to sell written books with NBT data (e.g. book author, title, contents), it is able to buy those books and determine it is in stock in a chest until the plugin is reloaded. After which, it incorrectly determines the books are out of stock and appears to lose the extra information associated with what it is buying.

(Note: this bug may also extend to sell signs, or other items that may hold data such as enchanted tools)

Details

Reproduction

  1. Create a chest and a sign with [Buy] on the first line
  2. Obtain a book and quill, open it, write random text inside, sign it with a random title
  3. Use an Essentials command such as /more to obtain a stack of the signed books
  4. Add a single copy of the book into the chest and link to the buy sign with redstone. Observe it correctly identifies the title and author.
  5. Insert the entire stack of books into the chest and punch the sign. Observe it correctly identifies the stock
  6. Execute /signshop reload or restart the server
  7. Punch the sign. Observe it now reports the shop as empty (Unusually, this contradicts the reporting player's screenshot where the author and title of the books had gone missing. In my reproduction, the data is still in the message but the stock is wrong).

Question on how you check chest contents

Hello,

We are using Sign Shop on our 1.7.10 Cauldron server. We have injected additional storage containers into the bukkit material manager enum via FML. Your plugin handles the ability to add additional storage via this option in the config.yml:

linkableMaterials:
CHEST: chest
ALMURA_STORAGEDOCK_CHEST: chest
ALMURA_STORAGEQUANTUM_CHEST: chest

We added the additional example chests to our server. When we left-click on the chest with redstone the player is given the message "Stored location of Almura Storagedock Chest containing nothing".

I was curious if you could point me to where in your code it does the lookup to detect whether or not the current x/y/z location contains NBTdata containing the ItemStack information within our chest.

Many Thanks
~AlmuraDev Team

Automatically update ink_sac and golden_axe in config

As part of the SignShop design philosophy, we try not to require the user to have to touch anything in the config in order for the plugin to work out of the box. as part of the upgrade to v3, users are required to update their config indicating what item is for updating signs, and what item is for destroying the sign in creative mode. Ideally, the user will not need to touch their config for a successful update.

As a personal note, we would often get many private PMs and complaints when things "broke" because of things like this.

Acceptance Test

  • Given I have an existing config from v2, when starting the server and updating from v2 to v3, then I still have all of my settings in SignShop and I do not need to modify my config to avoid errors.

How to compile

There's no way to compile this project. Not even all required jars are provided with the project.

Change the SignShop Prefix

Hi,
I couln't find an option to to translate/change the SignShop Prefix.
I know there is an option in ChestShop wasn't able to find it in SignShop.
Any chance you could add such a feature?

BugFix

// org/wargamer2010/signshop/listeners/sslisteners/SimpleShopProtector.java

@EventHandler(priority = EventPriority.LOWEST)
public void SSBugFix(BlockPlaceEvent event) {、
    Block block = event.getBlock();

    if(block.getType() == Material.SIGN_POST) {
        Location location = block.getLocation();
    //  Player player = event.getPlayer();
    //  player.sendMessage(ChatColor.DARK_GREEN + "you place a signpost(X:" + location.getX() + ", Y:" + location.getY() + ", Z:" + location.getZ() + ").");

        if(Storage.get().getSeller(location) != null) {
        //  player.sendMessage(ChatColor.DARK_GREEN + "fix a bug shop.");
            Storage.get().removeSeller(location);
        }
    }
}

Price Multipliers permissions instead of groups

Dear,

In some gamemodes players get permissions instead of groups (prison servers where they quickly change group based on hunter).

Is it possible to add an additional permission:

signshop.multiplier. (signshop.multiplier.vipex)
?

Regards,
Maximvdw

Using a buy/sell sign wipes "extra" data off certain items

This appears to be a conflict between signshop and any vanilla mod that creates items with non-vanilla NBT data on them. So far I've been able to reproduce the issue with power suit mod. If you have modules attached to the powersuit in your inventory but not equipped then buy an item from a signshop, it will wipe the nbt data and thus remove the modules from the item. There have been mysterious nbt errors before that I did not know what to attribute it to but I suspect that this may be related as well.

I'm having a look myself through the code to see if I can find the issue, but I assume you are much more familiar with the code so I hope you may find it more reliably than I.

IXPSell

Good, I have an error with "ixpsell", if you equip an orb of experience in the left hand (f), jump the error "could not complete operation, contact your system administrator and check the logs", the item is not sold but If that gives you levels of experience.

No Maven Repo

Hi,

I am hooking a plugin I am writing to SignShop. The plugin tracks Minecraft Server stuff to Google Analytics. With SignShop I'll be tracking transactions through as if they were ecommerce transactions on a website. Should give some nice metrics.

https://github.com/nyvaria/OpenAnalytics

(Note that the code currently checked in to do this is incomplete)

Of course, I ran into the "no maven repo" thing. Somewhere I read in one of your issues or whatnot on Bukkit dev that you intended to mavenize the project sometime soon.

Is that something you would appreciate help with? If so, I'd be happy to create a fork and give it a go.

Whatever the case, thanks for the cool plugin.

Cheers,
Paul Thompson
aka captbunzo

The signshop will not work in a residence

The Signshop will not work in a residence(created by the plugin named Residence).
when the op right click the sign it will work
but normal players right click the sign,it will not work.

in the public place(not a residence),all the players can click.
i am sure that the plugin is loaded successfully.

(my english is not good, thanks)

Taking over SignShops

#49 @Devinish There's someone currently interested in taking over the plugin and updating it to 1.13

He might contact you through private message in spigot and bukkit websites if you want to check it out.

Hexdata with Signshop

Hi there,
I have a quick question about using Signshop with Items which just differ by hexData (like the items from Tinkers Construct). Is there a way to do it?

I'm myself a server owner and got this request from one of my players, so I'm currently searching for a solution. After some research I found out that the tools all have the same ID and differ only in the metadata. I remember from prior server plays that chestshop (https://github.com/Acrobot/ChestShop-3) can handle this problem with a suffix with '#' (like DIRT#a) to specify the item. Maybe you could take a look there and build it into SignShop.

[request] Storing custom items (Custom heads/items with lore/Brewing support)

Hello Signshop team!

PirateCraft is a long time user of SignShop, I have requested these features before, so Im sorry if you recognise this request. Could we please have the option to Store and Sell custom items, this includes:

  • Custom Heads, I assume the full data set for storing a custom made head (say from freshcoal) isn't stored properly, as you can set up a shop and sell a head, but as soon as the server restarts all heads revert back to being blank skulls.
  • Custom items with Lore; We ran into an issue earlier when we tried to set-up an item sign using a custom item made from essentails that had lore, turns out custom names work, but items with custom lore do not, Im not sure if this bug is just for item signs or in general saving lore.
  • Brewing support, this is a third party plugin and may be too complex to save the brew info for each brew into your current database, but its worth a shot asking! https://www.spigotmc.org/resources/brewery.3082/

Thank you!

Toggle signs break on use if chunks were unloaded

If the chunks a [Toggle] sign and its lever are in become unloaded, when they are loaded again the Toggle sign will only become usable once before becoming "stuck".

Workaround

By executing /signshop reload, Toggle signs work properly again

Details

  • CraftBukkit version git-Spigot-b73910a-aa92a45 (MC: 1.8) (Implementing API version 1.8-R0.1-SNAPSHOT)
  • Server plugins: http://i.imgur.com/QSLUAD0.png
  • SignShop version: 2.9.1Dev (build 68)
  • Vault version: 1.5.2-b33
  • Tested with region, permissions, signshop flags and LWC flags checked
  • ChunkLoadRadius in config.yml is set to 2 (default)

Reproduction

Best reproduced in a location far from spawn or away from forcefully loaded chunks. Ideally on a server with /home and /spawn available

  1. Create a [Toggle] sign and wire it to a lever
  2. Right click the sign a few times. Observe that the lever changes state and SignShop gives feedback in chat.
  3. Teleport at least 20 chunks (320 blocks) away, wait a few seconds, then teleport back. Repeat this step a few times.
  4. Right click the sign once. Observe that the lever changes state and SignShop gives feedback in chat.
  5. Right click the sign a few more times. Observe now that the lever no longer changes, but SignShop is still saying the sign has been toggled.
  6. Execute /signshop reload
  7. Right click the sign a few more times. Observe now that normal behavior has returned.

Reserve Support

Hello, I am the developer of the plugin Reserve, a modern economy API with modern economy features in mind. As I am now ready to publicly push the API, I'm currently looking for developers to add support for it.

Link: https://github.com/TheNewEconomy/Reserve

Advantages over Vault:

  • Multi-currency support
  • Async support using Java's completeable futures
  • Optional Extended API to allow third party plugins to add new currencies

Current Plugins that support Reserve:

  • Towny
  • ChestShop3
  • MineBay

Current Providers/Planned Providers:

  • The New Economy
  • Towny Eco
  • GemsEconomy

Thanks in advance,
creatorfromhell

Slot's bugged and others

Bugs have been emerging regarding this feature for a long time.

1 - The probability does not work correctly, if when the slots just do not move the item is much more likely to not touch anything after refilling.

2 - Currently you can insert and remove materials from the slot while it is still working, if a user is playing and the seller is filling, will not get the prize ever, this should be solved by modifying the way to make slots and any changes disable it.

3 - If they fill all the holes of the slot and then remove 52 objects (out of 54), the odds are still 1 in 54, and will never touch the prize or very rarely.

4 - Custom user heads are giving errors.
 4.1 - When the server reboots, they are no longer textured.
 4.2 - If they make a slot with a personalized head and then change it by one
         normal, they get the old head infinitely.

5 - The items with enchantments superior to those of minecraft, become by default to the server restart (especially the swords).

What I ask here is if you can please restructure this mode, since there are many problems, in fact, I do not see how to solve them and I will remove it until it is solved.

[Suggestion] A gui system

Hello,
This plugin is very good but something is missing to make that plugin perfect !

A gui where the players can see the other players shops and teleport themselves to them.
The player can also see his own shops to see what's he selling or buying (When players have a lot a shops it's easier to organise them).

It's my idea, if you need more details about it, I would be happy to answer you !
Dofy

Warning of Overstocked

I noticed someone had posted about this on the comments of the bucket page a link to the latest Dev build was there said it would resolve issue. I have updated to latest dev build and still i recieve the overstocked message

Is there a fix?

Signs that require more space than player inventory (no trade possible)

I was able to create a [Buy] sign selling 3456 items, using a double chest.

This trade is not possible because double chest has more item space than player inventory.

SignShop should give some kind of error (or not register blue sign) on trades that require more inventory slots than player inventory.

Async tasks not shutting down properly?

During reload, the following log appears in the console:
[23:58:45 ERROR]: Nag author: 'Wargamer2010 and Devinish' of 'SignShop' about the following: This plugin is not properly shutting down its async tasks when it is being reloaded. This may cause conflicts with the newly loaded version of the plugin

Using SignShop v2.9.1

[critical] SignShopPlayerListener (PlayerInteractEvent) creating dramatic lag on 1.12 (V2.11.2)

Using PaperSpigot latest 1139 build. (1.12)
Using SignShop 2.11.2

I just had a server crash after I had 50+ people online, The issue is Signshop.
From Timings report:

http://i.imgur.com/JsXu4MF.png

The signshop event:
Minecraft::Packet - PacketPlayInBlockDig
SignShop::Event: o.w.s.l.SignShopPlayerListener (PlayerInteractEvent)

is causing dramatic lag.

is there any way we can diagnose the issue and get it fixed please?

Error loading the plugin with CMI

Hello!

I just installed a clean version of SignShop and I get this error:

[21:06:50] [Server thread/ERROR]: Error occurred while enabling SignShop v3.4.4 (Is it up to date?)
java.lang.NullPointerException: null
at org.wargamer2010.signshop.worth.CMIWorthHandler.(CMIWorthHandler.java:16) ~[?:?]
at org.wargamer2010.signshop.SignShop.onEnable(SignShop.java:189) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.15.2.jar:git-Paper-118]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) ~[patched_1.15.2.jar:git-Paper-118]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:435) ~[patched_1.15.2.jar:git-Paper-118]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:470) ~[patched_1.15.2.jar:git-Paper-118]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:384) ~[patched_1.15.2.jar:git-Paper-118]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:482) ~[patched_1.15.2.jar:git-Paper-118]
at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:298) ~[patched_1.15.2.jar:git-Paper-118]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:885) ~[patched_1.15.2.jar:git-Paper-118]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]

The server version is 1.15.2
Signshop version is 3.4.4
Vault version: 1.7.3 (CMI Version)
Economy plugin: CMI

I think it has something to do with CMI not being compatible, looking at the error, but I have no idea if it's my fault or just a compatibility issue...

Toggle signs not updating redstone if levers are on walls

If a [Toggle] sign is wired to levers which are attached to a block vertically, the toggle signs will toggle the state of the levers visually but the redstone signal itself will not update. This means that doors, pistons, etc. will not toggle.

Video explanation; https://www.youtube.com/watch?v=pXpvsQOF2yw
Examples of non-working and working setups, respectively: http://i.imgur.com/5dtVRUw.png http://i.imgur.com/cjvpMHO.png

Details

  • CraftBukkit version git-Spigot-b73910a-aa92a45 (MC: 1.8) (Implementing API version 1.8-R0.1-SNAPSHOT)
  • Server plugins: http://i.imgur.com/QSLUAD0.png
  • SignShop version: 2.9.1Dev (build 68)
  • Vault version: 1.5.2-b33
  • Tested with region, permissions, signshop flags and LWC flags checked

Reproduction

  1. Place a lever on the side of a block
  2. Place a door on top of that block
  3. Toggle lever to confirm it opens and closes
  4. Place a sign nearby with [Toggle] as the first line
  5. Punch the lever with a piece of redstone
  6. Punch the [Toggle] sign with a piece of redstone
  7. Confirm in chat that SignShop has created a new toggle sign
  8. Right-click the sign with an empty hand a few times
  9. Observe that the lever changes, but the door does not

Not Working?

The Plugin seems to work fine as in, I can make the signs and setup the shop, but even if I have a balance that CAN pay whatever i put on the sign, it says i dont, so i dont know if it's a compatibility problem.

I'm using Ultimate_Economy 1.2.5 as my Vault economy plugin
Minecraft Server is 1.14.2
3.4.4 signshop

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.