wangkanai / wangkanai Goto Github PK

In order to increase the coverage of the unit test on move devices. Their should database collection of most commonly known user agents with following separation.

• Device
• Browser
• Engine
• Platform

When user agent is null, the application not work.

public AccountsController(ApiDbContext dbContext, IDetection detection)
{
    _dbContext = dbContext;
    _detection = detection;
}

{System.NullReferenceException: Object reference not set to an instance of an object.
   at Wangkanai.Detection.Collections.InternetExplorer..ctor(String agent)
   at Wangkanai.Detection.BrowserResolver.GetBrowser()
   at Wangkanai.Detection.BrowserResolver..ctor(IUserAgentService service)
   at lambda_method(Closure , ServiceProvider )
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.Internal.ActivatorUtilities.GetService(IServiceProvider sp, Type type, Type requiredBy, Boolean isDefaultParameterRequired)
   at lambda_method(Closure , IServiceProvider , Object[] )
   at Microsoft.AspNetCore.Mvc.Controllers.ControllerActivatorProvider.<>c__DisplayClass4_0.<CreateActivator>b__0(ControllerContext controllerContext)
   at Microsoft.AspNetCore.Mvc.Controllers.ControllerFactoryProvider.<>c__DisplayClass5_0.<CreateControllerFactory>g__CreateController|0(ControllerContext controllerContext)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeInnerFilterAsync>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeNextExceptionFilterAsync>d__23.MoveNext()}

Describe the bug

The CookieManager is resolving DeviceType as Desktop Only.

public DeviceType Device => _options.Default(Get());
public DeviceType Get()
{
    var value = _context.Request.Cookies[ResponsiveContextKey];
    DeviceType result;
    Console.Write(value);
    Enum.TryParse<DeviceType>(value, out result);

    return result;
}

Search engine bot are getting complicated to track and it would be good idea to develop this module.

To helper with use the detection service in render view. TagHelper is easy to make this happen.

<device include="mobile">
    <h3>Detection on Home give mobile result</h3>
</device>
<device exclude="mobile">
    <h3>Detection on Home give anything not mobile as the result</h3>
</device>

Opening in mobile will render the following

<h3>Detection on Home give mobile result</h3>

Opening on tablet or desktop will render the following

<h3>Detection on Home give anything not mobile as the result</h3>

Describe the bug

Device type showing up as "Desktop" on an Amazon Fire tablet

This is to track the progress of developing the Engine Resolver module in Detection Service.

Will updade KoreBuild to following ASP.NET core pattern #30

Hi.
Can you please update the specific nuget packges to version beta 10.
in Wangkanai.Detection.Crawler - beta 9 there is an issue with user agent Mozilla/5.0 (compatible; MJ12bot/v1.4.8; http://mj12bot.com/) which got fixes in beta 10.
Can you ship this update as well?

The global will come along with the global reference. This resolver is single resolver that would get all results in this library.

hello
i test your service with many of user agents , but service just detect the Device , not any other ,like platform .

i added services.AddDetection(); in startup.

The idea from as modular design come into good use when our project has only implemented the DeviceResolver. So we will refactor the main client service into the core of the library and add the individual resolver to the service. This design is like what EntityFrameworkCore has implemented with SqlServer, InMemory, and Sqlite.

• Nuget

PM> install-package Wangkanai.Detection.Device 
PM> install-package Wangkanai.Detection.Browser 
PM> install-package Wangkanai.Detection.Engine
PM> install-package Wangkanai.Detection.Platform

• project,json

{
  "dependencies": {
    "Wangkanai.Detection.Device": "1.0.0-*",
    "Wangkanai.Detection.Browser": "1.0.0-*",   // feature waiting for implementation
    "Wangkanai.Detection.Engine": "1.0.0-*",    // feature waiting for implementation
    "Wangkanai.Detection.Platform": "1.0.0-*",  // feature waiting for implementation
  }
}

• Configuring
  Configuring the startup.cs the adding the Detection Service in the ConfigureServices method. The extension will only show up if the package has been loaded into the project.

public void ConfigureServices(IServiceCollection services)
{
    // Add detection services.
    services.AddDetection()
        .AddDevice()    // if load the `Wangkanai.Detection.Device` nuget
        .AddBrowser()   // if load the `Wangkanai.Detection.Browser` nuget
        .AddEngine()    // if load the `Wangkanai.Detection.Engine` nuget
        .AddPlatform(); // if load the `Wangkanai.Detection.Platform` nuget

    // Add framework services.
    services.AddMvc();
}

Nice project!

Just a question - why are all the releases BETA versions.

Do you plan to release a non-beta version that can be easily searched in nuget packages without "include prerelease" being checked?

Is your feature request related to a problem? Please describe.

app.UseResponsive(new ResponsiveOptions {
    TabletDefault = DeviceType.Desktop
});

Describe the solution you'd like

Option 1

app.UseResponsive(options => {
    options.MapView(
        target: DeviceType.Tablet,
        prefer: DeviceType.Desktop);
});

Options 2

app.UseResponsive(options => {
    options.DefaultTablet(DeviceType.Tablet);
    options.DefaultMobile(DeviceType.Mobile);
    options.DefaultDesktop(DeviceType.Desktop);
});

I would like comment of the community

文件后缀名本来应该是Startup.cs，错写成了css了

I think this is similar to #83 but there was no detail of the resolution there.

I am trying to use Detection in Middleware which gets files from data and writes them to the Response. Detection is being used to correctly generate the Content-Disposition header to get it right for different browsers/platforms.

My middleware is:
`public class ImageHandlerMiddleware
{
private readonly RequestDelegate _next;
private readonly IMediaService _mediaService;
private readonly IBrowserResolver _browserResolver;
private readonly IPlatformResolver _platformResolver;
private readonly IImageProcessorService _imageProcessor;

public ImageHandlerMiddleware(
    RequestDelegate next
    , IMediaService mediaService
    , IBrowserResolver browserResolver
    , IPlatformResolver platformResolver
    , IImageProcessorService imageProcessor
  )
{
  _next = next;
  _mediaService = mediaService;
  _browserResolver = browserResolver;
  _platformResolver = platformResolver;
  _imageProcessor = imageProcessor;
}

public async Task Invoke( HttpContext context )
{
  var pathSegments = context.Request.Path.ToSegments();

  var width = context.Request.Query[ "w" ].FirstOrDefault()?.ToInt32();
  var height = context.Request.Query[ "h" ].FirstOrDefault()?.ToInt32();

  var media = await _mediaService.GetMediaAsync( pathSegments.Last() );

  if ( media != null )
  {
    if ( width != null || height != null )
    {
      media.FileData = _imageProcessor.Resize( media.FileData, width, height );
    }
  }
  else
  {

    // TODO: get standard missing image graphic
  }

        context.Response.Clear();
        context.Response.ContentType = media.MimeType;
        context.Response.Headers.Add( HeaderNames.CacheControl, "no-store,no-cache" );
        context.Response.Headers.Add( HeaderNames.Pragma, "no-cache" );
        context.Response.Headers.Add(
            HeaderNames.ContentDisposition,
            media.FileName.ToInlineHeader(
                _browserResolver, _platformResolver, media.FileExtension
              )
          );
        await context.Response.Body.WriteAsync( media.FileData, 0, media.FileData.Length );
}

}`

This is being mapped using:

app.MapWhen( context => context.Request.Path.StartsWithSegments( "/image" ), imageApp => { imageApp.UseMiddleware<ImageHandlerMiddleware>(); } );

The full error message is:

Stopped program because of exception System.ArgumentNullException: Value cannot be null.
Parameter name: Context
at Wangkanai.Detection.UserAgentService.CreateUserAgent(HttpContext context)
at Wangkanai.Detection.UserAgentService..ctor(IServiceProvider services)
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(IServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitTransient(TransientCallSite transientCallSite, ServiceProviderEngineScope scope) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(IServiceCallSite callSite, TArgument argument) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitTransient(TransientCallSite transientCallSite, ServiceProviderEngineScope scope) at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(IServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.b__0(ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
at Microsoft.Extensions.Internal.ActivatorUtilities.ConstructorMatcher.CreateInstance(IServiceProvider provider)
at Microsoft.Extensions.Internal.ActivatorUtilities.CreateInstance(IServiceProvider provider, Type instanceType, Object[] parameters)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass4_0.b__0(RequestDelegate next)
at Microsoft.AspNetCore.Builder.Internal.ApplicationBuilder.Build()
at Microsoft.AspNetCore.Builder.MapWhenExtensions.MapWhen(IApplicationBuilder app, Func2 predicate, Action1 configuration)
at D*****.Module.Core.Middleware.ImageHandlerMiddlewareExtensions.UseImageHandler(IApplicationBuilder app) in D:_Websites\D*****\D*****_core\D*****\src\Modules\D*****.Module.Core\Middleware\ImageHandlerMiddlewareExtensions.cs:line 17
at D*****.Module.Core.ModuleInitializer.Configure(IApplicationBuilder app, IHostingEnvironment env) in D:_Websites\D*****\D*****_core\D*****\src\Modules\D*****.Module.Core\ModuleInitializer.cs:line 31
at D*****.WebHost.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env) in D:_Websites\D*****\D*****_core\D*****\src\D*****.WebHost\Startup.cs:line 239
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
at Microsoft.AspNetCore.Hosting.Internal.WebHost.StartAsync(CancellationToken cancellationToken)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token, String shutdownMessage)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)
at D*****.WebHost.Program.Main(String[] args) in D:_Websites\D*****\D*****_core\D*****\src\D*****.WebHost\Program.cs:line 22

I have tried the FixDetectionMiddleware on suggested in #73 but that hasn't fixed the issue.

Any further assistance would be welcome

Cheers
Greg

System.ArgumentException: Version string portion was too short or too long.
Parameter name: input
at System.Version.ParseVersion(ReadOnlySpan`1 input, Boolean throwOnFailure)
at System.Version.Parse(String input)
at System.Version..ctor(String version)
at Wangkanai.Detection.Collections.Safari..ctor(String agent)
at Wangkanai.Detection.BrowserResolver.GetBrowser()
at Wangkanai.Detection.BrowserResolver..ctor(IUserAgentService service)

User Agent

Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

In order to add single service to the web app, the current AddDetection() will be change to AddDetectionCore() and then AddDetection() will a new point to all if all service is required. This is due to that this library features and functions will expand to beyond what was originally planned out.

Adding extensible to existing usage scenario is a key design. So I would like to propose a concept of extending the HttpRequest for developer to access the Browser, Device, Platform, Engine directly. This extension then retrieve the instance from the BrowserService.

var browser = HttpContext.Request.Browser();
var platform = HttpContext.Request.Platform();
var device = HttpContext.Request.Device();
var engine = HttpContext.Request.Engine();

I would like to hear the community regarding this concept.

This would allow quick access to the Detection in any client request

I am opening this issue for convenience.

Related to (#26)

It might be helpful to have method GetVersion().

Possible implementation:

public string GetVersion(Func<Version, string> format)
{
    return format(this);
}

and then used:

var version = new Version("1", "1");
var versionStrings = version.GetVersion(v => $"{v.Major}.{v.Minor}");

Console.WriteLine(versionStrings); //output: 1.1

or

var version = new Version("1", "1");
var format = "{0}.{1}"
var versionStrings = version.GetVersion(v => string.Format(format, v.Major, v.Minor));

Console.WriteLine(versionStrings); //output: 1.1

User Agent

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

The base library should be clean and only have shared asset that would be use for other libraries. If other resolver don’t implement it, therefore they should move out the base and keep it as a true core.

refer to 5f24799

Remove after implementing to Browser, Platform, and Engine.

Hi,

how is it possible to add IDetection to the Razor PageModel?
When I put it the e.g. IndexModel I get an error:

InvalidOperationException: Unable to resolve service for type 'Wangkanai.Detection.IDetection' while attempting to activate 'XXXXX.App.Pages.IndexModel'.

public class IndexModel : PageModel
{
        private readonly IDetection _detection;
       private AppConfiguration _appConfig;

 public IndexModel(IOptions<AppConfiguration> appConfig, IDetection detection)
        {
            _appConfig = appConfig.Value;
            _detection = detection;
     }
      public async Task OnGetAsync(){
      ...
     }
}

In order cover all market of client detection is impossible. Therefore, we would need cut off threshold that should be consider in our detection list. the mark is above 1% market share.

Having one single package that bring in the all sub modules of Device, Browser, Platform, and Engine a good idea and was the original concept of this library when its started out with just Device Resolver. In the finding the resolving browser is not a simple issue and the detection service need to do a lot things;

1. Resolve that type of device is the client
2. Resolve what Browser is the client (including Name, Maker, Version)
3. Resolve what Engine is the client
4. Resove what Platform is the client (Windows, Mac, Linux)

All this is not simple task to take. Therefore, this library would take a lot time to get right. Helping hand would be great. Anybody would like to contribute would be much appreciated and welcome.

Some unusual that is cause for tablet view not getting return to the client.

I would like to Thank you the following for helping to contributing the unit tests.

@vovikdrg @KostaVlev

I am getting errors with activating Objects.
I've pushed update to azure to record headers as soon as I have more info, I will provide it.

An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Detection (ReflectionActivator), Services = [Wangkanai.Detection.IDetection], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BrowserResolver (ReflectionActivator), Services = [Wangkanai.Detection.IBrowserResolver], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = OwnedByLifetimeScope ---> An exception was thrown while invoking the constructor 'Void .ctor(Wangkanai.Detection.IUserAgentService)' on type 'BrowserResolver'. ---> Object reference not set to an instance of an object. (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BrowserResolver (ReflectionActivator), Services = [Wangkanai.Detection.IBrowserResolver], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = OwnedByLifetimeScope ---> An exception was thrown while invoking the constructor 'Void .ctor(Wangkanai.Detection.IUserAgentService)' on type 'BrowserResolver'. ---> Object reference not set to an instance of an object. (See inner exception for details.) (See inner exception for details.) An exception was thrown while invoking the constructor 'Void .ctor(Wangkanai.Detection.IUserAgentService)' on type 'BrowserResolver'. ---> Object reference not set to an instance of an object. (See inner exception for details.) Object reference not set to an instance of an object.

Autofac.Core.DependencyResolutionException:
at Autofac.Core.Resolving.InstanceLookup.Activate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.InstanceLookup.Execute (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.ResolveOperation.Execute (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.ResolutionExtensions.TryResolveService (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.ResolutionExtensions.ResolveOptionalService (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Extensions.DependencyInjection.AutofacServiceProvider.GetService (Autofac.Extensions.DependencyInjection, Version=4.3.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.GetService (Microsoft.Extensions.DependencyInjection.Abstractions, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at lambda_method (Anonymously Hosted DynamicMethods Assembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null)
at Microsoft.AspNetCore.Mvc.Controllers.ControllerFactoryProvider+<>c__DisplayClass5_0.g__CreateController|0 (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker+d__13.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+d__23.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+d__18.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+d__16.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Routing.EndpointMiddleware+d__3.MoveNext (Microsoft.AspNetCore.Routing, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware+d__6.MoveNext (Microsoft.AspNetCore.Routing, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Flymark.Online.Web.Startup+<>c+<b__9_4>d.MoveNext (Flymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\Source\Web\Startup.csFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 346)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at WebMarkupMin.AspNetCore2.WebMarkupMinMiddleware+d__5.MoveNext (WebMarkupMin.AspNetCore2, Version=2.5.0.0, Culture=neutral, PublicKeyToken=99472178d266584b)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware+d__5.MoveNext (Microsoft.AspNetCore.Localization, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Flymark.Online.Web.Utility.Middleware.DomainMiddleware+d__3.MoveNext (Flymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\Source\Web\Utility\Middleware\DomainMiddleware.csFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 42)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware+d__6.MoveNext (Microsoft.AspNetCore.Authentication, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Flymark.Online.Web.Utility.Middleware.FlymarkExceptionMiddleware+d__3.MoveNext (Flymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\Source\Web\Utility\Middleware\FlymarkExceptionMiddleware.csFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 31)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Flymark.Online.Web.Utility.Middleware.FlymarkExceptionMiddleware+d__3.MoveNext (Flymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=nullFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: D:\a\1\s\Source\Web\Utility\Middleware\FlymarkExceptionMiddleware.csFlymark.Online.Web, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null: 42)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Anemonis.AspNetCore.RequestDecompression.RequestDecompressionMiddleware+d__3.MoveNext (Anemonis.AspNetCore.RequestDecompression, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions+<>c__DisplayClass5_1+<b__1>d.MoveNext (Microsoft.AspNetCore.Http.Abstractions, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware+d__7.MoveNext (Microsoft.AspNetCore.StaticFiles, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089)
at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware+d__6.MoveNext (Microsoft.AspNetCore.Diagnostics, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
Inner exception Autofac.Core.DependencyResolutionException handled at Autofac.Core.Resolving.InstanceLookup.Activate:
at Autofac.Core.Resolving.InstanceLookup.Activate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.InstanceLookup.Execute (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Activators.Reflection.ReflectionActivator.ActivateInstance (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.InstanceLookup.Activate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
Inner exception Autofac.Core.DependencyResolutionException handled at Autofac.Core.Resolving.InstanceLookup.Activate:
at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Activators.Reflection.ReflectionActivator.ActivateInstance (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
at Autofac.Core.Resolving.InstanceLookup.Activate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)
Inner exception System.NullReferenceException handled at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate:
at Wangkanai.Detection.Collections.InternetExplorer..ctor (Wangkanai.Detection.Browser, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null)
at Wangkanai.Detection.BrowserResolver.GetBrowser (Wangkanai.Detection.Browser, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null)
at Wangkanai.Detection.BrowserResolver..ctor (Wangkanai.Detection.Browser, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null)
at lambda_method (Anonymously Hosted DynamicMethods Assembly, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null)
at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate (Autofac, Version=4.8.1.0, Culture=neutral, PublicKeyToken=17863af14b0044da)

The list of device prefixes and keywords should maintain separately from the resolver for easy maintainance and future updates.

Ref #14

@wangkanai Am trying to use wangkanai/Detection in .net core 2.0 and followed all steps mentioned on [https://github.com/wangkanai/Detection](this link). but am getting exception and unable to start my project. any help would be appreciated. here am attachinh browser screenshot.

I use beta-8 version, must of my site traffic is mobile, sometime this exception throw.

System.ArgumentOutOfRangeException: Length cannot be less than zero. Parameter name: length at System.String.Substring(Int32 startIndex, Int32 length) at Wangkanai.Detection.CrawlerResolver.GetCrawler() at Wangkanai.Detection.CrawlerResolver..ctor(IUserAgentService service) at lambda_method(Closure , ServiceProviderEngineScope ) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType) at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.GetService(IServiceProvider sp, Type type, Type requiredBy, Boolean isDefaultParameterRequired)

deviceService is good but other parts their property is null
I haven't tested _engineService but the other 2 parts their properties are null

In order to have a clear responsibility service class and reduce to performance overview from unused feature of the parser. Then add what is only needed in your web application. I would like to propose having AddPlatform and AddEngine to the BrowserBuilder.

public void ConfigureServices(IServiceCollection services)
{
    services.AddBrowser()
        .AddPlatform()
        .AddEngine();
    // Add framework services.
    services.AddMvc();
}

I would to like to hear your idea on this concept idea.

Hi,
Thanks for this awesome library!
Looking at the Facebook explanation:
https://developers.facebook.com/docs/sharing/webmasters/crawler
It seems that not all of the crawlers are covered here.
Also there's a WhatsApp crawler that is named WhatsApp...
Is there a way to add strings to the crawler collection somehow? configuration file? options class?

The propose is simply the initial configuration and make bias default convention add you user would like to add the responsive features.

public void ConfigureServices(IServiceCollection services)
{
    // Add responsive services.
    services.AddResponsive();

    // Add framework services.
    services.AddMvc();
}

But if you would like to specify what you view location you would like to add to responsive by going to the core.

public void ConfigureServices(IServiceCollection services)
{
    // Add responsive services.
    services.AddResponsiveCore()
                .AddViewSuffix()
                .AddViewSubfolder();

    // Add framework services.
    services.AddMvc();
}

Originally you would need to specify which view location you would like to add to Responsive.

public void ConfigureServices(IServiceCollection services)
{
    // Add responsive services.
    services.AddResponsive()
                .AddViewSuffix()
                .AddViewSubfolder();

    // Add framework services.
    services.AddMvc();
}

It would be great to have the Responsive Middleware working for Razor Pages too.

This is to track the progress of the development of Platform Resolver in Detection Service.

Hello,

There are a problem with versioning in Nuget. If you release 2.0.0-beta12, nuget not recognize as higer version because nuget order of semver component are alphanumeric.

If you have 2.0.0-beta-02, then 2.0.0-beta-12 is more recent, but 2.0.0-beta-2 not function properly.

Now, you may change all packages to 2.0.1-beta-01 or 2.0.1-beta01 to correct packages.

Thanks!

Create shared library for user agent tests with collection with identifier of what is that user agent client is.

example:

• Device (Type)
• Browser (Type, Name, Maker, Version)
• Platform (Type, Name, Maker, Version)
• Engine (Type, Name, Maker, Version)

Implement IComparable on Wangkanai.Detection.Version to compare with System.Version & Wangkanai.Detection.Version.

Hi I'm trying to run your responsive demo, but it doesn't seem to be detecting the device?

Haven't changed any code, just built and run

This is nice concept for Detection know the current user a return user. This would required cookie implementation and while this whole different concept from our normal Resolver.

Browser resolver should be implemented in beta6

• browser type as brand
• browser version implementing iversion

Hi, I am using your library in ASP.NET Core MVC application. When app is open on Galaxy Tab A 2016 in firefox, device is recognized like tablet and that is OK. But when app is open in chrome or in built in browser it's recognized like desktop. Do you have some advice for that situation? Here is code example:

public class AccountController : BaseController
{
    private readonly IDevice deviceResolver;

    public AccountController(IDeviceResolver deviceResolver)
    {
        this.deviceResolver = deviceResolver.Device;
    }

     public ActionResult Login()
     {
         if (deviceResolver.Type == DeviceType.Desktop)
         {
              //some logic
         }
         else
         {
             //some logic
         }
     }
}

I have a NullReferenceException error when I inject IBrowserResolver into a Middleware. Not on all queries.

public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
    app.UseDeveloperExceptionPage();
    app.UseMiddleware<SimpleMiddleware>();
}

internal class SimpleMiddleware
{
    private readonly RequestDelegate _next;

    public SimpleMiddleware(RequestDelegate next)
    {
        _next = next;
    }

    public Task InvokeAsync(HttpContext context, IBrowserResolver browserResolver)
    {
        return _next(context);
    }
}

Exception:
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1] An unhandled exception has occurred while executing the request. System.NullReferenceException: Object reference not set to an instance of an object. at Wangkanai.Detection.Collections.InternetExplorer..ctor(String agent) at Wangkanai.Detection.BrowserResolver.GetBrowser() at Wangkanai.Detection.BrowserResolver..ctor(IUserAgentService service) at lambda_method(Closure , ServiceProviderEngineScope ) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope) at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType) at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.GetService(IServiceProvider sp, Type type, Type middleware) at lambda_method(Closure , Object , HttpContext , IServiceProvider ) at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass4_1.<UseMiddleware>b__2(HttpContext context) at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

A common interface for client resolver that have manufacturer details and the details of the product version. These that implement this interface would be Browser, Platform, & Engine. While Device is generic to category of the client access device, any manufacturer options to target that device category.