wall-brew-co / brew-bot Goto Github PK

View Code? Open in Web Editor NEW

10.0 3.0 4.0 2.36 MB

A quick, dirty way to get randomized beer recipes

Home Page: https://brewbot.wallbrew.com/

License: MIT License

Clojure 97.07% Makefile 2.93%

beer-recipes beer brewing clojure-library clojurescript-library randomized-beer-recipes

brew-bot's People

Contributors

Stargazers

Watchers

Forkers

dareknotderek kix lambduhh

brew-bot's Issues

Replace with appropriate checks (e.g. spell checking).

Line: 27
https://github.com/Wall-Brew-Co/brew-bot/blob/54bd92c72a1c152f9b6def159fb6edb8b8d63d48//.git/hooks/sendemail-validate.sample#L24-L34

Add tags for flavors, beer styles

Is your feature request related to a problem? Please describe.
Given the prevalence of meta-information in beer recipes, maps are more useful than a vector for tags.

Describe the solution you'd like
Replacing the tags vector with a map, adding info around common styles/imparted flavors

Describe alternatives you've considered
Using the weights learned to infer the same.

Additional context
Add any other context or screenshots about the feature request here.

WB-23: Migrate brew-bot to use common-beer-format types

When a user generates a recipe, they should be able to re-generate with the same settings

Is your feature request related to a problem? Please describe.
It's frustrating to tweak a recipe's parameters, and want to roll several recipes with the same settings

Describe the solution you'd like
A button on the recipe display page that re-rolls a recipe

Replace with appropriate checks for this patch

(e.g. checkpatch.pl).

Line: 35
https://github.com/Wall-Brew-Co/brew-bot/blob/54bd92c72a1c152f9b6def159fb6edb8b8d63d48//.git/hooks/sendemail-validate.sample#L32-L42

[WB-35]: Install deployment Github action (brew-bot)

Expand brew-bot ingredients

Is your feature request related to a problem? Please describe.
Currently, brew-bot uses an EDN-like notation for recipe ingredients, but it is incomplete w.r.t. all possible brewing materials.

Describe the solution you'd like
Expands the collections of hops, grains, extracts, and yeasts to be representative of more complete catalogs such as those in BeerSmith

PhantomJS has been discontinued, but the tests do rely on it

Describe the bug
As the official sources say, PhantomJS is archived since Mar 2018.

To Reproduce
Just try to install PhantomJs with any deprecation-aware package manager such as Homebrew.

Expected behavior
No changes in behaviour expected

Desktop (please complete the following information):

OS: macOS
Browser PhantomJS/Chrome/Chromium
Version: any

Replace with appropriate checks for the whole series

(e.g. quick build, coding style checks, etc.).

Line: 41
https://github.com/Wall-Brew-Co/brew-bot/blob/54bd92c72a1c152f9b6def159fb6edb8b8d63d48//.git/hooks/sendemail-validate.sample#L38-L48

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

chore(deps): update actions/checkout action to v4.1.6
fix(deps): update dependency com.wallbrew:common-beer-data to v1.5.0
fix(deps): update dependency com.wallbrew:common-beer-format to v2.3.0
Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/cljdoc_test.yml

actions/checkout v4.1.4

actions/cache v4

cljdoc/cljdoc-check-action v0.0.3

.github/workflows/clojure.yml

actions/checkout v4.1.4

actions/cache v4

.github/workflows/clojurescript.yml

actions/checkout v4.1.4

actions/cache v4

actions/cache v4

.github/workflows/contributors.yml

wow-actions/contributors-list v1

.github/workflows/deploy_to_clojars.yml

actions/checkout v4.1.4

actions/cache v4

hole19/git-tag-action v1.0

.github/workflows/format.yml

actions/checkout v4.1.4

just-sultanov/setup-cljstyle v1

stefanzweifel/git-auto-commit-action v5.0.1

.github/workflows/greetings.yml

actions/first-interaction v1

.github/workflows/label.yml

actions/labeler v5

.github/workflows/lint.yml

actions/checkout v4.1.4

reviewdog/action-misspell v1

actions/checkout v4.1.4

nnichols/clojure-lint-action v2

actions/checkout v4.1.4

.github/workflows/scanner.yml

actions/checkout v4.1.4

clj-holmes/clj-holmes-action 53daa4da4ff495cccf791e4ba4222a8317ddae9e

github/codeql-action v3

.github/workflows/sync_labels.yml

actions/checkout v4.1.4

micnncim/action-label-syncer v1

.github/workflows/todo.yml

actions/checkout v4.1.4

leiningen

project.clj

cljx-sampling:cljx-sampling 0.1.0

com.wallbrew:brewtility 2.0.1

com.wallbrew:common-beer-data 1.2.0

com.wallbrew:common-beer-format 2.1.0

nnichols:nnichols 1.1.0

org.clojure:clojure 1.11.3

org.clojure:clojurescript 1.11.132

doo:doo 0.1.11

com.github.clj-kondo:lein-clj-kondo 2024.05.24

com.wallbrew:lein-sealog 1.6.0

lein-cljsbuild:lein-cljsbuild 1.1.8

lein-project-version:lein-project-version 0.1.0

mvxcvi:cljstyle 0.16.630

ns-sort:ns-sort 1.0.3

lein-doo:lein-doo 0.1.11

maven

pom.xml

cljx-sampling:cljx-sampling 0.1.0

com.wallbrew:brewtility 2.0.1

com.wallbrew:common-beer-data 1.2.0

com.wallbrew:common-beer-format 2.1.0

nnichols:nnichols 1.1.0

org.clojure:clojure 1.11.3

org.clojure:clojurescript 1.11.132

doo:doo 0.1.11

npm

package.json

karma ^6.3.2

karma-chrome-launcher ^3.0.0

karma-cljs-test ^0.1.0

karma-firefox-launcher ^2.0.0

minimist >=1.2.6

Check this box to trigger a request for Renovate to run again on this repository

[WB-35]: Install deployment Github action (brew-bot)

Migrate recipe generation and calculations fns to .cljc

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
Currently, all code is bundled as .cljs files, which is great for working on the UI; however, it locks the code in somewhat. If this code was migrated to .cljc, the core functionality of brew-bot could be deployed to clojars for others to use while still making it accessible to the UI.

Describe alternatives you've considered
The alternative is creating a separate repository, deploying that, and including it as a dependency here; however, since the UI is tightly coupled to that code, it doesn't make much sense.

Additional context
This is a nice-to-have that may lead into config hell.