Giter Club home page Giter Club logo

react-component's People

Contributors

wabbas0 avatar

Watchers

 avatar

react-component's Issues

Fix colors

Colors in photoshop could be picked by color picker, but this is not the reason in some cases.

E.g. we have a folder trenner/passive where the opacity of the folder is set to 7%, but each layer of border has #ffffff color. So listItems's border color should be rgba($c-white, .07).

The same situation is with text color. There is a folder labels with 60% of opacity.

Use .map loop for the list

Please use this structure for the List and ListItem components:

<List>
    {list.map((item, key) => (
        <ListItem textLabel={item.label} icon={item.icon}/>
    )}
</List>

So you shoud prepare js object, store it somewhere:

export default [
    {
        label: "Wassermesstechnik",
        icon: "/path/to/icon/"
    }
]

and load it separately.

Use scss not sass

This is because we already have a system where everything is already configured.
I understend your love to pythonic syntax (btw, so do I), but not for this project.

File and folder structure

  1. All the js files with JSX code should have .jsx extention.
  2. All the functional components should be in one CDashboard.jsx file, but main file where the class of the components exists should be Dashboard.jsx not MainDashBoard.js.

Please make the following file/folder structure:

src/scripts/components/
                       Dashboard/
                                 Dashboard.jsx  // here is main Dashboard code
                                 c/
                                   CDashboard.jsx // here are all functional components
                                   dashboard.scss // sass classes for functional components

Hover improvement

Sorry, but psd does not have hover effect shown. I will explain here:

ListItem's main tag should be <a>. And it should be stretched horizontally. When hovering it changes background (let it be rgba($c-white, .5)), like this:
dashboard-hover

svg styles

There are svg styles defined multiple times. Please clear unused code.

Destructurize props in a function

Like this:

export const ListItem = ({icon, textLabel}) => {
  return (
      <div className={styles.listItem}>
        <Icon svgIcon={icon}/>
        <h3>{textLabel}</h3>
      </div>
  );
}

Dimentions / 2

Sorry, forgot to mention that psd is prepared for retina display, so all the dimentions should be divided by 2.

Don't use require

const styles =  require('./dashboard.sass')

should be

import styles from './dashboard.sass';

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.