Comments (2)
We've one call to witness_scalar in each of cert.rs, musig.rs, sign.rs, and vrf.rs. Yet, the VRF one uses the result a couple times, which prevents encapsulation outside these signing methods.
We should probably wait for const generics to stabalize, and for smallvec to adopt const generics, so that we can do
trait SigningTranscript {
...
fn witness_scalars<const N: usize>(
&self,
label: &'static [u8],
nonce_seeds: &[&[u8]],
) -> [Scalar; N]
{
let bytes = &mut [0u8; 64*N];
self.witness_bytes(label, bytes, nonce_seeds);
bytes.chunks(64)
.map( |b| Scalar::from_bytes_mod_order_wide(array_ref![&b,0,64]) )
.collect::<SmallVec::<[Scalar; N]>>()
.into_inner().unwrap()
}
}
from schnorrkel.
I'll close this but there are DJB's comments cited in https://minerva.crocs.fi.muni.cz/ which sound interesting: We do mod the group order more than an ed25519 implementation, but we're doing so with extra wid scalaars
from schnorrkel.
Related Issues (20)
- Version 0.9.2 breaks semver HOT 6
- `getrandom` feature should enable `rand_core/getrandom` HOT 9
- PublicKey incompatible with serde_json HOT 5
- Implement Schnorr half aggregation HOT 1
- Keypair::vrf_sign ignores (partially) passed RNG HOT 6
- ThinVRF HOT 3
- Remove serde? HOT 4
- Is soft public key derive ready for production usage? HOT 3
- failed to verify signatures generated by `polkadot-js` HOT 10
- What Is The Signing Context For? HOT 4
- How to use musig? HOT 2
- Adopt the new secret key interface HOT 1
- Verify schnorrkel vrf on EVM HOT 1
- Build fails: `rand_core` doesn't have feature `nightly` HOT 2
- Add rand back HOT 2
- The code compile Error from_bits not found HOT 3
- Update from curve25519-dalek 4.0.0-rc2 to 4.0.0 and release 0.11 HOT 3
- Fix aead
- v0.11 doesn't compile in no-std mode HOT 2
- Broken `no_std` because of `rand/std_rng` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from schnorrkel.