PublicKey incompatible with serde_json about schnorrkel HOT 5 CLOSED

Can you explain what fails in https://github.com/w3f/schnorrkel/blob/master/src/serdey.rs please? A priori I'd expect visit_seq should fail when invoked upon a simple byte array because that's what visit_bytes does, no?

Appears ed25519-dalek used serde_bytes without using Bytes anyplace.

from schnorrkel.

I don't understand why the issue was closed...?
There's nothing failing in serdey per se, it's just that not all format specialise sequence of bytes as just bytes, json being one of those...
This poses an issue with the current implementation during deserialization, with the reported error, where a sequence is encountered but serdey doesn't handle it

from schnorrkel.

I just pressed the wrong button due to it being late..

Do we need a serde_bytes feature like ed25519-dalek added? If so, we're basically replaying dalek-cryptography/ed25519-dalek@69eccda yes? I'll accept a PR for that of course.

from schnorrkel.

There's a problem in implementing the deserialization part, namely a BytesBuf becomes somewhat necessary if you want sequence support since Bytes doesn't implement visit_sequence, probably since the size is now known so you'd need to allocate.
I'm probably gonna impl with Bytes and if alloc is provided as feature then use ByteBuf instead

from schnorrkel.

I think a serde_bytes feature flag sounds good, mostly because ed25519-dalek did so.

from schnorrkel.