Comments (3)
I suspect that "undo actions" in dispatch actions for a string
may be a vestige from an older version of the spec for two reasons:
- There is already an "undo actions" list in the form of the "input cancel list"
- It's a map of "cluster" to "action" but "cluster" is never used (i.e. it's used as a simple list, not a map)
- If we clear the "input cancel list" (instead of "undo actions") in "clear the modifier key state" this problem goes away
from webdriver.
@grokys Hello. I'm struggling with the same task as you trying to implement actions handling according to the spec, and I think the spec has a bigger flaw, that confused you and me regarding the input cancel list
, and considering you spent your time scrutinizing the spec I'll be grateful for your feedback on my thoughts.
Any key down action
(not only modifiers) dispatched with dispatch tick actions adds a key up action
to input cancel list
, which is global for all input state
, not a particular input source
. However, the only method to remove actions from this list is release actions. I beleive, dispatching a key up action
should remove corresponding actions from input cancel list
, otherwise we end up with a lot of duplicated key up actions
on release actions
. Same goes for pointer up actions
.
Looking at the description of a dispatch actions for a string, we can see that undo actions
hold only modifier keys state for a temporary key input source
, created in element send keys
, and these modifiers are cleared at the end of element send keys
, so I do not agree with you that input cancel list
may be used to clear modifiers state.
Adding to a confusion here: we have a global key state, which combines the state of possibly multiple key input sources, but it's not used during key events processing. Let's assume that we called perform actions
with shift
key down event. After the processing the input state
contains one key input source
with shift
property set to true
. Shouldn't this shift
property be taken into account somehow if we call element send keys
next? No idea...
from webdriver.
Related Issues (20)
- Rational for this key? HOT 2
- Move "Get Title" into "Document" section. HOT 3
- Consider introducing per-Element script execution.
- Consider introducing some kind of interface for resetting a session. HOT 6
- Spec: 12.5.1 Element Click: "pointer up action" is not used HOT 1
- What's a "user prompt"?
- Update commit reference for Selenium atoms (follow-up from issue #1773)
- Safari is unable to get text from components with Shadow DOM HOT 2
- RCS WebdriverInstaller
- webdriver
- Allow uploading folders HOT 1
- Output-only capabilities HOT 1
- setWindowRect should be matched as a capability HOT 7
- Add ability to save autofill data and trigger autofill on form elements HOT 7
- w3c wheel actions sometimes can't perform deltaX,deltaY movement HOT 1
- "Run the post navigation checks" doesn't make sense
- "Create an input source" doesn't add the source to the map HOT 5
- Should the "New Session" command return default values for capabilities that have not specified? HOT 1
- web3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webdriver.