Comments (7)
Matching on our side takes place as:
Note scenarios like window manipulation tests that want to position or resize browser windows. If you would run these tests on desktop it should basically work in nearly all the cases (exception would be Wayland) but on Android it should basically fail.
With matching clients can request that this feature is present to actually run all the tests on that given platform and if it's not supported the session will not be created.
wpt.fyi shows the difference between Firefox on Android and Chrome on Android. For Chrome an assertion only fails without any details that the command actually doesn't work, while for Firefox an unsupported operation is raised.
With matching the capability we would get a clear failure right in New Session
for all browsers.
from webdriver.
Chrome does not do matching for this capability and it is a return-only value: https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/session_commands.cc;l=189;drc=21802bc29a3f1f96a333bc52039dc56764a85524 (it will reject the property as invalid argument if it is in the capabilities request)
from webdriver.
@shs96c @AutomatedTester @titusfortner @jimevans from the Selenium side of view how would you expect a remote end to behave when it doesn't support window manipulation? Should matching the setWindowRect
capability fail if it's value in the requested capabilities is set to true
? Or would you expect all the tests trying to manipulate the window to fail because the requested operation cannot be achieved?
from webdriver.
It likewise is return-only in safaridriver.
(Despite being the OP, I was just doing what the action item from the meeting said; I don't have any particularly strong opinion on whether we should make it possible to match on it.)
from webdriver.
Generally speaking, Selenium expects that capability to be return-only. I donβt know of anyone attempting to match on that capability in the Selenium world.
from webdriver.
Given that matching is not expected should we close the issue? Or should we try to match all known and supported capabilities?
from webdriver.
I've never understood why it was there in the first place. π
My philosophy is that your test should already have all the information it needs to execute a deterministic test, and it shouldn't be toggling the action to take based on the returned capabilities, so it shouldn't need to be something that gets returned, let alone set, but that's my opinion.
That said, if the spec says these need to be matching, do we at least need to change the spec language?
from webdriver.
Related Issues (20)
- Move "Get Title" into "Document" section. HOT 3
- Consider introducing per-Element script execution.
- Consider introducing some kind of interface for resetting a session. HOT 6
- Spec: 12.5.1 Element Click: "pointer up action" is not used HOT 1
- What's a "user prompt"?
- Update commit reference for Selenium atoms (follow-up from issue #1773)
- Safari is unable to get text from components with Shadow DOM HOT 2
- RCS WebdriverInstaller
- webdriver
- Allow uploading folders HOT 1
- Output-only capabilities HOT 1
- Add ability to save autofill data and trigger autofill on form elements HOT 7
- w3c wheel actions sometimes can't perform deltaX,deltaY movement HOT 1
- "Run the post navigation checks" doesn't make sense
- Clearing input cancel list in Element Send Keys HOT 3
- "Create an input source" doesn't add the source to the map HOT 5
- Should the "New Session" command return default values for capabilities that have not specified? HOT 1
- web3
- `Dispatch a pointer down action` has invalid parameters
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webdriver.