vytux-com / vytux_cousins Goto Github PK

app/Gedcomcode/GedcomCodePedi.php was removed from webtrees.

We get now error
Class 'Fisharebest\Webtrees\GedcomCode\GedcomCodePedi' not found …/modules_v4/vytux_cousins/module.php:219

If two sets of siblings in a family are married then the resulting cousins get duplicated as they technically belong to both mothers and fathers families. However the total count should exclude the duplicates.

I get again an error in webtrees 2.0.0

Call to undefined method Fisharebest\Webtrees\Individual::primaryChildFamily() …/modules_v4/vytux_cousins/module.php:159
#0 …/modules_v4/vytux_cousins/module.php(238): Vytux\WebtreesModules\VytuxCousins\VytuxCousinsTabModule->getCousins(Object(Fisharebest\Webtrees\Individual))
#1 …/resources/views/individual-page.phtml(120): Vytux\WebtreesModules\VytuxCousins\VytuxCousinsTabModule->getTabContent(Object(Fisharebest\Webtrees\Individual))
#2 …/app/View.php(186): include('/home/amitys/te...')
#3 …/app/View.php(282): Fisharebest\Webtrees\View->render()
#4 …/app/Helpers/functions.php(203): Fisharebest\Webtrees\View::make('individual-page', Array)
#5 …/app/Http/ViewResponseTrait.php(51): view('individual-page', Array)
#6 …/app/Http/RequestHandlers/IndividualPage.php(171): Fisharebest\Webtrees\Http\RequestHandlers\IndividualPage->viewResponse('individual-page', Array)
#7 …/app/Http/Middleware/WrapHandler.php(83): Fisharebest\Webtrees\Http\RequestHandlers\IndividualPage->handle(Object(Nyholm\Psr7\ServerRequest))
#8 …/vendor/oscarotero/middleland/src/Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\WrapHandler->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher))
#9 …/app/Module/HitCountFooterModule.php(147): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest))
etc.

Only father side cousins are shown in the narrow (<600px) display.
I did a quick fix for myself: line 56 in vytux_cousins.css to display: table-cell; did fix it but the resulting tables are extremely narrow. It would be better if the tables were one below the other.

• Hannu

In version 1.x the cousins were displayed in two columns - left father's family, right mother's family. Needless to say this was much better arranged layout.
Is it possible to apply this in version 2.x?

On the individual's tab Cousins, the links to cousins at the right side, i.e. Mothers's family, point to the individual itself. Other links are OK.

I am particularly interested in finding all second-cousins, that would be very helpful to have.

now I get
Call to undefined method Fisharebest\Webtrees\Individual::getLifeSpan() …/modules_v4/vytux_cousins/resources/views/tab.phtml:25
#0 …/app/View.php(186): include()
#1 …/app/View.php(282): Fisharebest\Webtrees\View->render()
#2 …/app/Helpers/functions.php(203): Fisharebest\Webtrees\View::make('vytux_cousins...', Array)
#3 …/modules_v4/vytux_cousins/module.php(240): view('vytux_cousins...', Array)
#4 …/resources/views/individual-page.phtml(120): Vytux\WebtreesModules\VytuxCousins\VytuxCousinsTabModule->getTabContent(Object(Fisharebest\Webtrees\Individual))
#5 …/app/View.php(186): include('/home/amitys/te...')
#6 …/app/View.php(282): Fisharebest\Webtrees\View->render()
#7 …/app/Helpers/functions.php(203): Fisharebest\Webtrees\View::make('individual-page', Array)
etc.

I am missing the translation of some items.
I use webtrees with german language.
thx Franz

The module is throwing an error when upgrading site to 2.1.0 of webtrees.

this webtrees module is now obsolete: use https://github.com/hartenthaler/hh_extended_family

In your boot() method, you type-hint two variables - $user and $tree.

https://github.com/vytux-com/vytux_cousins/blob/master/module.php#L262

1. You do not use these variables so you do not need to specify them

2. In the latest code, you cannot request the tree like this. Instead, you obtain it as an attribute of the request. $request->getAttribute('tree').

        case 'ru':
            return $this->russianTranslations();

............

/**
 * @return array
 */
protected function russianTranslations() : array
{
    // Note the special characters used in plural and context-sensitive translations.
    return [
        'Cousins' => 'Двоюродные братья и сёстры',
        'A tab showing cousins of an individual.' => 'Вкладка с двоюродными братьями и сёстрами человека.',
        'No family available' => 'Нет доступных семей',
        'Father\'s family (%s)' => 'По отцу (%s)',
        'Mother\'s family (%s)' => 'По матери (%s)',
        '%2$s has %1$d first cousin recorded' . I18N::PLURAL . '%2$s has %1$d first cousins recorded'
            => '%2$s имеет %1$d двоюродного брата или сестру записанным' . I18N::PLURAL . '%2$s имеет %1$d двоюродных братьев или сестёр записанными' . I18N::PLURAL . '%2$s имеет %1$d двоюродных братьев или сестёр записанными',
    ];
}

It would be nice if the module could also display cousins of nonmarried couples

In webtrees 1.7 there were .mo files in language folder.
Could you please describe, say in README.md, how to implement translation into a language without modifying your module.php?

After unzipping the module folder must be renamed to "vytux_cousins" (without the version ending).

I like the vytux cousins module very much, but after webtrees is upgraded to 2.1.0, this module makes mistakes.
Will you update this module? I hope you can come back!
Best wishes