vyshane / rex-weather Goto Github PK

I'm not sure, I was just curious if there is the chance that onDestroyView could have been called but not onDestroy, thus resulting in NPE when manipulating UI (the SwipeRefresh in this case).

Usage of LocationManager/LocationService is not recommended by Google, it is better to use com.google.android.gms.location.LocationServices from GMS library.

When I do not receive GPS location it took long time and fail at the end. It is enough cars location for weather.

Please using WeatherFragment() but there is not WeatherFragment in this module .
what basically it contain the WeatherFragment()

You should add retained fragments (see http://www.androiddesignpatterns.com/2013/04/retaining-objects-across-config-changes.html) or http://developer.android.com/reference/android/content/AsyncTaskLoader.html to retain the REST calls when the activity is restarted on device rotation. Right now, on orientation change, you get an error "sendUserActionEvent() mView == null" and you would notice it much more if you tried it with a bigger dataset than just the current weather.

By the way, because the landscape layout is unusable, you obviously only tested it in portait mode.

Hi @vyshane, it's a very cool demo, but the RxJava API is too old. can you upgrade the API.