Gabled roofs not working in v2.1.1 about blosm HOT 9 OPEN

@ccamara, thank you for submitting the bug.

Mercado Central:
The gabled roof is there, but very low. You can check that in the EDIT mode of Blender. Actions from my side: change how a roof height is calculated if it isn't set in OSM explicitly to make a gabled roof more prominent for that case.

Ayuntamiento de Zaragoza:
It's actually a hipped roof for the building outline with a hole. F4 Maps renders it as a hipped roof. It's very arguable how a gabled (also a gambrel, round and saltbox) roof should look like if a building outline has a hole. I render a flat roof for that case. Actions from my side: no, the addon works as expected.

Basílica de Nuestra Señora del Pilar:
The gabled roof is there (check in the EDIT mode Blender) but hidden by the building part with a hipped roof. The addon supports hipped roofs only for a quadrangle. However the polygon with the hipped roof has more than 4 vertices. I do skip straight angles of a polygon by the checking every angle against some threshold. Seemingly the resulting polygon for that case has more than 4 vertices and the flat roof is rendered for the polygon instead of the hipped one. Actions from my side: change the threshold for a straight angle.

I'll release the new version with the fixes mentioned above as soon as possible.

from blosm.

@ccamara, I sent you the updated version of the addon via e-mail.

I added a GUI import parameter Straight angle threshold. You can get a hipped roof for Basílica de Nuestra Señora del Pilar if Straight angle threshold is equal to 179.6 or less. Use the latest version from the OSM, since I applied Arrange nodes along a straight line in JOSM.

This parameter Straight angle threshold is also important for calculation of the longest side of the building for a gabled roof. If the parameter is very close to 180 degrees, a wrong side could be taken as the longest one if a building outline has straight angles. Another tricky property of the parameter: circular buildings disappear under very low values of the Straight angle threshold.

from blosm.

Thank you for your quick response, @vvoovv !

I tried the new version and unfortunately didn't work (and by didn't work I mean that it's completely broken and could not import anything this time).

This is what I've done so far:

1. Enter blender settings
2. Remove older version by clicking on dialog box
3. Installed new version clicking on install from zip file
4. Imported the same osm file from yesterday
5. Got the first error + nothing is imported
6. Started new file
7. Imported the kremlin sample file
8. Got the second error + nothing is imported

By the way, I didn't understand much the new approach. Since I haven't taken a look at the code nor I am very skilled in python, I am wondering if it wouldn't be easier to have another GUI import parameter with a default roof angle (eg: 30º), just like you already do with default buildings' height when height or levels are not present.

from blosm.

I read the error text you had sent via e-mail. It looks like the old version hasn't been removed.

Please try the following:

• delete all versions of the addon
• restart Blender
• install and use the addon as usual

Please inform if it helped

from blosm.

We solved the problem with the error via e-mail. Somehow the old version of the addon wasn't removed.

I think it's a good idea to set default roof pitch. Can it be applied to other roof shapes besides gabled and hipped ones?

I still think that what F4 Maps renders for Ayuntamiento de Zaragoza is a hipped roof, since it's created by shrinking both outer and inner outlines. That method (also know as Straight Skeleton algorithm) is used to calculated a hipped roof for an arbitrary building outline:


Image source: Wikipedia

from blosm.

You mentioned that you didn't understood much the new approach. Did you mean the parameter Straight angle threshold?

from blosm.

Thanks for your comments, @vvoovv

from your comment I have realized that I made a mistake: when I attached the screenshot I wrote "gabled" and selected the Ayuntamiento's roof, but in fact it is tagged as roof:shape=hipped in osm, which is right (and that's what you were correctly saying). Unfortunately, despite it is well tagged, it is not well displayed in blender. So the problem is not gabled but hipped roofs.

from blosm.

Actually, it was me who changed to roof shape from gabled to hipped one. At the moment the addon can render hipped roof only for a quadrangle. Hipped roofs for an arbitrary building outline is planned.

from blosm.

from blosm.