vvalchev / creative-theme-jekyll-new Goto Github PK

I'm not understanding when/how the minification is happening on the creative.css file - if i change .css, min.css is not updated. What am I missing?

For some reason the titlebar links are not properly generated on github pages.
However, if you compile the project locally, the links would be properly generated.

This is probably related to the hooks.rb file.

Looks like the animations are all stripped on this version when compared to the original.
Just wondering if this was on purpose. I've been trying to apply them to this theme but anything I do does not seem to work.

Apologies if this is not the correct avenue for this topic!

At the very start of creative.scss, we have a list of variables, but in most places from then on, the CSS hash colour codes are used. This makes it less readable and bug-prone. For example:

23:44 $ git grep 17a2b8
assets/css/creative.scss:  --cyan: #17a2b8;
assets/css/creative.scss:  --info: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8 !important;
assets/css/creative.scss:  border-color: #17a2b8 !important;
assets/css/creative.scss:  color: #17a2b8 !important;

Surely those later entries should use var(--cyan) or var(--info)?

Also, secondary isn't used anywhere. The members and timeline sections have prominent background colours, but neither is secondary.

Edit: Also, lots of the variables are unused. Although I see this file is from upstream, so I guess we won't fix it here, feel free to close if so.

Hi, I noticed that the 'title' and some 'meta' tags in the _layouts/base.html file duplicate the tags generated by the jekyll-seo-tag plugin.

The duplicated content in the _layouts/base.html is as follows:

<meta name="description" content="" />
<meta name="author" content="" />
<title>{% assign title_is_not_empty = page.title | is_not_empty %}{% if title_is_not_empty %}{{ page.title }} - {% endif %}{{ site.title }}</title>

If the _config.yml file is configured as follows:

# Site settings
title: Test
description: "description in _config.yml"
repository: vvalchev/creative-theme-jekyll-new
baseurl: "" # the subpath of your site, e.g. /blog/
url: "http://127.0.0.1:4000" # the base hostname & protocol for your site
author: "author in _config.yml"
lang: en_US

# Build settings
safe: true # always trues on github-pages, disables _plugins/
markdown: kramdown
sass:
  indentWidth: 4
  style: compressed
  precision: 10
plugins:
  - jekyll-sitemap
  - jekyll-seo-tag
exclude:
  - Gemfile
  - Gemfile.lock
  - build-in-docker.sh
  - README.md

the head tag will result in the following:

I think we can remove the three duplicated tags in the base.html file. What do you think?

Cheers!

Hi, thanks for this great theme!

It would be great to see an upgrade to the latest Jekyll (4.1.1 at the time of writing).