vtsuperdarn / vtrst3.5 Goto Github PK

Seems as though this doesn't compile on more recent OS installs since the netcdf.h file is missing. Quick stab at trying to get it to work didn't get anywhere.

For some reason, RST3.5 doesn't process fitacf files correctly for the twofsound data from twofsound.1.04 where the channel parameter is changed to '1' or '2' depending upon which frequency is being transmitted.

Below are plots from davitpy that used fitacfs generated at usask with stk, they seem to have the data plotted. Also attached are plots from Dieter's IDL plotting code written using stk libs, which don't seem to have plotted correctly, for completeness.

fred_20161117.sas.pdf
fred_20161117.rkn.pdf
fred_20161117.inv.pdf
fred_20161117.cly.pdf

I tried doing a fresh install of the RST and am encountering persistent crashes when it tries compiling the binary for sim_real.1.0 - anyone else encounter this?

Compiling Binary:/thayerfs/research/superdarn/usr/local/VTRST3.5-develop/codebase/superdarn/src.bin/tk/tool/sim_real.1.0

make clean
rm -f *.o
rm -f version.h
rm -f errstr.h
rm -f hlpstr.h
rm -f sim_real
make
make.version /mnt/thayerfs/superdarn/usr/local/VTRST3.5-develop/codebase/superdarn/src.bin/tk/tool/sim_real.1.0
make.help
cc -fPIC -Wall -O3 -ansi -D_GNU_SOURCE -D_LINUX -D_SVGLIB_ -I/thayerfs/research/superdarn/usr/local/VTRST3.5-develop/include/base -I/thayerfs/research/superdarn/usr/local/VTRST3.5-develop/include/general -I/thayerfs/research/superdarn/usr/local/VTRST3.5-develop/include/superdarn -c sim_real.c  
sim_real.c: In function ‘main’:
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 3 has type ‘int16 \* {aka short int *}’ [-Wformat=]
   fscanf(fitfp,"-861128176  -856238336  166  6423104  6423104  19559904\n",&prm->time.yr,&prm->time.mo,&prm->time.dy,&prm->time.hr,&prm->time.mt,&prm->time.sc);
                ^
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 4 has type ‘int16 \* {aka short int *}’ [-Wformat=]
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 5 has type ‘int16 \* {aka short int *}’ [-Wformat=]
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 6 has type ‘int16 \* {aka short int *}’ [-Wformat=]
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 7 has type ‘int16 \* {aka short int *}’ [-Wformat=]
sim_real.c:258:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 8 has type ‘int16 \* {aka short int *}’ [-Wformat=]
sim_real.c:260:16: warning: format ‘-861128176’ expects argument of type ‘int *’, but argument 5 has type ‘int16 \* {aka short int *}’ [-Wformat=]
   fscanf(fitfp,"-861128176  0.000000  -856238336  0.000000  197  6423104  0.000000  0.000000  0.000000  6423104\n",&cpid,&freq,&prm->bmnum,&noise_lev,&nave,&lagfr,&dt,&smsep,&rngsep,&nrang);
                ^
sim_real.c:450:27: warning: pointer targets in passing argument 4 of ‘IQFwrite’ differ in signedness [-Wpointer-sign]
    IQFwrite(stdout,prm,iq,badtr,samples);
                           ^
In file included from sim_real.c:48:0:
/thayerfs/research/superdarn/usr/local/VTRST3.5-develop/include/superdarn/iqwrite.h:42:5: note: expected ‘unsigned int *’ but argument is of type ‘int *’
 int IQFwrite(FILE *fp,struct RadarParm *prm,
     ^
sim_real.c:258:3: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result]
   fscanf(fitfp,"-861128176  -856238336  166  6423104  6423104  19559904\n",&prm->time.yr,&prm->time.mo,&prm->time.dy,&prm->time.hr,&prm->time.mt,&prm->time.sc);
   ^
sim_real.c:260:3: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result]
   fscanf(fitfp,"-861128176  0.000000  -856238336  0.000000  196  6423104  0.000000  0.000000  0.000000  6423104\n",&cpid,&freq,&prm->bmnum,&noise_lev,&nave,&lagfr,&dt,&smsep,&rngsep,&nrang);
   ^
sim_real.c:370:4: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result]

Even though there isn't a lot of active development going on with this repository, would there be any opposition of mirroring the branch merging schedule of davitpy? It's been quite a while since develop was merged into master. And though the develop branch is set to be the default, it may be good to keep master up-to-date as new users/devs will assume master is the best version.

Got two reports of people having issues with zho and unw data (1 report of issue with sye, sys data) when running something like:

make_grid filename.zho.fitacf > filename.zho.grd

The common issue seems to be that these radars don't set the scan variable to +1 at the beginning of each scan. Instead they set it to -1. This isn't a problem if the -tl option is used as this ignores the scan flag entirely. Below are some notes from Kevin Krieger (with maybe the help of @kkotyk):

Without the -tl flag:
I modified the code to also accept -1 for the beginning of a new scan, and the four radars mentioned below (zho, han, sys, and unw) all fail in a different place. Here are the details:

1. In FitReadRadarScan (line ~205 of fitscan.c) the original code is:
   if (prm->scan==1) flg=1;

Which I modified to:
if (prm->scan==1 || prm->scan ==-1) flg=1;

Which I hoped would just work for the four radars.

2. FitRead is called in the loop (from fitread.c) and it calls DataMapRead on the file

3. Within DataMapRead, DataMapReadBlock is called (dmap.c ~line 1432)

4. Within DataMapReadBlock (dmap.c ~line 1369)
   The function ConvertReadInt is called and fails

5. ConvertReadInt (convert.c ~line 321) it looks like s=read(fp,tmp+o,1); fails with 0 or -1, who knows why...

Will need to get this bug fixed here soon since it's crept up twice in the last week.

Nothing much to work on here other than another place to post (if it wasn't clear in the develop/master README.md files) that this repo has been deprecated in favor of the SuperDARN/rst repo at:

https://github.com/SuperDARN/rst

Please use that repo as no new development will happen on this repo.

Hey @kkotyk, @pasha-ponomarenko ,

Moving this issue you two found when trying to compile the RST onto github here. The error you reported is:

makelib.linux: 23: recipe for target "rfbuf" failed

That's strange as line 23 for makelib.linux is just a mkdir command. Is it really this line that is failing or is there another line? If it is, then either the DSTPATH variable isn't being set or the permissions to the path aren't set correctly.

I first ran into this issue several years ago at VT (~2012) and now again at Dartmouth after making a fresh installation of VTRST3.5 from github. Calling the IDL routine OldFitOpen on a .fit file results in a buffer overflow immediately after it loads oldfitdlm, however if you explicitly use the IDL function and not the DLM then everything works normally. Similarly, using the IDL routine to open a .fit file and then trying to use the DLM to read the file (via OldFitRead) fails with a returned value of -1. Can anyone else replicate this issue?

(for reference I'm running IDL Version 8.4 on Ubuntu 14.04.4 LTS)

If the make.build script is called with superuser privileges and without the BUILD environment variable set then files in /bin and /lib are deleted, trashing the system. The results of this action has been observed on another user's computer.