The authenticode-parser from vthib

authenticode-parser's People

Contributors

Watchers

authenticode-parser's Issues

Panic when parsing some PE files

The parser has started panicking with nightly rustc when file with SHA-256 af3f20a9272489cbef4281c8c86ad42ccfb04ccedd3ada1e8c26939c726a4c8e is scanned.

It looks like std::slice::from_raw_parts is now checking that the pointer it receives is not null. The documentation for this function says:

data must be non-null and aligned even for zero-length slices

Apparently, this wasn't enforced until now.

In line 130 in the snippet below, the signatures pointer passed to from_raw_parts is null when the file is scanned.

authenticode-parser/src/lib.rs

Lines 118 to 130 in d7fb5de

 // Safety: 

 // The signatures field has type `*mut *mut sys::Authenticode`. It is safe to cast 

 // to `*mut Authenticode` because: 

 // - The Authenticode type is a transparent wrapper on a &sys::Authenticode 

 // - The `*mut sys::Authenticode` pointers in the array are guaranteed to be non-null 

 // (checked by auditing the C code). 

 let signatures = this.signatures.cast::<Authenticode>(); 

 // Safety: 

 // - The signatures + count pair is guaranteed by the library to represent an array. 

 // - The lifetime of the slice is tied to the lifetime of self, so the memory cannot be 

 // freed before the slice is dropped. 

 unsafe { std::slice::from_raw_parts(signatures, this.count) }

The following comment doesn't hold true for this particular file:

 // - The `*mut sys::Authenticode` pointers in the array are guaranteed to be non-null 
 //   (checked by auditing the C code).

This may be a bug in the C library, but I think its worth modifying this code to making it more robust.

Recommend Projects

vthib / authenticode-parser Goto Github PK

authenticode-parser's People

Contributors

Watchers

Forkers

authenticode-parser's Issues

Panic when parsing some PE files

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Safety:
	// The signatures field has type `mut mut sys::Authenticode`. It is safe to cast
	// to `*mut Authenticode` because:
	// - The Authenticode type is a transparent wrapper on a &sys::Authenticode
	// - The `*mut sys::Authenticode` pointers in the array are guaranteed to be non-null
	// (checked by auditing the C code).
	let signatures = this.signatures.cast::<Authenticode>();

	// Safety:
	// - The signatures + count pair is guaranteed by the library to represent an array.
	// - The lifetime of the slice is tied to the lifetime of self, so the memory cannot be
	// freed before the slice is dropped.
	unsafe { std::slice::from_raw_parts(signatures, this.count) }