Icon support about vscode-which-key HOT 14 CLOSED

FWIW while y'all don't owe me anything, I'd really appreciate if this was working before the release. I've spent a lot of time picking >600 icons for all the VSpaceCode menus, and having icons for some items but not others in the same menu looks quite weird IMHO (and makes it harder to scan the contents visually with the text "jumping" around, kind of defeating the whole motivation behind those icons).

from vscode-which-key.

That's pretty cool. I implemented the support at f5be86d in the refactoring branch. You can switch to the branch to try it out.

It would be great if you can help us add the icons in VSpaceCode bindings once a new version is released.

from vscode-which-key.

regexes ftw indeed. That awesome, I am finishing up documentation for the new version. Hopefully, I can release it soon especially it has been in the works for a while.

from vscode-which-key.

Thanks for reporting, there are two things happening:

1. Icon in transient menu hasn't been implemented
2. The transient type will be deprecated, and are converted to a separate command internally. The conversion didn't take into account of icon key.

I will implement them before I release the new version of which-key, but I am a little busy atm. Might take a bit more time.

from vscode-which-key.

Will open a PR later today or tomorrow! Just going through them again, as I think there are better options for some of those (e.g. I was mixing up windows and frames 😅)

from vscode-which-key.

Awesome, thank you! FWIW I wanted to try installing the extension on the refactoring branch with vsce package, but that complains:

 ERROR  @types/vscode ^1.54.0 greater than engines.vscode ^1.45.0. Consider upgrade engines.vscode or use an older @types/vscode version

from vscode-which-key.

I updated some packages in that branch. Apparently, I also made the vscode type out of sync. Fixed in 1bc6ad7

from vscode-which-key.

Yay, thanks! I adapted my changes (regexes ftw, see also). Seems to work great so far. I'll wait until the next vscode-which-key release (and perhaps improve the icons a bit more until then) and then open a PR.

from vscode-which-key.

After testing this for a bit, I noticed a couple of icons don't seem to show up:

+Window:

+Text:

+Zoom / *:

But they are defined in my icons branch, e.g.:

https://github.com/The-Compiler/VSpaceCode/blob/0cc4cfe934d42304f58f0aaedcec0c2051b4308c/package.json#L280

and my VS Code seems to know about them, as they get displayed when I enter :$(selection) (abusing VSCodeVim/Vim#6655).

Any idea what's going wrong there? Looks like it's affecting (only?) transient bindings?

from vscode-which-key.

No worries, take your time! 👍

from vscode-which-key.

You could also release now and you specify in the README that icons do not work for transient mode, it's up to you :)

from vscode-which-key.

@The-Compiler, the branch is updated with icon support for transient. It would be great if you can try it out :)

from vscode-which-key.

Looks great now, thank you! 🚀

from vscode-which-key.

v0.9.0 is finally released!! Closed.

@The-Compiler It would be amazing if you can open a pull request for the icon your used for the vspacecode's bindings :)

from vscode-which-key.