Giter Club home page Giter Club logo

Comments (3)

stevenguh avatar stevenguh commented on September 7, 2024

bindings is used to define the whole menu and bindingOverrides is designed to surgically update a few bindings (that's why it has keys). I agree that it could be better/seamless. Any idea?

from vscode-which-key.

TwoClocks avatar TwoClocks commented on September 7, 2024

So, my two cents:
Change all the docs to change any reference to 'keys' to 'key'
Change the code that parses the BindingOverrides to look for either 'key' or 'keys' (stay backwards compatible)

Having never looked at the code, maybe now you can use the same parsing code for both?

from vscode-which-key.

stevenguh avatar stevenguh commented on September 7, 2024

Thanks for the suggestions. There some nuances for the overrides. In hinge sight, it is poorly defined API. Supporting both key and keys may help in this case. I feel like the whole overrides may need to overhaul.

from vscode-which-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.