Giter Club home page Giter Club logo

Comments (5)

stevenguh avatar stevenguh commented on July 3, 2024 1

That sounds good. Would love to get some help on documenting it :) I added documentation tag

from vscode-which-key.

stevenguh avatar stevenguh commented on July 3, 2024

The new window should be running with the new which-key extension. I assume you modified which-key's package.json, and trigger QuickPick menu with the VSpaceCode's config?

The way this works is that VSpaceCode and which-key both have their own default binding config in package.json. When you launch another instance from "Run Extension" in the which-key repo, it installed new which-key extension in the new debug instance. When you trigger SPC in that debug instance it may still using VSpaceCode binding depending on your setting.

If you want to test which-key's default bindings in the package.json, I usually do SPC SPC and type which key and click Which Key: Show Menu in the new debug vscode instance.

from vscode-which-key.

The-Compiler avatar The-Compiler commented on July 3, 2024

The way this works is that VSpaceCode and which-key both have their own default binding config in package.json. When you launch another instance from "Run Extension" in the which-key repo, it installed new which-key extension in the new debug instance. When you trigger SPC in that debug instance it may still using VSpaceCode binding depending on your setting.

Ah, right, that was precisely the issue! I was wondering where the bindings lived, so I searched and found the ones in which-key, but I was actually looking at the VSpaceCode menu. I wonder if it really makes sense to maintain them at both places, though?

from vscode-which-key.

stevenguh avatar stevenguh commented on July 3, 2024

It was an early design choice. The which-key maintains its own bindings that doesn't require any third party extension including vim, and VSpaceCode maintains its own one that has good out-of-box keybindings similar to spacemacs.

Maintaining a full bindings at both places allows us to see the bindings explicitly in the package.json and allows us to execute different bindings (like one binds to SPC, and another one binds to ESC); implementing layer VSpaceCode/VSpaceCode#199 might changed this thinking.

from vscode-which-key.

MarcoIeni avatar MarcoIeni commented on July 3, 2024

The new window should be running with the new which-key extension. I assume you modified which-key's package.json, and trigger QuickPick menu with the VSpaceCode's config?

The way this works is that VSpaceCode and which-key both have their own default binding config in package.json. When you launch another instance from "Run Extension" in the which-key repo, it installed new which-key extension in the new debug instance. When you trigger SPC in that debug instance it may still using VSpaceCode binding depending on your setting.

If you want to test which-key's default bindings in the package.json, I usually do SPC SPC and type which key and click Which Key: Show Menu in the new debug vscode instance.

This was really useful also for me. Should we add it to the CONTRIBUTING.md?

from vscode-which-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.