Giter Club home page Giter Club logo

Comments (10)

pingshunhuangalex avatar pingshunhuangalex commented on July 22, 2024 1

Thanks Steven. My life is back on track again.

from vscode-which-key.

stevenguh avatar stevenguh commented on July 22, 2024 1

I didn't do the version gating correctly in the last version and I thought I would have released v0.9.0 by now which includes the fix.

Issued v0.8.6 that includes the proper version gating. Sorry about that.

from vscode-which-key.

stevenguh avatar stevenguh commented on July 22, 2024 1

Sorry for the regression. Released v0.9.1 that should fix it.

Btw, I also edited your post to have an expandable toggle for your config reduce the page length of the post.

from vscode-which-key.

stevenguh avatar stevenguh commented on July 22, 2024

VScode changed how they handle input change event @ microsoft/vscode#122939. I am looking into fixing it.

from vscode-which-key.

stevenguh avatar stevenguh commented on July 22, 2024

Fixed in 3212562 and released v0.8.5

from vscode-which-key.

MarcoIeni avatar MarcoIeni commented on July 22, 2024

Thanks Steven 🙏

from vscode-which-key.

pingshunhuangalex avatar pingshunhuangalex commented on July 22, 2024

The issue seems to come back again with 1.58-insider. Haven't tested it on Mac yet, but just discovered it when I updated just now on Windows.

from vscode-which-key.

pingshunhuangalex avatar pingshunhuangalex commented on July 22, 2024

Not sure what I updated this time, but now with v0.9.0 in Windows, no menu items show in the dropdown, only an input box. pressing any key would also just give me an undefined error in the status bar...
image

from vscode-which-key.

stevenguh avatar stevenguh commented on July 22, 2024

@pingshunhuangalex I tested the v0.9.0 n on 1.58-insider, it seems to fine. Can you share your configs?

from vscode-which-key.

pingshunhuangalex avatar pingshunhuangalex commented on July 22, 2024

Thanks for the reply @stevenguh It looks like triggering the extension directly from VS Code menu works fine, but triggering it using the shortcut (backslash) set by myself doesn't. Configs below:

"vim.normalModeKeyBindingsNonRecursive": [
    {
      "before": ["\\"],
      "commands": ["whichkey.show"]
    },
],
"vim.visualModeKeyBindingsNonRecursive": [
    {
      "before": ["\\"],
      "commands": ["whichkey.show"]
    },
],

...

"whichkey.bindings": [
    {
      "key": "\\",
      "name": "Commands...",
      "type": "command",
      "command": "workbench.action.showCommands"
    },
    ...
],

from vscode-which-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.